From: Rainer Hochecker <fernetmenta@kodi.tv>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Ben Widawsky" <ben@bwidawsk.net>,
intel-gfx@lists.freedesktop.org,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: David Herrmann <dh.herrmann@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Rainer Hochecker <fernetmenta@online.de>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: add fourcc codes for 16bit R and GR
Date: Tue, 3 Jan 2017 17:56:10 +0100 [thread overview]
Message-ID: <CAH0Sn6HhaJmFBz5nsfUD7t0xca8=42+5+ia+qG6oQzevX_NCWg@mail.gmail.com> (raw)
In-Reply-To: <CAH0Sn6Em0v8aUnN8mD0-JfJo5zz897+8v9TdDMiPH4fFkp48hQ@mail.gmail.com>
On Mon, Jan 2, 2017 at 3:31 PM, Rainer Hochecker <fernetmenta@kodi.tv> wrote:
>
> I chose GR16 because that matches with Mesa texture formats. Unfortunately
> RG16 is already taken by DRM_FORMAT_RGB565
> So GR32 / RG32 might be better. All other codes in fourcc.h seem to sum up
> all planes.
>
> (sorry, gmail included some html links on last attempt)
>
> On Mon, Jan 2, 2017 at 3:05 PM, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>>
>> On Mon, Jan 02, 2017 at 01:23:23PM +0100, David Herrmann wrote:
>> > Hi
>> >
>> > On Mon, Jan 2, 2017 at 11:41 AM, Rainer Hochecker <fernetmenta@kodi.tv> wrote:
>> > > From: Rainer Hochecker <fernetmenta@online.de>
>> > >
>> > > Add fourcc codes for 16bit planes. Required by mesa for
>> > > eglCreateImageKHR to access P010 surfaces created by vaapi.
>> > >
>> > > Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
>> > > ---
>> > > include/uapi/drm/drm_fourcc.h | 6 ++++++
>> > > 1 file changed, 6 insertions(+)
>> > >
>> > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
>> > > index a5890bf..e6ab638 100644
>> > > --- a/include/uapi/drm/drm_fourcc.h
>> > > +++ b/include/uapi/drm/drm_fourcc.h
>> > > @@ -41,10 +41,16 @@ extern "C" {
>> > > /* 8 bpp Red */
>> > > #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
>> > >
>> > > +/* 16 bpp Red */
>> > > +#define DRM_FORMAT_R16 fourcc_code('R', '1', '6', ' ') /* [15:0] R */
>> > > +
>> > > /* 16 bpp RG */
>> > > #define DRM_FORMAT_RG88 fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */
>> > > #define DRM_FORMAT_GR88 fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */
>> > >
>> > > +/* 32 bpp GR */
>> > > +#define DRM_FORMAT_GR16 fourcc_code('G', 'R', '1', '6') /* [31:0] G:R 16:16 little endian */
>> > > +
>> >
>> > Shouldn't it be 'G', 'R', '3', '2'?
>>
>> The name should be _GR1616. Using GR16 for the fourcc seems OK to me
>> since we can't fit in the full GR1616 in there. Althogh GR32 could work
>> too I suppose.
>>
>> And what about RG16?
>>
>> >
>> > Also, please put dri-devel on CC.
>> >
>> > Thanks
>> > David
>> >
>> > > /* 8 bpp RGB */
>> > > #define DRM_FORMAT_RGB332 fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */
>> > > #define DRM_FORMAT_BGR233 fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */
>> > > --
>> > > 2.9.3
>> > >
>> > _______________________________________________
>> > dri-devel mailing list
>> > dri-devel@lists.freedesktop.org
>> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>>
>> --
>> Ville Syrjälä
>> Intel OTC
>
>
Updated patch as suggested by Ville Syrjälä
>From 29e74ff96e0b7c7a11d1b4131891b83adde621c1 Mon Sep 17 00:00:00 2001
From: Rainer Hochecker <fernetmenta@online.de>
Date: Mon, 2 Jan 2017 11:25:18 +0100
Subject: [PATCH] drm: add fourcc codes for 16bit R and GR
Signed-off-by: Rainer Hochecker <fernetmenta@online.de>
---
include/uapi/drm/drm_fourcc.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
index a5890bf..f1ef9cb 100644
--- a/include/uapi/drm/drm_fourcc.h
+++ b/include/uapi/drm/drm_fourcc.h
@@ -41,10 +41,17 @@ extern "C" {
/* 8 bpp Red */
#define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */
+/* 16 bpp Red */
+#define DRM_FORMAT_R16 fourcc_code('R', '1', '6', ' ') /* [15:0] R */
+
/* 16 bpp RG */
#define DRM_FORMAT_RG88 fourcc_code('R', 'G', '8', '8') /* [15:0] R:G
8:8 little endian */
#define DRM_FORMAT_GR88 fourcc_code('G', 'R', '8', '8') /* [15:0] G:R
8:8 little endian */
+/* 32 bpp GR */
+#define DRM_FORMAT_RG32 fourcc_code('R', 'G', '3', '2') /* [31:0] G:R
16:16 little endian */
+#define DRM_FORMAT_GR32 fourcc_code('G', 'R', '3', '2') /* [31:0] G:R
16:16 little endian */
+
/* 8 bpp RGB */
#define DRM_FORMAT_RGB332 fourcc_code('R', 'G', 'B', '8') /* [7:0]
R:G:B 3:3:2 */
#define DRM_FORMAT_BGR233 fourcc_code('B', 'G', 'R', '8') /* [7:0]
B:G:R 2:3:3 */
--
2.9.3
next prev parent reply other threads:[~2017-01-03 16:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 10:41 [PATCH] drm: add fourcc codes for 16bit R and GR Rainer Hochecker
2017-01-02 12:23 ` David Herrmann
2017-01-02 14:05 ` Ville Syrjälä
[not found] ` <CAH0Sn6Em0v8aUnN8mD0-JfJo5zz897+8v9TdDMiPH4fFkp48hQ@mail.gmail.com>
2017-01-03 16:56 ` Rainer Hochecker [this message]
2017-01-03 18:21 ` Eric Engestrom
2017-01-03 19:02 ` [PATCH v2] " Rainer Hochecker
2017-01-04 8:52 ` Daniel Vetter
2017-01-04 9:06 ` [Intel-gfx] " Jani Nikula
2017-01-04 10:19 ` Eric Engestrom
2017-01-04 13:45 ` [PATCH v3] drm: add fourcc codes for 16bit R and RG Rainer Hochecker
2017-01-04 13:50 ` [PATCH v4] " Rainer Hochecker
2017-01-04 18:04 ` Eric Engestrom
2017-01-04 18:24 ` [PATCH v5] " Rainer Hochecker
2017-01-04 18:28 ` Ville Syrjälä
2017-01-04 18:38 ` [PATCH v6] " Rainer Hochecker
2017-01-05 11:37 ` Ville Syrjälä
2017-01-05 13:45 ` Christian König
2017-01-11 15:05 ` Ville Syrjälä
2017-01-11 15:44 ` Ben Widawsky
2017-01-11 16:41 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH0Sn6HhaJmFBz5nsfUD7t0xca8=42+5+ia+qG6oQzevX_NCWg@mail.gmail.com' \
--to=fernetmenta@kodi.tv \
--cc=ben@bwidawsk.net \
--cc=daniel@ffwll.ch \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fernetmenta@online.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).