From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Haojian Zhuang <haojian.zhuang@linaro.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
Nishanth Menon <nm@ti.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 1/5] pinctrl: core: Use delayed work for hogs
Date: Wed, 11 Jan 2017 10:31:06 -0800 [thread overview]
Message-ID: <20170111183106.GY2630@atomide.com> (raw)
In-Reply-To: <20170111162808.GW2630@atomide.com>
* Tony Lindgren <tony@atomide.com> [170111 08:29]:
> * Linus Walleij <linus.walleij@linaro.org> [170111 07:34]:
> > On Tue, Jan 10, 2017 at 8:19 PM, Tony Lindgren <tony@atomide.com> wrote:
> >
> > > Below is an experimental fix to intorduce pinctrl_start() that I've
> > > tested with pinctrl-single. Then we should probably make all pin controller
> > > drivers call pinctrl_start() to properly fix the issue of struct pinctrl_dev
> > > handle not being initialized before driver functions are called.
> >
> > Hm I guess that could work, but can we keep pinctrl_register() with the old
> > semantics and add a separate pinctrl_register_and_defer()
> > for those who just wanna start it later by a separate call?
> >
> > Then we don't need any special flags.
>
> OK I'll take a look.
>
> > > Or do you guys have any better ideas?
> >
> > Not really. So you mean revert the previous patch and apply something
> > like this instead?
>
> Let me first take a look to see if we can fix it by making drivers using
> GENERIC_PINCTRL_GROUPS or GENERIC_PINMUX_FUNCTIONS register with
> pinctrl_register_and_defer(). I'll post a patch for that today.
Yeah we can fix this by reverting the late_init parts of the earlier
attempt and introducing a new pinctrl_register_and_init() for controllers
to use:
extern int pinctrl_register_and_init(struct pinctrl_desc *pctldesc,
struct device *dev, void *driver_data,
struct pinctrl_dev **pctldev);
> Then maybe for v4.12 we can attempt to move all pin controller drivers
> to using it so we can fix the problem for good.
And that will also make converting existing drivers to use it later on
trivial.
Will post a patch shortly after some more testing.
Regards,
Tony
next prev parent reply other threads:[~2017-01-11 18:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 17:19 [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Tony Lindgren
2016-12-27 17:19 ` [PATCH 1/5] pinctrl: core: Use delayed work for hogs Tony Lindgren
2016-12-30 13:46 ` Linus Walleij
2017-01-10 14:08 ` Geert Uytterhoeven
2017-01-10 15:30 ` Tony Lindgren
2017-01-10 19:19 ` Tony Lindgren
2017-01-11 15:33 ` Linus Walleij
2017-01-11 16:28 ` Tony Lindgren
2017-01-11 18:31 ` Tony Lindgren [this message]
2016-12-27 17:20 ` [PATCH 2/5] pinctrl: core: Add generic pinctrl functions for managing groups Tony Lindgren
2016-12-30 14:12 ` Linus Walleij
2016-12-30 15:57 ` Tony Lindgren
2016-12-27 17:20 ` [PATCH 3/5] " Tony Lindgren
2016-12-30 14:09 ` Linus Walleij
2016-12-30 14:28 ` Linus Walleij
2017-01-02 16:21 ` [3/5] " Gary Bisson
2017-01-02 17:08 ` Tony Lindgren
2016-12-27 17:20 ` [PATCH 4/5] pinctrl: single: Use generic pinctrl helpers " Tony Lindgren
2016-12-30 14:32 ` Linus Walleij
2016-12-27 17:20 ` [PATCH 5/5] pinctrl: single: Use generic pinmux helpers for managing functions Tony Lindgren
2016-12-30 14:35 ` Linus Walleij
2016-12-30 14:39 ` [PATCHv2 0/5] Add generic pinctrl helpers for managing groups and function Linus Walleij
2016-12-30 15:43 ` Gary Bisson
2016-12-30 15:59 ` Tony Lindgren
2017-01-02 16:14 ` Gary Bisson
-- strict thread matches above, loose matches on Subject: below --
2016-10-25 21:02 [PATCH 0/5] Add generic pinctrl helpers for managing groups and functions Tony Lindgren
2016-10-25 21:02 ` [PATCH 1/5] pinctrl: core: Use delayed work for hogs Tony Lindgren
2016-11-11 20:17 ` Linus Walleij
2016-11-11 20:26 ` Tony Lindgren
2016-11-11 20:32 ` Tony Lindgren
2016-11-11 20:56 ` Tony Lindgren
2016-11-14 20:52 ` Tony Lindgren
2016-11-14 22:08 ` Tony Lindgren
2016-11-15 0:47 ` Tony Lindgren
2016-11-15 6:52 ` Linus Walleij
2016-11-15 15:41 ` Tony Lindgren
2016-11-15 17:08 ` Tony Lindgren
2016-12-02 13:08 ` Linus Walleij
2016-12-02 16:44 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111183106.GY2630@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=grygorii.strashko@ti.com \
--cc=haojian.zhuang@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=nm@ti.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).