[PATCH] drivers: block: Remove unnecessary cast

[PATCH] drivers: block: Remove unnecessary cast

[Gustavo A. R. Silva]

This issue was detected using Coccinelle and the following semantic patch:

@@
expression * e;
expression arg1, arg2;
type T;
@@

- e = (T *)
+ e =
kmalloc(arg1, arg2);

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/block/cciss_scsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/cciss_scsi.c b/drivers/block/cciss_scsi.c
index a18de9d..98ba8fc 100644
--- a/drivers/block/cciss_scsi.c
+++ b/drivers/block/cciss_scsi.c
@@ -647,8 +647,7 @@ cciss_scsi_setup(ctlr_info_t *h)
 	struct cciss_scsi_adapter_data_t * shba;
 
 	ccissscsi[h->ctlr].ndevices = 0;
-	shba = (struct cciss_scsi_adapter_data_t *)
-		kmalloc(sizeof(*shba), GFP_KERNEL);	
+	shba = kmalloc(sizeof(*shba), GFP_KERNEL);
 	if (shba == NULL)
 		return;
 	shba->scsi_host = NULL;
-- 
2.5.0

Re: [PATCH] drivers: block: Remove unnecessary cast

[Greg KH]

On Wed, Jan 11, 2017 at 12:41:05PM -0600, Gustavo A. R. Silva wrote:
> This issue was detected using Coccinelle and the following semantic patch:
> 
> @@
> expression * e;
> expression arg1, arg2;
> type T;
> @@
> 
> - e = (T *)
> + e =
> kmalloc(arg1, arg2);
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/block/cciss_scsi.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Why send this to me?

Re: [PATCH] drivers: block: Remove unnecessary cast

[Gustavo A. R. Silva]

Quoting Greg KH <gregkh@linuxfoundation.org>:

> On Wed, Jan 11, 2017 at 12:41:05PM -0600, Gustavo A. R. Silva wrote:
>> This issue was detected using Coccinelle and the following semantic patch:
>>
>> @@
>> expression * e;
>> expression arg1, arg2;
>> type T;
>> @@
>>
>> - e = (T *)
>> + e =
>> kmalloc(arg1, arg2);
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/block/cciss_scsi.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> Why send this to me?

Oops... Sorry... I was also working with the Staging tree, so it seems  
your e-mail address got in the middle at some point.

--
Gustavo A. R. Silva