[PATCH] livepatch/module: print notice of TAINT_LIVEPATCH

[PATCH] livepatch/module: print notice of TAINT_LIVEPATCH

[Joe Lawrence]

Add back the "tainting kernel with TAINT_LIVEPATCH" kernel log message
that commit 2992ef29ae01 ("livepatch/module: make TAINT_LIVEPATCH
module-specific") dropped.  Now that it's a module-specific taint flag,
include the module name.

Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>
---
 kernel/module.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/module.c b/kernel/module.c
index 5088784c0cf9..330f64e7e193 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2812,6 +2812,8 @@ static int check_modinfo_livepatch(struct module *mod, struct load_info *info)
 	if (get_modinfo(info, "livepatch")) {
 		mod->klp = true;
 		add_taint_module(mod, TAINT_LIVEPATCH, LOCKDEP_STILL_OK);
+		pr_notice_once("%s: tainting kernel with TAINT_LIVEPATCH\n",
+			       mod->name);
 	}
 
 	return 0;
-- 
1.8.3.1

Re: [PATCH] livepatch/module: print notice of TAINT_LIVEPATCH

[Josh Poimboeuf]

On Thu, Jan 12, 2017 at 11:57:44AM -0500, Joe Lawrence wrote:
> Add back the "tainting kernel with TAINT_LIVEPATCH" kernel log message
> that commit 2992ef29ae01 ("livepatch/module: make TAINT_LIVEPATCH
> module-specific") dropped.  Now that it's a module-specific taint flag,
> include the module name.
> 
> Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

> ---
>  kernel/module.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 5088784c0cf9..330f64e7e193 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2812,6 +2812,8 @@ static int check_modinfo_livepatch(struct module *mod, struct load_info *info)
>  	if (get_modinfo(info, "livepatch")) {
>  		mod->klp = true;
>  		add_taint_module(mod, TAINT_LIVEPATCH, LOCKDEP_STILL_OK);
> +		pr_notice_once("%s: tainting kernel with TAINT_LIVEPATCH\n",
> +			       mod->name);
>  	}
>  
>  	return 0;
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe live-patching" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Josh

Re: livepatch/module: print notice of TAINT_LIVEPATCH

[Jessica Yu]

+++ Joe Lawrence [12/01/17 11:57 -0500]:
>Add back the "tainting kernel with TAINT_LIVEPATCH" kernel log message
>that commit 2992ef29ae01 ("livepatch/module: make TAINT_LIVEPATCH
>module-specific") dropped.  Now that it's a module-specific taint flag,
>include the module name.
>
>Signed-off-by: Joe Lawrence <joe.lawrence@redhat.com>

Applied, thanks.

Jessica