* [PATCH] perf/tool: remove unneccessary feature-dwarf warning
@ 2017-01-12 21:01 David Carrillo-Cisneros
2017-01-13 14:47 ` Arnaldo Carvalho de Melo
2017-01-18 9:19 ` [tip:perf/core] perf tools: Remove " tip-bot for David Carrillo-Cisneros
0 siblings, 2 replies; 3+ messages in thread
From: David Carrillo-Cisneros @ 2017-01-12 21:01 UTC (permalink / raw)
To: linux-kernel
Cc: Ingo Molnar, Peter Zijlstra, Arnaldo Carvalho de Melo,
Alexander Shishkin, Stephane Eranian, David Carrillo-Cisneros
Don't warn for feature-dwarf==0 if user explicitily
disabled dwarf by NO_DWARF=1.
Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
---
tools/perf/Makefile.config | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 94318c07d89d..bf79344cd10c 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -291,8 +291,10 @@ else
endif
endif
ifneq ($(feature-dwarf), 1)
- msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev);
- NO_DWARF := 1
+ ifndef NO_DWARF
+ msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev);
+ NO_DWARF := 1
+ endif
else
ifneq ($(feature-dwarf_getlocations), 1)
msg := $(warning Old libdw.h, finding variables at given 'perf probe' point will not work, install elfutils-devel/libdw-dev >= 0.157);
--
2.11.0.390.gc69c2f50cf-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] perf/tool: remove unneccessary feature-dwarf warning
2017-01-12 21:01 [PATCH] perf/tool: remove unneccessary feature-dwarf warning David Carrillo-Cisneros
@ 2017-01-13 14:47 ` Arnaldo Carvalho de Melo
2017-01-18 9:19 ` [tip:perf/core] perf tools: Remove " tip-bot for David Carrillo-Cisneros
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-01-13 14:47 UTC (permalink / raw)
To: David Carrillo-Cisneros
Cc: linux-kernel, Ingo Molnar, Peter Zijlstra, Alexander Shishkin,
Stephane Eranian
Em Thu, Jan 12, 2017 at 01:01:59PM -0800, David Carrillo-Cisneros escreveu:
> Don't warn for feature-dwarf==0 if user explicitily
> disabled dwarf by NO_DWARF=1.
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/core] perf tools: Remove unneccessary feature-dwarf warning
2017-01-12 21:01 [PATCH] perf/tool: remove unneccessary feature-dwarf warning David Carrillo-Cisneros
2017-01-13 14:47 ` Arnaldo Carvalho de Melo
@ 2017-01-18 9:19 ` tip-bot for David Carrillo-Cisneros
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for David Carrillo-Cisneros @ 2017-01-18 9:19 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, davidcc, peterz, tglx, eranian, alexander.shishkin,
acme, hpa, mingo
Commit-ID: 2484c4c58fd1bc0d7711d294c530a1518da6a172
Gitweb: http://git.kernel.org/tip/2484c4c58fd1bc0d7711d294c530a1518da6a172
Author: David Carrillo-Cisneros <davidcc@google.com>
AuthorDate: Thu, 12 Jan 2017 13:01:59 -0800
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 16 Jan 2017 14:59:15 -0300
perf tools: Remove unneccessary feature-dwarf warning
Don't warn for feature-dwarf==0 if user explicitily disabled DWARF by
using NO_DWARF=1.
Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/r/20170112210159.76143-1-davidcc@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/Makefile.config | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index 76c84f0..03cf947 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -291,8 +291,10 @@ else
endif
endif
ifneq ($(feature-dwarf), 1)
- msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev);
- NO_DWARF := 1
+ ifndef NO_DWARF
+ msg := $(warning No libdw.h found or old libdw.h found or elfutils is older than 0.138, disables dwarf support. Please install new elfutils-devel/libdw-dev);
+ NO_DWARF := 1
+ endif
else
ifneq ($(feature-dwarf_getlocations), 1)
msg := $(warning Old libdw.h, finding variables at given 'perf probe' point will not work, install elfutils-devel/libdw-dev >= 0.157);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-18 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-12 21:01 [PATCH] perf/tool: remove unneccessary feature-dwarf warning David Carrillo-Cisneros
2017-01-13 14:47 ` Arnaldo Carvalho de Melo
2017-01-18 9:19 ` [tip:perf/core] perf tools: Remove " tip-bot for David Carrillo-Cisneros
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).