From: Chris Wilson <chris@chris-wilson.co.uk>
To: lkml@pengaru.com
Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org,
"# v4 . 10-rc1+" <drm-intel-fixes@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915: Flush untouched framebuffers before display on !llc
Date: Thu, 12 Jan 2017 22:38:07 +0000 [thread overview]
Message-ID: <20170112223807.GA3985@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20170112222450.GE32751@shells.gnugeneration.com>
On Thu, Jan 12, 2017 at 04:24:50PM -0600, lkml@pengaru.com wrote:
> On Thu, Jan 12, 2017 at 09:17:06PM +0000, Chris Wilson wrote:
> > On Mon, Jan 09, 2017 at 11:19:32AM +0000, Chris Wilson wrote:
> > > On a non-llc system, the objects are created with .cache_level =
> > > CACHE_NONE and so the transition to uncached for scanout is a no-op.
> > > However, if the object was never written to, it will still be in the CPU
> > > domain (having been zeroed out by shmemfs). Those cachelines need to be
> > > flushed prior to display.
> > >
> > > Reported-by: Vito Caputo
> > > Fixes: a6a7cc4b7db6 ("drm/i915: Always flush the dirty CPU cache when pinning the scanout")
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: <drm-intel-fixes@lists.freedesktop.org> # v4.10-rc1+
> >
> > Ping?
>
> This patch fixes the problem for me, in case that's what the ping's for.
Partly that, and trying to catch CI + reviewers.
> Out of curiosity the bug I reported described here be getting fixed in 4.10?
> https://lists.freedesktop.org/archives/dri-devel/2017-January/128405.html
It was fixed in the tree back in December, bit of a muddle to get that
particular patch into 4.10.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2017-01-12 22:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 6:32 BUG: 4.10 i915 drm display noise regression - bisected to a6a7cc4b7 lkml
2017-01-09 10:24 ` [PATCH] drm/i915: Flush untouched framebuffers before display on !llc Chris Wilson
2017-01-09 10:52 ` Chris Wilson
2017-01-09 13:48 ` [Intel-gfx] " kbuild test robot
2017-01-09 11:19 ` [PATCH v2] " Chris Wilson
2017-01-12 21:17 ` Chris Wilson
2017-01-12 22:24 ` lkml
2017-01-12 22:38 ` Chris Wilson [this message]
2017-02-01 10:24 ` [Intel-gfx] " Daniel Vetter
2017-02-01 10:48 ` Chris Wilson
2017-01-30 2:04 ` BUG: 4.10 i915 drm display noise regression - bisected to a6a7cc4b7 lkml
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170112223807.GA3985@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=drm-intel-fixes@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@pengaru.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).