* [PATCH] perf script: Also allow forcing reading of non-root owned files by root
@ 2017-01-13 18:25 Yannick Brosseau
2017-01-13 19:24 ` Arnaldo Carvalho de Melo
2017-01-18 9:21 ` [tip:perf/core] " tip-bot for Yannick Brosseau
0 siblings, 2 replies; 3+ messages in thread
From: Yannick Brosseau @ 2017-01-13 18:25 UTC (permalink / raw)
To: acme; +Cc: namhyung, linux-kernel, kernel-team, mbd, Yannick Brosseau
In 2059fc7a5a9e6677, perf report was added the option of forcing reading
of non-root owned symbol file.
This add the same behavior for perf script.
Reported-by: Mark Drayton <mbd@fb.com>
Signed-off-by: Yannick Brosseau <scientist@fb.com>
---
tools/perf/builtin-script.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 2f3ff69fc4e7..c0783b4f7b6c 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2180,7 +2180,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
"Show the mmap events"),
OPT_BOOLEAN('\0', "show-switch-events", &script.show_switch_events,
"Show context switch events (if recorded)"),
- OPT_BOOLEAN('f', "force", &file.force, "don't complain, do it"),
+ OPT_BOOLEAN('f', "force", &symbol_conf.force, "don't complain, do it"),
OPT_BOOLEAN(0, "ns", &nanosecs,
"Use 9 decimal places when displaying time"),
OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts",
@@ -2212,6 +2212,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
PARSE_OPT_STOP_AT_NON_OPTION);
file.path = input_name;
+ file.force = symbol_conf.force;
if (argc > 1 && !strncmp(argv[0], "rec", strlen("rec"))) {
rec_script_path = get_script_path(argv[1], RECORD_SUFFIX);
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] perf script: Also allow forcing reading of non-root owned files by root
2017-01-13 18:25 [PATCH] perf script: Also allow forcing reading of non-root owned files by root Yannick Brosseau
@ 2017-01-13 19:24 ` Arnaldo Carvalho de Melo
2017-01-18 9:21 ` [tip:perf/core] " tip-bot for Yannick Brosseau
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2017-01-13 19:24 UTC (permalink / raw)
To: Yannick Brosseau; +Cc: namhyung, linux-kernel, kernel-team, mbd
Em Fri, Jan 13, 2017 at 01:25:27PM -0500, Yannick Brosseau escreveu:
> In 2059fc7a5a9e6677, perf report was added the option of forcing reading
> of non-root owned symbol file.
>
> This add the same behavior for perf script.
looks ok, applied.
- Arnaldo
> Reported-by: Mark Drayton <mbd@fb.com>
> Signed-off-by: Yannick Brosseau <scientist@fb.com>
> ---
> tools/perf/builtin-script.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 2f3ff69fc4e7..c0783b4f7b6c 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -2180,7 +2180,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
> "Show the mmap events"),
> OPT_BOOLEAN('\0', "show-switch-events", &script.show_switch_events,
> "Show context switch events (if recorded)"),
> - OPT_BOOLEAN('f', "force", &file.force, "don't complain, do it"),
> + OPT_BOOLEAN('f', "force", &symbol_conf.force, "don't complain, do it"),
> OPT_BOOLEAN(0, "ns", &nanosecs,
> "Use 9 decimal places when displaying time"),
> OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts",
> @@ -2212,6 +2212,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
> PARSE_OPT_STOP_AT_NON_OPTION);
>
> file.path = input_name;
> + file.force = symbol_conf.force;
>
> if (argc > 1 && !strncmp(argv[0], "rec", strlen("rec"))) {
> rec_script_path = get_script_path(argv[1], RECORD_SUFFIX);
> --
> 2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* [tip:perf/core] perf script: Also allow forcing reading of non-root owned files by root
2017-01-13 18:25 [PATCH] perf script: Also allow forcing reading of non-root owned files by root Yannick Brosseau
2017-01-13 19:24 ` Arnaldo Carvalho de Melo
@ 2017-01-18 9:21 ` tip-bot for Yannick Brosseau
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Yannick Brosseau @ 2017-01-18 9:21 UTC (permalink / raw)
To: linux-tip-commits
Cc: mingo, namhyung, acme, scientist, hpa, linux-kernel, mbd, tglx
Commit-ID: be3d466c7356e574a2aa4e19dd20b19b3a9cc4fc
Gitweb: http://git.kernel.org/tip/be3d466c7356e574a2aa4e19dd20b19b3a9cc4fc
Author: Yannick Brosseau <scientist@fb.com>
AuthorDate: Fri, 13 Jan 2017 13:25:27 -0500
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Mon, 16 Jan 2017 14:59:15 -0300
perf script: Also allow forcing reading of non-root owned files by root
In 2059fc7a5a9e ("perf symbols: Allow forcing reading of non-root owned
files by root") 'perf report' was added the option of forcing reading of
non-root owned symbol file.
This add the same behavior for perf script.
Reported-by: Mark Drayton <mbd@fb.com>
Signed-off-by: Yannick Brosseau <scientist@fb.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: kernel-team@fb.com
Link: http://lkml.kernel.org/r/20170113182527.18625-1-scientist@fb.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-script.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 2f3ff69..c0783b4 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2180,7 +2180,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
"Show the mmap events"),
OPT_BOOLEAN('\0', "show-switch-events", &script.show_switch_events,
"Show context switch events (if recorded)"),
- OPT_BOOLEAN('f', "force", &file.force, "don't complain, do it"),
+ OPT_BOOLEAN('f', "force", &symbol_conf.force, "don't complain, do it"),
OPT_BOOLEAN(0, "ns", &nanosecs,
"Use 9 decimal places when displaying time"),
OPT_CALLBACK_OPTARG(0, "itrace", &itrace_synth_opts, NULL, "opts",
@@ -2212,6 +2212,7 @@ int cmd_script(int argc, const char **argv, const char *prefix __maybe_unused)
PARSE_OPT_STOP_AT_NON_OPTION);
file.path = input_name;
+ file.force = symbol_conf.force;
if (argc > 1 && !strncmp(argv[0], "rec", strlen("rec"))) {
rec_script_path = get_script_path(argv[1], RECORD_SUFFIX);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-18 9:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-13 18:25 [PATCH] perf script: Also allow forcing reading of non-root owned files by root Yannick Brosseau
2017-01-13 19:24 ` Arnaldo Carvalho de Melo
2017-01-18 9:21 ` [tip:perf/core] " tip-bot for Yannick Brosseau
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).