From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: aduyck@mirantis.com, jiri@mellanox.com, tom@herbertland.com,
edumazet@google.com, hadarh@mellanox.com,
simon.horman@netronome.com, fgao@48lvckh6395k16k5.yundunddos.com,
amir@vadai.me, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][V2] flow dissector: check if arp_eth is null rather than arp
Date: Mon, 16 Jan 2017 13:49:10 -0500 (EST) [thread overview]
Message-ID: <20170116.134910.2033399594368664910.davem@davemloft.net> (raw)
In-Reply-To: <20170113184820.823-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Fri, 13 Jan 2017 18:48:20 +0000
> From: Colin Ian King <colin.king@canonical.com>
>
> arp is being checked instead of arp_eth to see if the call to
> __skb_header_pointer failed. Fix this by checking arp_eth is
> null instead of arp. Also fix to use length hlen rather than
> hlen - sizeof(_arp); thanks to Eric Dumazet for spotting
> this latter issue.
>
> CoverityScan CID#1396428 ("Logically dead code") on 2nd
> arp comparison (which should be arp_eth instead).
>
> Fixes: commit 55733350e5e8b70c5 ("flow disector: ARP support")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
prev parent reply other threads:[~2017-01-16 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 18:48 [PATCH][V2] flow dissector: check if arp_eth is null rather than arp Colin King
2017-01-13 19:02 ` Eric Dumazet
2017-01-16 18:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116.134910.2033399594368664910.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aduyck@mirantis.com \
--cc=amir@vadai.me \
--cc=colin.king@canonical.com \
--cc=edumazet@google.com \
--cc=fgao@48lvckh6395k16k5.yundunddos.com \
--cc=hadarh@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=simon.horman@netronome.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).