linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned
@ 2017-01-16  4:30 Derek Robson
  2017-01-16  4:40 ` Scott Matheina
  2017-01-16  5:05 ` kbuild test robot
  0 siblings, 2 replies; 5+ messages in thread
From: Derek Robson @ 2017-01-16  4:30 UTC (permalink / raw)
  To: mchehab, gregkh, jb, robsonde, aquannie, bankarsandhya512,
	bhumirks, claudiu.beznea
  Cc: linux-media, devel, linux-kernel

Changed bare use of 'unsigned' to the prefered us of 'unsigned int'
found using checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +++++++++++++--------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index 37bd439ee08b..b1923a3e4483 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -2020,27 +2020,27 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
 	return count;							\
 }
 
-DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
-
-DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
-
-DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
+
+DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
+
+DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)
 property_read(rds_pi, unsigned int, "%x")
 property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
 property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
@@ -2052,7 +2052,7 @@ property_read(region_bottom_frequency, unsigned int, "%u")
 property_read(region_top_frequency, unsigned int, "%u")
 property_signed_read(fm_carrier_error, int, "%d")
 property_signed_read(fm_rssi, int, "%d")
-DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
 
 static struct device_attribute attrs[] = {
 	__ATTR(power_state, 0644, bcm2048_power_state_read,
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned
  2017-01-16  4:30 [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned Derek Robson
@ 2017-01-16  4:40 ` Scott Matheina
  2017-01-16  5:06   ` Derek Robson
  2017-01-16  5:05 ` kbuild test robot
  1 sibling, 1 reply; 5+ messages in thread
From: Scott Matheina @ 2017-01-16  4:40 UTC (permalink / raw)
  To: Derek Robson
  Cc: mchehab, gregkh, jb, aquannie, bankarsandhya512, bhumirks,
	claudiu.beznea, linux-media, devel, linux-kernel



> On Jan 15, 2017, at 10:30 PM, Derek Robson <robsonde@gmail.com> wrote:
> 
> Changed bare use of 'unsigned' to the prefered us of 'unsigned int'
> found using checkpatch

Just wondering if you compiled? This patch looks exactly like a patch I tried, but it didn't compile. 

> Signed-off-by: Derek Robson <robsonde@gmail.com>
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +++++++++++++--------------
> 1 file changed, 22 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index 37bd439ee08b..b1923a3e4483 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -2020,27 +2020,27 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,        \
>    return count;                            \
> }
> 
> -DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
> -
> -DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
> -
> -DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
> +
> +DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
> +
> +DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)
> property_read(rds_pi, unsigned int, "%x")
> property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
> property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
> @@ -2052,7 +2052,7 @@ property_read(region_bottom_frequency, unsigned int, "%u")
> property_read(region_top_frequency, unsigned int, "%u")
> property_signed_read(fm_carrier_error, int, "%d")
> property_signed_read(fm_rssi, int, "%d")
> -DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
> 
> static struct device_attribute attrs[] = {
>    __ATTR(power_state, 0644, bcm2048_power_state_read,
> -- 
> 2.11.0

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned
  2017-01-16  4:30 [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned Derek Robson
  2017-01-16  4:40 ` Scott Matheina
@ 2017-01-16  5:05 ` kbuild test robot
  1 sibling, 0 replies; 5+ messages in thread
From: kbuild test robot @ 2017-01-16  5:05 UTC (permalink / raw)
  To: Derek Robson
  Cc: kbuild-all, mchehab, gregkh, jb, robsonde, aquannie,
	bankarsandhya512, bhumirks, claudiu.beznea, devel, linux-kernel,
	linux-media

[-- Attachment #1: Type: text/plain, Size: 8567 bytes --]

Hi Derek,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.10-rc4 next-20170113]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Derek-Robson/Staging-media-bcm2048-style-fix-bare-use-of-unsigned/20170116-123500
base:   git://linuxtv.org/media_tree.git master
config: i386-randconfig-x005-201703 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_power_state_write':
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2023:50: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
                                                     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
>> drivers/staging/media/bcm2048/radio-bcm2048.c:2023:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_mute_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2024:43: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
                                              ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2024:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_audio_route_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2025:50: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
                                                     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2025:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_dac_output_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2026:49: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
                                                    ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2026:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_hi_lo_injection_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2028:57: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
                                                            ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2028:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_frequency_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2029:51: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
                                                      ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2029:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_af_frequency_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2030:54: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
                                                         ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2030:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_deemphasis_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2031:52: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
                                                       ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2031:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_rds_mask_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2032:50: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
                                                     ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2032:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_best_tune_mode_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2033:56: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
                                                           ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2033:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'
    DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
    ^~~~~~~~~~~~~~~~~~~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c: In function 'bcm2048_fm_search_rssi_threshold_write':
   drivers/staging/media/bcm2048/radio-bcm2048.c:2034:63: error: two or more data types in declaration specifiers
    DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
                                                                  ^
   drivers/staging/media/bcm2048/radio-bcm2048.c:1943:2: note: in definition of macro 'property_write'
     type value;       \
     ^~~~
   drivers/staging/media/bcm2048/radio-bcm2048.c:2034:1: note: in expansion of macro 'DEFINE_SYSFS_PROPERTY'

vim +2023 drivers/staging/media/bcm2048/radio-bcm2048.c

  2017										\
  2018		kfree(out);							\
  2019										\
  2020		return count;							\
  2021	}
  2022	
> 2023	DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
  2024	DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
  2025	DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
  2026	DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29773 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned
  2017-01-16  4:40 ` Scott Matheina
@ 2017-01-16  5:06   ` Derek Robson
  2017-01-16 10:36     ` Greg KH
  0 siblings, 1 reply; 5+ messages in thread
From: Derek Robson @ 2017-01-16  5:06 UTC (permalink / raw)
  To: Scott Matheina
  Cc: mchehab, gregkh, jb, aquannie, bankarsandhya512, bhumirks,
	claudiu.beznea, linux-media, devel, linux-kernel

On Sun, Jan 15, 2017 at 10:40:02PM -0600, Scott Matheina wrote:
> 
> 
> > On Jan 15, 2017, at 10:30 PM, Derek Robson <robsonde@gmail.com> wrote:
> > 
> > Changed bare use of 'unsigned' to the prefered us of 'unsigned int'
> > found using checkpatch
> 
> Just wondering if you compiled? This patch looks exactly like a patch I tried, but it didn't compile. 
> 

It complied for me, I am on an X86 system.

> > Signed-off-by: Derek Robson <robsonde@gmail.com>
> > ---
> > drivers/staging/media/bcm2048/radio-bcm2048.c | 44 +++++++++++++--------------
> > 1 file changed, 22 insertions(+), 22 deletions(-)
> > 
> > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > index 37bd439ee08b..b1923a3e4483 100644
> > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > @@ -2020,27 +2020,27 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,        \
> >    return count;                            \
> > }
> > 
> > -DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
> > -
> > -DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
> > -
> > -DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
> > +
> > +DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
> > +
> > +DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)
> > property_read(rds_pi, unsigned int, "%x")
> > property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
> > property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
> > @@ -2052,7 +2052,7 @@ property_read(region_bottom_frequency, unsigned int, "%u")
> > property_read(region_top_frequency, unsigned int, "%u")
> > property_signed_read(fm_carrier_error, int, "%d")
> > property_signed_read(fm_rssi, int, "%d")
> > -DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
> > 
> > static struct device_attribute attrs[] = {
> >    __ATTR(power_state, 0644, bcm2048_power_state_read,
> > -- 
> > 2.11.0
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned
  2017-01-16  5:06   ` Derek Robson
@ 2017-01-16 10:36     ` Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2017-01-16 10:36 UTC (permalink / raw)
  To: Derek Robson
  Cc: Scott Matheina, mchehab, jb, aquannie, bankarsandhya512,
	bhumirks, claudiu.beznea, linux-media, devel, linux-kernel

On Mon, Jan 16, 2017 at 06:06:25PM +1300, Derek Robson wrote:
> On Sun, Jan 15, 2017 at 10:40:02PM -0600, Scott Matheina wrote:
> > 
> > 
> > > On Jan 15, 2017, at 10:30 PM, Derek Robson <robsonde@gmail.com> wrote:
> > > 
> > > Changed bare use of 'unsigned' to the prefered us of 'unsigned int'
> > > found using checkpatch
> > 
> > Just wondering if you compiled? This patch looks exactly like a patch I tried, but it didn't compile. 
> > 
> 
> It complied for me, I am on an X86 system.

I don't believe you, and kbuild backs that up  :)

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-01-16 10:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-16  4:30 [PATCH] Staging: media: bcm2048: style fix - bare use of unsigned Derek Robson
2017-01-16  4:40 ` Scott Matheina
2017-01-16  5:06   ` Derek Robson
2017-01-16 10:36     ` Greg KH
2017-01-16  5:05 ` kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).