From: Ingo Molnar <mingo@kernel.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Sreekanth Reddy <Sreekanth.Reddy@broadcom.com>,
Hannes Reinecke <hare@suse.de>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"
Date: Mon, 16 Jan 2017 17:30:40 +0100 [thread overview]
Message-ID: <20170116163040.GB15938@gmail.com> (raw)
In-Reply-To: <1484576642.2540.17.camel@HansenPartnership.com>
* James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> On Mon, 2017-01-16 at 10:22 +0100, Ingo Molnar wrote:
> > * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> >
> > > On Sun, 2017-01-15 at 10:19 +0100, Ingo Molnar wrote:
> > > > So there's a new mpt3sas SCSI driver boot regression, introduced
> > > > in
> > > > this merge window, which made one of my servers unbootable.
> > >
> > > We're not reverting a fix that would cause regressions for others.
> >
> > You really need to reconsider that stance ...
> >
> > > However, The fix was manifestly wrong, so does this fix of the fix
> > > work for you:
> > >
> > > http://marc.info/?l=linux-scsi&m=148329237807604
> > >
> > > It's been languishing a bit because no-one seemed to care enough to
> > > test or review it. IOf you can add a tested by, that will give the
> > > two
> > > we need to push it.
> >
> > I have tested your other patch that you pointed to:
> >
> > http://marc.info/?l=linux-scsi&m=148449968522828
> >
> > Which patch fixes the bug too (I removed my revert first) - so you
> > can add my:
> >
> > Reported-by: Ingo Molnar <mingo@kernel.org>
> > Tested-by: Ingo Molnar <mingo@kernel.org>
>
> Thanks ... just checking you tested the second version with the
> concurrency part?
I tested the one I linked to:
http://marc.info/?l=linux-scsi&m=148449968522828
I don't know which version that is exactly, I just tested what you asked me to
test.
Thanks,
Ingo
prev parent reply other threads:[~2017-01-16 16:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 15:02 [GIT PULL] SCSI fixes for 4.10-rc3 James Bottomley
2017-01-15 9:19 ` [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination" Ingo Molnar
2017-01-15 16:11 ` James Bottomley
2017-01-15 18:54 ` Linus Torvalds
2017-01-15 19:13 ` James Bottomley
2017-01-15 19:41 ` Linus Torvalds
2017-01-15 19:49 ` James Bottomley
2017-01-15 22:02 ` Bart Van Assche
2017-01-16 15:27 ` Christoph Hellwig
2017-01-16 16:14 ` James Bottomley
2017-01-16 18:04 ` Christoph Hellwig
2017-01-16 9:22 ` Ingo Molnar
2017-01-16 14:24 ` James Bottomley
2017-01-16 16:30 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170116163040.GB15938@gmail.com \
--to=mingo@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Sreekanth.Reddy@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=chaitra.basappa@broadcom.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).