From: Linus Torvalds <torvalds@linux-foundation.org>
To: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Sreekanth Reddy <Sreekanth.Reddy@broadcom.com>,
Hannes Reinecke <hare@suse.de>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination"
Date: Sun, 15 Jan 2017 11:41:51 -0800 [thread overview]
Message-ID: <CA+55aFyyBf9SLSNDRqMcFbmUBBkbamZYXGOgfXU8k5KYaFD2mw@mail.gmail.com> (raw)
In-Reply-To: <1484507599.2405.16.camel@HansenPartnership.com>
On Sun, Jan 15, 2017 at 11:13 AM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
>
> Can we compromise on "try not to revert a fix ...".
No.
It's about timing, and about how serious the regression is.
For example, if this happened in rc7, I would have reverted
immediately. No questions asked.
In this case, the "fix" was was also much less important then the
problem it caused. Some specialized pass-through command not working
right, vs a machine not even booting? There's just no question
what-so-ever.
So the "fix" you claim just wasn't nearly important enough. It was
also pretty recent and clearly things had worked for _years_ without
it.
In fact, I'm still somewhat inclined to revert it, just to have a
working rc4 release later today. But I'm hoping maybe Ingo has time to
test things (although I suspect he's already asleep).
Linus
next prev parent reply other threads:[~2017-01-15 19:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 15:02 [GIT PULL] SCSI fixes for 4.10-rc3 James Bottomley
2017-01-15 9:19 ` [PATCH] Revert "scsi: mpt3sas: Fix secure erase premature termination" Ingo Molnar
2017-01-15 16:11 ` James Bottomley
2017-01-15 18:54 ` Linus Torvalds
2017-01-15 19:13 ` James Bottomley
2017-01-15 19:41 ` Linus Torvalds [this message]
2017-01-15 19:49 ` James Bottomley
2017-01-15 22:02 ` Bart Van Assche
2017-01-16 15:27 ` Christoph Hellwig
2017-01-16 16:14 ` James Bottomley
2017-01-16 18:04 ` Christoph Hellwig
2017-01-16 9:22 ` Ingo Molnar
2017-01-16 14:24 ` James Bottomley
2017-01-16 16:30 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+55aFyyBf9SLSNDRqMcFbmUBBkbamZYXGOgfXU8k5KYaFD2mw@mail.gmail.com \
--to=torvalds@linux-foundation.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=Sreekanth.Reddy@broadcom.com \
--cc=akpm@linux-foundation.org \
--cc=chaitra.basappa@broadcom.com \
--cc=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).