* Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU
[not found] ` <20170116180116.36729-3-icenowy@aosc.xyz>
@ 2017-01-17 9:04 ` Maxime Ripard
[not found] ` <5926181484672894@web12g.yandex.ru>
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2017-01-17 9:04 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Jonathan Corbet, Chen-Yu Tsai, Rob Herring, Zepan, linux-doc,
linux-arm-kernel, linux-kernel, devicetree, linux-clk,
linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 1067 bytes --]
Hi,
On Tue, Jan 17, 2017 at 02:01:14AM +0800, Icenowy Zheng wrote:
> V3s has a similar but cut-down CCU to H3.
>
> Add support for it.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
Output from checkpatch:
total: 5 errors, 2 warnings, 3 checks, 857 lines checked
> I think I should make a comparsion between V3s and H3 CCU here:
> (I won't mention the missing/added clocks here, only list conflicting clocks)
That should be in your commit log.
> - "bus-ehci0" is at different bit (The bit that is "bus-ehci0" on V3s is
> "bus-ehci2" on H3)
> - The mux of "ce" is different. (According the view at V3s datasheet by the
> author of sun4i-ss, V3s may have sun4i-ss, not sun8i-ce)
> - The mux of "de" is different. (V3s do not have "pll-de", but it can mux "de"
> to "pll-video")
> - Clocks about CSI largely differs. (As V3s is designed as a camera SoC, and
> it have an extra "pll-isp")
OK.
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/4] arm: sunxi: add support for V3s SoC
[not found] <20170116180116.36729-2-icenowy@aosc.xyz>
[not found] ` <20170116180116.36729-3-icenowy@aosc.xyz>
@ 2017-01-17 9:05 ` Maxime Ripard
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2017-01-17 9:05 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Jonathan Corbet, Chen-Yu Tsai, Rob Herring, Zepan, linux-doc,
linux-arm-kernel, linux-kernel, devicetree, linux-clk,
linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 616 bytes --]
On Tue, Jan 17, 2017 at 02:01:13AM +0800, Icenowy Zheng wrote:
> Allwinner V3s is a low-end single-core Cortex-A7 SoC, with 64MB
> integrated DRAM, and several peripherals.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> ---
> Changes in v2:
> - Used linux-sunxi.org wiki hosted address of V3s datasheet.
>
> Note: the V3s datasheet contains its user manual.
That would be great to use User Manual in the filename rather than
datasheet then. The datasheet is something different.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU
[not found] ` <5926181484672894@web12g.yandex.ru>
@ 2017-01-19 15:39 ` Maxime Ripard
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2017-01-19 15:39 UTC (permalink / raw)
To: Icenowy Zheng
Cc: Jonathan Corbet, Chen-Yu Tsai, Rob Herring, Zepan, linux-doc,
linux-arm-kernel, linux-kernel, devicetree, linux-clk,
linux-sunxi
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
On Wed, Jan 18, 2017 at 01:08:14AM +0800, Icenowy Zheng wrote:
>
>
> 17.01.2017, 17:05, "Maxime Ripard" <maxime.ripard@free-electrons.com>:
> > Hi,
> >
> > On Tue, Jan 17, 2017 at 02:01:14AM +0800, Icenowy Zheng wrote:
> >> V3s has a similar but cut-down CCU to H3.
> >>
> >> Add support for it.
> >>
> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
> >> ---
> >
> > Output from checkpatch:
> > total: 5 errors, 2 warnings, 3 checks, 857 lines checked
>
> I remembered some errors' code is directly derived from ccu-sun8i-h3.c,
> so I generated a patch file for "clk: sunxi-ng: Add H3 clocks" and run
> checkpatch on it:
> total: 4 errors, 5 warnings, 1159 lines checked
>
> Should I still get all errors fixed?
Yes, please.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-19 16:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170116180116.36729-2-icenowy@aosc.xyz>
[not found] ` <20170116180116.36729-3-icenowy@aosc.xyz>
2017-01-17 9:04 ` [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU Maxime Ripard
[not found] ` <5926181484672894@web12g.yandex.ru>
2017-01-19 15:39 ` Maxime Ripard
2017-01-17 9:05 ` [PATCH v2 1/4] arm: sunxi: add support for V3s SoC Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).