From: Johannes Thumshirn <jthumshirn@suse.de>
To: John Garry <john.garry@huawei.com>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linuxarm@huawei.com, zhangfei.gao@linaro.org,
xuwei5@hisilicon.com, john.garry2@mail.dcu.ie,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH 7/7] scsi: hisi_sas: decrease running_req in hisi_sas_slot_task_free()
Date: Thu, 19 Jan 2017 09:57:07 +0100 [thread overview]
Message-ID: <20170119085707.GK5054@linux-x5ow.site> (raw)
In-Reply-To: <1484757173-235951-8-git-send-email-john.garry@huawei.com>
On Thu, Jan 19, 2017 at 12:32:53AM +0800, John Garry wrote:
> From: Xiang Chen <chenxiang66@hisilicon.com>
>
> There is an issue that hisi_sas_dev.running_req is not
> decremented properly for internal abort and TMF.
>
> To resolve, only decrease running_req in hisi_sas_slot_task_free()
>
> Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2017-01-19 8:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 16:32 [PATCH 0/7] hisi_sas: SATA IO workaround and other misc patches John Garry
2017-01-18 16:32 ` [PATCH 1/7] scsi: hisi_sas: workaround v2 hw SATA IO timeout issue John Garry
2017-01-19 8:41 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table John Garry
2017-01-19 8:44 ` Johannes Thumshirn
2017-01-19 8:55 ` John Garry
2017-01-18 16:32 ` [PATCH 3/7] scsi: hisi_sas: downgrade refclk message John Garry
2017-01-19 8:45 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 4/7] scsi: hisi_sas: modify hard reset for directed-attached disk John Garry
2017-01-19 8:46 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 5/7] scsi: hisi_sas: downgrade internal abort exit print John Garry
2017-01-19 8:47 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 6/7] scsi: hisi_sas: fix probe ordering problem John Garry
2017-01-19 8:55 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 7/7] scsi: hisi_sas: decrease running_req in hisi_sas_slot_task_free() John Garry
2017-01-19 8:57 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119085707.GK5054@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry2@mail.dcu.ie \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).