From: John Garry <john.garry@huawei.com>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: <jejb@linux.vnet.ibm.com>, <martin.petersen@oracle.com>,
<linuxarm@huawei.com>, <zhangfei.gao@linaro.org>,
<xuwei5@hisilicon.com>, <john.garry2@mail.dcu.ie>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Xiang Chen <chenxiang66@hisilicon.com>
Subject: Re: [PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table
Date: Thu, 19 Jan 2017 08:55:47 +0000 [thread overview]
Message-ID: <c861893c-d51a-2c0d-0cee-1e92926f8f9a@huawei.com> (raw)
In-Reply-To: <20170119084337.GF5054@linux-x5ow.site>
On 19/01/2017 08:44, Johannes Thumshirn wrote:
> On Thu, Jan 19, 2017 at 12:32:48AM +0800, John Garry wrote:
>> From: Xiang Chen <chenxiang66@hisilicon.com>
>>
>> Set SMP connection timeout and continue AWT timer;
>> Clear ITCT table when dev gone.
>>
>> Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com>
>> Signed-off-by: John Garry <john.garry@huawei.com>
>> ---
>> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>> index 6c787eb..452e329 100644
>> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
>> @@ -334,6 +334,8 @@
>> #define ITCT_HDR_MCR_MSK (0xf << ITCT_HDR_MCR_OFF)
>> #define ITCT_HDR_VLN_OFF 9
>> #define ITCT_HDR_VLN_MSK (0xf << ITCT_HDR_VLN_OFF)
>> +#define ITCT_HDR_SMP_TIMEOUT_OFF 16
>> +#define ITCT_HDR_AWT_CONTINUE_OFF 25
>> #define ITCT_HDR_PORT_ID_OFF 28
>> #define ITCT_HDR_PORT_ID_MSK (0xf << ITCT_HDR_PORT_ID_OFF)
>> /* qw2 */
>> @@ -696,6 +698,8 @@ static void setup_itct_v2_hw(struct hisi_hba *hisi_hba,
>> qw0 |= ((1 << ITCT_HDR_VALID_OFF) |
>> (device->linkrate << ITCT_HDR_MCR_OFF) |
>> (1 << ITCT_HDR_VLN_OFF) |
>> + (0xfa << ITCT_HDR_SMP_TIMEOUT_OFF) |
> ^~ You may want to give that magic value a name.
>
Thanks for having a look.
We will create a new patch without the mysterious value.
Regards,
John
> Other than that,
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
next prev parent reply other threads:[~2017-01-19 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 16:32 [PATCH 0/7] hisi_sas: SATA IO workaround and other misc patches John Garry
2017-01-18 16:32 ` [PATCH 1/7] scsi: hisi_sas: workaround v2 hw SATA IO timeout issue John Garry
2017-01-19 8:41 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 2/7] scsi: hisi_sas: modify some values of ITCT table John Garry
2017-01-19 8:44 ` Johannes Thumshirn
2017-01-19 8:55 ` John Garry [this message]
2017-01-18 16:32 ` [PATCH 3/7] scsi: hisi_sas: downgrade refclk message John Garry
2017-01-19 8:45 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 4/7] scsi: hisi_sas: modify hard reset for directed-attached disk John Garry
2017-01-19 8:46 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 5/7] scsi: hisi_sas: downgrade internal abort exit print John Garry
2017-01-19 8:47 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 6/7] scsi: hisi_sas: fix probe ordering problem John Garry
2017-01-19 8:55 ` Johannes Thumshirn
2017-01-18 16:32 ` [PATCH 7/7] scsi: hisi_sas: decrease running_req in hisi_sas_slot_task_free() John Garry
2017-01-19 8:57 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c861893c-d51a-2c0d-0cee-1e92926f8f9a@huawei.com \
--to=john.garry@huawei.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.garry2@mail.dcu.ie \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=xuwei5@hisilicon.com \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).