From: Juri Lelli <juri.lelli@arm.com>
To: linux-kernel@vger.kernel.org
Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, peterz@infradead.org,
vincent.guittot@linaro.org, robh+dt@kernel.org,
mark.rutland@arm.com, linux@arm.linux.org.uk,
sudeep.holla@arm.com, lorenzo.pieralisi@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com,
morten.rasmussen@arm.com, dietmar.eggemann@arm.com,
juri.lelli@arm.com, broonie@kernel.org,
gregkh@linuxfoundation.org
Subject: [PATCH 3/7] arm: fix return value of parse_cpu_capacity
Date: Thu, 19 Jan 2017 14:37:53 +0000 [thread overview]
Message-ID: <20170119143757.14537-4-juri.lelli@arm.com> (raw)
In-Reply-To: <20170119143757.14537-1-juri.lelli@arm.com>
parse_cpu_capacity() has to return 0 on failure, but it currently returns
1 instead if raw_capacity kcalloc failed.
Fix it by removing the negation of the return value.
Cc: Russell King <linux@arm.linux.org.uk>
Reported-by: Morten Rasmussen <morten.rasmussen@arm.com>
Fixes: 06073ee26775 ('ARM: 8621/3: parse cpu capacity-dmips-mhz from DT')
Signed-off-by: Juri Lelli <juri.lelli@arm.com>
---
arch/arm/kernel/topology.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/kernel/topology.c b/arch/arm/kernel/topology.c
index ebf47d91b804..b439f7fff86b 100644
--- a/arch/arm/kernel/topology.c
+++ b/arch/arm/kernel/topology.c
@@ -165,7 +165,7 @@ static int __init parse_cpu_capacity(struct device_node *cpu_node, int cpu)
if (!raw_capacity) {
pr_err("cpu_capacity: failed to allocate memory for raw capacities\n");
cap_parsing_failed = true;
- return !ret;
+ return ret;
}
}
capacity_scale = max(cpu_capacity, capacity_scale);
--
2.10.0
next prev parent reply other threads:[~2017-01-19 14:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 14:37 [PATCH 0/7] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-01-19 14:37 ` [PATCH 1/7] Documentation: arm: fix wrong reference number in DT definition Juri Lelli
2017-01-21 20:55 ` Rob Herring
2017-01-19 14:37 ` [PATCH 2/7] Documentation/ABI: add information about cpu_capacity Juri Lelli
2017-01-19 14:37 ` Juri Lelli [this message]
2017-01-19 14:37 ` [PATCH 4/7] arm: remove wrong CONFIG_PROC_SYSCTL ifdef Juri Lelli
2017-01-19 14:37 ` [PATCH 5/7] arm64: " Juri Lelli
2017-01-19 14:37 ` [PATCH 6/7] arm, arm64: factorize common cpu capacity default code Juri Lelli
2017-01-19 14:53 ` Russell King - ARM Linux
2017-01-19 15:51 ` Juri Lelli
2017-01-19 16:00 ` Dietmar Eggemann
2017-01-20 10:42 ` Juri Lelli
2017-01-19 14:37 ` [PATCH 7/7] arm,arm64,drivers: reduce scope of cap_parsing_failed Juri Lelli
2017-01-30 12:29 ` [PATCH 0/7] Fix issues and factorize arm/arm64 capacity information code Juri Lelli
2017-01-30 17:51 ` Catalin Marinas
2017-01-30 18:21 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170119143757.14537-4-juri.lelli@arm.com \
--to=juri.lelli@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.rutland@arm.com \
--cc=morten.rasmussen@arm.com \
--cc=peterz@infradead.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).