linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce
@ 2017-01-21 16:11 Rask Ingemann Lambertsen
  2017-01-23  8:04 ` Chen-Yu Tsai
  2017-01-24 18:39 ` Applied "regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce" to the regulator tree Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Rask Ingemann Lambertsen @ 2017-01-21 16:11 UTC (permalink / raw)
  To: Chen-Yu Tsai, Mark Brown, Liam Girdwood
  Cc: linux-arm-kernel, linux-sunxi, linux-kernel

A typo or copy-paste bug means that the register access intended for
regulator dcdce goes to dcdcb instead. This patch corrects it.

Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
Fixes: 2ca342d391e3 (regulator: axp20x: Support AXP806 variant)
---

I have a board where dcdcb powers the DRAM, which I found running at 2.05 V
rather than 1.50 V. The bug was introduced nearly five months ago. Thanks
must go to Samsung for making DRAM chips which tolerate that sort of abuse.

 drivers/regulator/axp20x-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index e6a512e..a3ade9e 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -272,7 +272,7 @@ static const struct regulator_desc axp806_regulators[] = {
 			64, AXP806_DCDCD_V_CTRL, 0x3f, AXP806_PWR_OUT_CTRL1,
 			BIT(3)),
 	AXP_DESC(AXP806, DCDCE, "dcdce", "vine", 1100, 3400, 100,
-		 AXP806_DCDCB_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(4)),
+		 AXP806_DCDCE_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(4)),
 	AXP_DESC(AXP806, ALDO1, "aldo1", "aldoin", 700, 3300, 100,
 		 AXP806_ALDO1_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(5)),
 	AXP_DESC(AXP806, ALDO2, "aldo2", "aldoin", 700, 3400, 100,
-- 
2.10.2

-- 
Rask Ingemann Lambertsen

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce
  2017-01-21 16:11 [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce Rask Ingemann Lambertsen
@ 2017-01-23  8:04 ` Chen-Yu Tsai
  2017-01-24 18:39 ` Applied "regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce" to the regulator tree Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2017-01-23  8:04 UTC (permalink / raw)
  To: Rask Ingemann Lambertsen
  Cc: Chen-Yu Tsai, Mark Brown, Liam Girdwood, linux-arm-kernel,
	linux-sunxi, linux-kernel

On Sun, Jan 22, 2017 at 12:11 AM, Rask Ingemann Lambertsen
<rask@formelder.dk> wrote:
> A typo or copy-paste bug means that the register access intended for
> regulator dcdce goes to dcdcb instead. This patch corrects it.
>
> Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
> Fixes: 2ca342d391e3 (regulator: axp20x: Support AXP806 variant)

Acked-by: Chen-Yu Tsai <wens@csie.org>

Can we tag it for 4.9 stable?

Thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Applied "regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce" to the regulator tree
  2017-01-21 16:11 [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce Rask Ingemann Lambertsen
  2017-01-23  8:04 ` Chen-Yu Tsai
@ 2017-01-24 18:39 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2017-01-24 18:39 UTC (permalink / raw)
  To: Rask Ingemann Lambertsen
  Cc: Chen-Yu Tsai, Mark Brown, stable, Chen-Yu Tsai, Mark Brown,
	Liam Girdwood, linux-arm-kernel, linux-sunxi, linux-kernel,
	linux-kernel

The patch

   regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce

has been applied to the regulator tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From d0e287a401d9acf67b75180b26e2d62b7d482652 Mon Sep 17 00:00:00 2001
From: Rask Ingemann Lambertsen <rask@formelder.dk>
Date: Sat, 21 Jan 2017 17:11:43 +0100
Subject: [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of
 dcdce

A typo or copy-paste bug means that the register access intended for
regulator dcdce goes to dcdcb instead. This patch corrects it.

Fixes: 2ca342d391e3 (regulator: axp20x: Support AXP806 variant)
Signed-off-by: Rask Ingemann Lambertsen <rask@formelder.dk>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
Cc: stable@vger.kernel.org
---
 drivers/regulator/axp20x-regulator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c
index e6a512ebeae2..a3ade9e4ef47 100644
--- a/drivers/regulator/axp20x-regulator.c
+++ b/drivers/regulator/axp20x-regulator.c
@@ -272,7 +272,7 @@ static const struct regulator_desc axp806_regulators[] = {
 			64, AXP806_DCDCD_V_CTRL, 0x3f, AXP806_PWR_OUT_CTRL1,
 			BIT(3)),
 	AXP_DESC(AXP806, DCDCE, "dcdce", "vine", 1100, 3400, 100,
-		 AXP806_DCDCB_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(4)),
+		 AXP806_DCDCE_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(4)),
 	AXP_DESC(AXP806, ALDO1, "aldo1", "aldoin", 700, 3300, 100,
 		 AXP806_ALDO1_V_CTRL, 0x1f, AXP806_PWR_OUT_CTRL1, BIT(5)),
 	AXP_DESC(AXP806, ALDO2, "aldo2", "aldoin", 700, 3400, 100,
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-01-24 18:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-21 16:11 [PATCH] regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce Rask Ingemann Lambertsen
2017-01-23  8:04 ` Chen-Yu Tsai
2017-01-24 18:39 ` Applied "regulator: axp20x: AXP806: Fix dcdcb being set instead of dcdce" to the regulator tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).