linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/5] ARM: tegra: nyan: Use proper IRQ type definitions
@ 2017-01-22 14:44 Paul Kocialkowski
  2017-01-22 14:44 ` [PATCH 2/5] ARM: tegra: nyan: Use external control for bq24735 charger Paul Kocialkowski
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Paul Kocialkowski @ 2017-01-22 14:44 UTC (permalink / raw)
  To: linux-tegra
  Cc: linux-kernel, linux-arm-kernel, devicetree, Jon Hunter,
	Stephen Warren, Thierry Reding, Alexandre Courbot,
	Mikko Perttunen, Peter Rosin, Paul Kocialkowski

This switches a few interrupt definitions that were using
GPIO_ACTIVE_HIGH as IRQ type, which is invalid.

This is mostly a cosmetic change, that doesn't affect any driver.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/tegra124-nyan.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
index eabfa655a3cd..ef430aa30152 100644
--- a/arch/arm/boot/dts/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
@@ -65,7 +65,7 @@
 			compatible = "maxim,max98090";
 			reg = <0x10>;
 			interrupt-parent = <&gpio>;
-			interrupts = <TEGRA_GPIO(H, 4) GPIO_ACTIVE_HIGH>;
+			interrupts = <TEGRA_GPIO(H, 4) IRQ_TYPE_EDGE_FALLING>;
 		};
 
 		temperature-sensor@4c {
@@ -331,7 +331,7 @@
 					reg = <0x9>;
 					interrupt-parent = <&gpio>;
 					interrupts = <TEGRA_GPIO(J, 0)
-							GPIO_ACTIVE_HIGH>;
+							IRQ_TYPE_EDGE_BOTH>;
 					ti,ac-detect-gpios = <&gpio
 							TEGRA_GPIO(J, 0)
 							GPIO_ACTIVE_HIGH>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/5] ARM: tegra: nyan: Use external control for bq24735 charger
  2017-01-22 14:44 [PATCH 1/5] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski
@ 2017-01-22 14:44 ` Paul Kocialkowski
  2017-01-22 14:44 ` [PATCH 3/5] ARM: tegra: nyan-big: Include compatible revisions for proper detection Paul Kocialkowski
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Paul Kocialkowski @ 2017-01-22 14:44 UTC (permalink / raw)
  To: linux-tegra
  Cc: linux-kernel, linux-arm-kernel, devicetree, Jon Hunter,
	Stephen Warren, Thierry Reding, Alexandre Courbot,
	Mikko Perttunen, Peter Rosin, Paul Kocialkowski

Nyan boards come with an embedded controller that controls when to
enable and disable the charge. Thus, it should not be left up to the
kernel to handle that.

Using the ti,external-control property allows specifying this use-case.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/tegra124-nyan.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi b/arch/arm/boot/dts/tegra124-nyan.dtsi
index ef430aa30152..5cf987b5401e 100644
--- a/arch/arm/boot/dts/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
@@ -335,6 +335,7 @@
 					ti,ac-detect-gpios = <&gpio
 							TEGRA_GPIO(J, 0)
 							GPIO_ACTIVE_HIGH>;
+					ti,external-control;
 				};
 
 				battery: sbs-battery@b {
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/5] ARM: tegra: nyan-big: Include compatible revisions for proper detection
  2017-01-22 14:44 [PATCH 1/5] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski
  2017-01-22 14:44 ` [PATCH 2/5] ARM: tegra: nyan: Use external control for bq24735 charger Paul Kocialkowski
@ 2017-01-22 14:44 ` Paul Kocialkowski
  2017-01-22 14:44 ` [PATCH 4/5] ARM: tegra: nyan-big: Proper pinmux for TPM i2c Paul Kocialkowski
  2017-01-22 14:44 ` [PATCH 5/5] ARM: tegra: nyan-blaze: " Paul Kocialkowski
  3 siblings, 0 replies; 5+ messages in thread
From: Paul Kocialkowski @ 2017-01-22 14:44 UTC (permalink / raw)
  To: linux-tegra
  Cc: linux-kernel, linux-arm-kernel, devicetree, Jon Hunter,
	Stephen Warren, Thierry Reding, Alexandre Courbot,
	Mikko Perttunen, Peter Rosin, Paul Kocialkowski

Depthcharge (the payload used with cros devices) will attempt to detect
boards using their revision. This includes all the known revisions for
the nyan-big board so that the dtb can be selected preferably.

Defining compatibly revisions allows depthcharge to select the kernel
via the revision it detects instead of using the default kernel. This
allows having a FIT image with multiple kernels for multiple devices.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/tegra124-nyan-big.dts | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
index 67d7cfb32541..f12ece9b76a6 100644
--- a/arch/arm/boot/dts/tegra124-nyan-big.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
@@ -6,7 +6,12 @@
 
 / {
 	model = "Acer Chromebook 13 CB5-311";
-	compatible = "google,nyan-big", "nvidia,tegra124";
+	compatible = "google,nyan-big-rev7", "google,nyan-big-rev6",
+			"google,nyan-big-rev5", "google,nyan-big-rev4",
+			"google,nyan-big-rev3", "google,nyan-big-rev2",
+			"google,nyan-big-rev5", "google,nyan-big-rev4",
+			"google,nyan-big-rev1", "google,nyan-big-rev0",
+			"google,nyan-big", "google,nyan", "nvidia,tegra124";
 
 	panel: panel {
 		compatible = "auo,b133xtn01";
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 4/5] ARM: tegra: nyan-big: Proper pinmux for TPM i2c
  2017-01-22 14:44 [PATCH 1/5] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski
  2017-01-22 14:44 ` [PATCH 2/5] ARM: tegra: nyan: Use external control for bq24735 charger Paul Kocialkowski
  2017-01-22 14:44 ` [PATCH 3/5] ARM: tegra: nyan-big: Include compatible revisions for proper detection Paul Kocialkowski
@ 2017-01-22 14:44 ` Paul Kocialkowski
  2017-01-22 14:44 ` [PATCH 5/5] ARM: tegra: nyan-blaze: " Paul Kocialkowski
  3 siblings, 0 replies; 5+ messages in thread
From: Paul Kocialkowski @ 2017-01-22 14:44 UTC (permalink / raw)
  To: linux-tegra
  Cc: linux-kernel, linux-arm-kernel, devicetree, Jon Hunter,
	Stephen Warren, Thierry Reding, Alexandre Courbot,
	Mikko Perttunen, Peter Rosin, Paul Kocialkowski

This corrects the pinmux for accessing the TPM over the i2c line.
Thus, it allows correctly probing the module, that previously failed with i2c
errors.

Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
 arch/arm/boot/dts/tegra124-nyan-big.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
index f12ece9b76a6..03eedf86dc48 100644
--- a/arch/arm/boot/dts/tegra124-nyan-big.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
@@ -1103,19 +1103,19 @@
 			};
 			cam_i2c_scl_pbb1 {
 				nvidia,pins = "cam_i2c_scl_pbb1";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			cam_i2c_sda_pbb2 {
 				nvidia,pins = "cam_i2c_sda_pbb2";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			pbb3 {
 				nvidia,pins = "pbb3";
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 5/5] ARM: tegra: nyan-blaze: Proper pinmux for TPM i2c
  2017-01-22 14:44 [PATCH 1/5] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski
                   ` (2 preceding siblings ...)
  2017-01-22 14:44 ` [PATCH 4/5] ARM: tegra: nyan-big: Proper pinmux for TPM i2c Paul Kocialkowski
@ 2017-01-22 14:44 ` Paul Kocialkowski
  3 siblings, 0 replies; 5+ messages in thread
From: Paul Kocialkowski @ 2017-01-22 14:44 UTC (permalink / raw)
  To: linux-tegra
  Cc: linux-kernel, linux-arm-kernel, devicetree, Jon Hunter,
	Stephen Warren, Thierry Reding, Alexandre Courbot,
	Mikko Perttunen, Peter Rosin, Jerome Coste

From: Jerome Coste <jerome.coste@etu.utc.fr>

This corrects the pinmux for accessing the TPM over the i2c line.
Thus, it allows correctly probing the module, that previously failed with i2c
errors.
---
 arch/arm/boot/dts/tegra124-nyan-blaze.dts | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/tegra124-nyan-blaze.dts b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
index c9582361c26e..8bb97e1baf90 100644
--- a/arch/arm/boot/dts/tegra124-nyan-blaze.dts
+++ b/arch/arm/boot/dts/tegra124-nyan-blaze.dts
@@ -1094,19 +1094,19 @@
 			};
 			cam_i2c_scl_pbb1 {
 				nvidia,pins = "cam_i2c_scl_pbb1";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			cam_i2c_sda_pbb2 {
 				nvidia,pins = "cam_i2c_sda_pbb2";
-				nvidia,function = "rsvd3";
-				nvidia,pull = <TEGRA_PIN_PULL_DOWN>;
-				nvidia,tristate = <TEGRA_PIN_ENABLE>;
-				nvidia,enable-input = <TEGRA_PIN_DISABLE>;
-				nvidia,open-drain = <TEGRA_PIN_DISABLE>;
+				nvidia,function = "i2c3";
+				nvidia,pull = <TEGRA_PIN_PULL_NONE>;
+				nvidia,tristate = <TEGRA_PIN_DISABLE>;
+				nvidia,enable-input = <TEGRA_PIN_ENABLE>;
+				nvidia,open-drain = <TEGRA_PIN_ENABLE>;
 			};
 			pbb3 {
 				nvidia,pins = "pbb3";
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-01-22 14:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-22 14:44 [PATCH 1/5] ARM: tegra: nyan: Use proper IRQ type definitions Paul Kocialkowski
2017-01-22 14:44 ` [PATCH 2/5] ARM: tegra: nyan: Use external control for bq24735 charger Paul Kocialkowski
2017-01-22 14:44 ` [PATCH 3/5] ARM: tegra: nyan-big: Include compatible revisions for proper detection Paul Kocialkowski
2017-01-22 14:44 ` [PATCH 4/5] ARM: tegra: nyan-big: Proper pinmux for TPM i2c Paul Kocialkowski
2017-01-22 14:44 ` [PATCH 5/5] ARM: tegra: nyan-blaze: " Paul Kocialkowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).