linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: ming.lei@canonical.com, wagi@monom.org, dwmw2@infradead.org,
	linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.com>,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] firmware/Makefile: force recompilation if makefile changes
Date: Mon, 23 Jan 2017 15:59:52 +0100	[thread overview]
Message-ID: <20170123145952.GM13946@wotan.suse.de> (raw)
In-Reply-To: <20170119101507.GA18592@kroah.com>

On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote:
> On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote:
> > If you modify the target asm we currently do not force the
> > recompilation of the firmware files. The target asm is in
> > the firmware/Makefile, peg this file as a dependency to
> > require re-compilation of firmware targets when the asm
> > changes.
> 
> Why would changing the Makefile require the asm to change?

The Makefile is the file that provides the assembly logic, so
changing the asm should affect recreating the binary.

> Anyway, this should go through the kbuild tree, not mine, they know
> Makefiles much better than I do...

Will send it there. Thanks.

  Luis

  reply	other threads:[~2017-01-23 14:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 17:31 [PATCH] firmware/Makefile: force recompilation if makefile changes Luis R. Rodriguez
2017-01-19 10:15 ` Greg KH
2017-01-23 14:59   ` Luis R. Rodriguez [this message]
2017-01-23 15:02     ` Greg KH
2017-01-23 15:04       ` Luis R. Rodriguez
2017-01-23 15:07 ` [PATCH v2] " Luis R. Rodriguez
2017-02-06 22:03   ` Luis R. Rodriguez
2017-02-14 19:34     ` Luis R. Rodriguez
2017-02-21 19:38       ` Luis R. Rodriguez
2017-03-11  5:37   ` Masahiro Yamada
2017-03-15  0:53     ` Luis R. Rodriguez
2017-03-16 17:43       ` Masahiro Yamada
2017-03-16 17:55         ` Luis R. Rodriguez
2017-03-18 13:32           ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170123145952.GM13946@wotan.suse.de \
    --to=mcgrof@kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=mmarek@suse.com \
    --cc=wagi@monom.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).