From: Borislav Petkov <bp@alien8.de>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: arnd@arndb.de, mmarek@suse.com, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
airlied@linux.ie, davem@davemloft.net, linux@armlinux.org.uk,
slash.tmp@free.fr, daniel.vetter@ffwll.ch,
rmk+kernel@armlinux.org.uk, msalter@redhat.com, jengelh@inai.de,
hch@infradead.org, tklauser@distanz.ch, mpe@ellerman.id.au,
mingo@kernel.org, hpa@zytor.com
Subject: Re: [PATCH v4 3/7] x86: put msr-index.h in uapi
Date: Mon, 23 Jan 2017 18:17:32 +0100 [thread overview]
Message-ID: <20170123171732.i3qfbcsqzznppe5m@pd.tnic> (raw)
In-Reply-To: <d105332c-d8dd-938a-aaa5-ceb42fca4507@6wind.com>
On Mon, Jan 23, 2017 at 06:06:52PM +0100, Nicolas Dichtel wrote:
> After digging a bit, it seems you have already tried to remove it in commit
> b72e7464e4cf ("x86/uapi: Do not export <asm/msr-index.h> as part of the user API
> headers"), but because this file is still listed in the Kbuild file, it is still
> exported.
Oh great. :-\
> It would be great if we could find a consensus about what to do with
> this file because it blocks patch #4 and the rest of the series.
The reasoning in b72e7464e4cf was valid then and is valid now. This
thing should not have been exported in the first place. And it's not
like I didn't try then. Dammit!
I know, we should not ever break userspace but if it were me, I'd remove
that export and see what breaks. If at all.
But let's see what the others think first.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2017-01-23 17:17 UTC|newest]
Thread overview: 194+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161203.192346.1198940437155108508.davem@davemloft.net>
2017-01-03 14:35 ` [PATCH] uapi: use wildcards to list files Nicolas Dichtel
2017-01-03 15:56 ` David Miller
2017-01-03 21:37 ` Arnd Bergmann
2017-01-04 9:03 ` Nicolas Dichtel
2017-01-06 9:43 ` [PATCH v2 0/7] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-06 9:43 ` [PATCH v2 1/7] arm: put types.h in uapi Nicolas Dichtel
2017-01-09 11:33 ` Arnd Bergmann
2017-01-09 12:00 ` Russell King - ARM Linux
2017-01-06 9:43 ` [PATCH v2 2/7] h8300: put bitsperlong.h " Nicolas Dichtel
2017-01-06 9:43 ` [PATCH v2 3/7] nios2: put setup.h " Nicolas Dichtel
2017-01-09 11:33 ` Arnd Bergmann
2017-01-06 9:43 ` [PATCH v2 4/7] x86: put msr-index.h " Nicolas Dichtel
2017-01-06 12:14 ` Borislav Petkov
2017-01-06 20:50 ` Andy Shevchenko
2017-01-06 9:43 ` [PATCH v2 5/7] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-01-06 9:43 ` [PATCH v2 6/7] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-01-06 9:43 ` [PATCH v2 7/7] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-09 10:01 ` Daniel Vetter
2017-01-09 12:01 ` Russell King - ARM Linux
2017-01-09 12:56 ` Christoph Hellwig
2017-01-12 15:52 ` Nicolas Dichtel
2017-01-12 16:28 ` Jan Engelhardt
2017-01-12 16:32 ` Nicolas Dichtel
2017-01-13 1:04 ` Jeff Epler
2017-01-11 18:14 ` [Linux-c6x-dev] " Mark Salter
2017-01-09 11:33 ` [PATCH v2 0/7] " Arnd Bergmann
2017-01-11 12:42 ` Jesper Nilsson
2017-01-13 10:46 ` [PATCH v3 0/8] " Nicolas Dichtel
2017-01-13 10:46 ` [PATCH v3 1/8] arm: put types.h in uapi Nicolas Dichtel
2017-01-13 17:06 ` Russell King - ARM Linux
2017-01-13 10:46 ` [PATCH v3 2/8] h8300: put bitsperlong.h " Nicolas Dichtel
2017-01-13 10:46 ` [PATCH v3 3/8] nios2: put setup.h " Nicolas Dichtel
2017-01-13 10:55 ` Tobias Klauser
2017-01-13 10:46 ` [PATCH v3 4/8] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-01-13 10:46 ` [PATCH v3 5/8] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-01-13 10:46 ` [PATCH v3 6/8] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-01-13 10:46 ` [PATCH v3 7/8] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-23 9:00 ` Michael Ellerman
2017-01-13 10:46 ` [PATCH v3 8/8] uapi: export all arch specifics directories Nicolas Dichtel
2017-01-13 15:36 ` David Howells
2017-01-13 16:01 ` [PATCH v3 1/8] arm: put types.h in uapi Nicolas Dichtel
2017-01-13 16:19 ` Russell King - ARM Linux
2017-01-13 16:35 ` David Howells
2017-01-13 15:43 ` David Howells
2017-01-13 16:08 ` [PATCH v3 4/8] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-01-13 16:38 ` Borislav Petkov
2017-01-23 14:58 ` [PATCH v4 0/7] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-23 14:58 ` [PATCH v4 1/7] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-01-23 14:58 ` [PATCH v4 2/7] nios2: put setup.h " Nicolas Dichtel
2017-01-23 14:58 ` [PATCH v4 3/7] x86: put msr-index.h " Nicolas Dichtel
2017-01-23 16:52 ` Borislav Petkov
2017-01-23 17:06 ` Nicolas Dichtel
2017-01-23 17:17 ` Borislav Petkov [this message]
2017-01-23 17:21 ` Christoph Hellwig
2017-01-23 17:26 ` Borislav Petkov
2017-01-23 22:24 ` Jan Engelhardt
2017-01-23 22:51 ` Borislav Petkov
2017-01-26 16:02 ` Nicolas Dichtel
2017-01-30 14:51 ` Russell King - ARM Linux
2017-01-30 15:30 ` Borislav Petkov
2017-01-31 10:58 ` Nicolas Dichtel
2017-01-31 16:21 ` Ingo Molnar
2017-02-02 13:25 ` [PATCH v5 0/8] uapi: export all headers under uapi directories Nicolas Dichtel
2017-02-02 13:25 ` [PATCH v5 1/8] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-02-02 13:25 ` [PATCH v5 2/8] nios2: put setup.h " Nicolas Dichtel
2017-02-02 13:25 ` [PATCH v5 3/8] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-02-02 13:38 ` Ingo Molnar
2017-02-02 13:25 ` [PATCH v5 4/8] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-02-02 13:25 ` [PATCH v5 5/8] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-02-03 21:45 ` Paul Bolle
2017-02-02 13:25 ` [PATCH v5 6/8] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-02-02 15:15 ` kbuild test robot
2017-02-02 15:27 ` kbuild test robot
2017-02-02 13:25 ` [PATCH v5 7/8] uapi: export all headers under uapi directories Nicolas Dichtel
2017-02-02 14:47 ` kbuild test robot
2017-02-02 15:42 ` Nicolas Dichtel
2017-02-10 10:58 ` [PATCH v6 0/8] " Nicolas Dichtel
2017-02-10 10:58 ` [PATCH v6 1/8] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-02-10 10:58 ` [PATCH v6 2/8] nios2: put setup.h " Nicolas Dichtel
2017-02-10 10:58 ` [PATCH v6 3/8] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-02-10 11:15 ` Thomas Gleixner
2017-02-10 10:58 ` [PATCH v6 4/8] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-02-10 10:58 ` [PATCH v6 5/8] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-02-10 10:58 ` [PATCH v6 6/8] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-02-10 10:58 ` [PATCH v6 7/8] uapi: export all headers under uapi directories Nicolas Dichtel
2017-02-13 7:49 ` Christoph Hellwig
2017-02-20 9:32 ` Nicolas Dichtel
2017-02-20 10:14 ` Arnd Bergmann
2017-02-20 12:58 ` Nicolas Dichtel
2017-02-24 16:49 ` [PATCH v7 0/8] " Nicolas Dichtel
2017-02-24 16:49 ` [PATCH v7 1/8] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-02-24 16:49 ` [PATCH v7 2/8] nios2: put setup.h " Nicolas Dichtel
2017-02-24 16:49 ` [PATCH v7 3/8] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-02-24 16:49 ` [PATCH v7 4/8] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-02-24 16:49 ` [PATCH v7 5/8] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-02-24 16:49 ` [PATCH v7 6/8] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-02-24 16:49 ` [PATCH v7 7/8] uapi: export all headers under uapi directories Nicolas Dichtel
2017-02-27 16:01 ` Nicolas Dichtel
2017-02-28 2:48 ` Dmitry V. Levin
2017-02-28 15:47 ` Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 00/11] " Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 01/11] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 02/11] nios2: put setup.h " Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 03/11] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 04/11] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 05/11] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 06/11] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 07/11] btrfs_tree.h: fix include from userland Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 08/11] cryptouser.h: " Nicolas Dichtel
2017-03-01 4:52 ` Herbert Xu
2017-03-02 16:56 ` [PATCH v9 00/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 01/11] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 02/11] nios2: put setup.h " Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 03/11] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 04/11] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 05/11] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 06/11] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 07/11] btrfs_tree.h: fix include from userland Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 08/11] cryptouser.h: " Nicolas Dichtel
2017-03-03 9:35 ` Herbert Xu
2017-03-02 16:56 ` [PATCH v9 09/11] smc_diag.h: " Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 10/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-02 16:56 ` [PATCH v9 11/11] uapi: export all arch specifics directories Nicolas Dichtel
2017-03-03 17:07 ` [PATCH v9 00/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-10 16:34 ` Nicolas Dichtel
2017-03-11 5:43 ` Masahiro Yamada
2017-03-13 16:57 ` Nicolas Dichtel
2017-03-14 5:38 ` Masahiro Yamada
2017-03-14 8:25 ` Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 " Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 01/11] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-03-27 5:31 ` Masahiro Yamada
2017-03-27 9:43 ` Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 02/11] nios2: put setup.h " Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 03/11] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 04/11] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 05/11] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 06/11] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 07/11] btrfs_tree.h: fix include from userland Nicolas Dichtel
2017-03-27 5:53 ` Masahiro Yamada
2017-03-27 9:45 ` Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 08/11] cryptouser.h: " Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 09/11] smc_diag.h: " Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 10/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-14 12:54 ` [PATCH v10 11/11] uapi: export all arch specifics directories Nicolas Dichtel
2017-03-27 5:27 ` Masahiro Yamada
2017-03-27 9:42 ` Nicolas Dichtel
2017-03-24 8:32 ` [PATCH v10 00/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-03-24 8:42 ` Masahiro Yamada
2017-03-24 9:03 ` Nicolas Dichtel
2017-03-27 5:26 ` Masahiro Yamada
2017-03-27 9:45 ` Nicolas Dichtel
2017-03-27 15:33 ` Masahiro Yamada
2017-03-27 12:20 ` [PATCH v11 00/12] " Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 01/12] h8300: put bitsperlong.h in uapi Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 02/12] nios2: put setup.h " Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 03/12] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 04/12] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 05/12] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 06/12] uapi: includes linux/types.h before exporting files Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 07/12] btrfs_tree.h: fix include from userland Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 08/12] cryptouser.h: " Nicolas Dichtel
2017-04-11 2:40 ` Herbert Xu
2017-03-27 12:20 ` [PATCH v11 09/12] smc_diag.h: " Nicolas Dichtel
2017-03-27 12:20 ` [PATCH v11 10/12] uapi: export all headers under uapi directories Nicolas Dichtel
2017-05-07 23:17 ` Masahiro Yamada
2017-05-09 10:09 ` Nicolas Dichtel
2017-05-09 17:22 ` Masahiro Yamada
2017-03-27 12:20 ` [PATCH v11 11/12] uapi: export all arch specifics directories Nicolas Dichtel
2017-05-16 1:02 ` Dan Williams
2017-05-16 1:15 ` Dan Williams
2017-05-16 4:59 ` Masahiro Yamada
2017-03-27 12:20 ` [PATCH v11 12/12] arch/include: remove empty Kbuild files Nicolas Dichtel
2017-03-27 15:35 ` [PATCH v11 00/12] uapi: export all headers under uapi directories Masahiro Yamada
2017-02-28 20:47 ` [PATCH v8 09/11] smc_diag.h: fix include from userland Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 10/11] uapi: export all headers under uapi directories Nicolas Dichtel
2017-02-28 20:47 ` [PATCH v8 11/11] uapi: export all arch specifics directories Nicolas Dichtel
2017-02-24 16:49 ` [PATCH v7 8/8] " Nicolas Dichtel
2017-02-10 10:58 ` [PATCH v6 " Nicolas Dichtel
2017-02-02 13:25 ` [PATCH v5 " Nicolas Dichtel
2017-02-02 14:36 ` kbuild test robot
2017-02-02 14:46 ` kbuild test robot
2017-01-23 17:49 ` [PATCH v4 3/7] x86: put msr-index.h in uapi kbuild test robot
2017-01-23 19:11 ` kbuild test robot
2017-01-26 19:04 ` Ingo Molnar
2017-01-26 19:29 ` Borislav Petkov
2017-01-23 14:58 ` [PATCH v4 4/7] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-01-23 14:58 ` [PATCH v4 5/7] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-01-23 14:58 ` [PATCH v4 6/7] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-23 15:25 ` Christoph Hellwig
2017-01-23 16:03 ` Nicolas Dichtel
2017-01-23 18:47 ` kbuild test robot
2017-01-23 18:52 ` kbuild test robot
2017-01-23 14:58 ` [PATCH v4 7/7] uapi: export all arch specifics directories Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123171732.i3qfbcsqzznppe5m@pd.tnic \
--to=bp@alien8.de \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=jengelh@inai.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mingo@kernel.org \
--cc=mmarek@suse.com \
--cc=mpe@ellerman.id.au \
--cc=msalter@redhat.com \
--cc=nicolas.dichtel@6wind.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=slash.tmp@free.fr \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).