linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm/i915/gvt: Fix kmem_cache_create() name
@ 2017-01-24 20:15 Alex Williamson
  2017-01-25  2:25 ` [igvt-g-dev] " Zhenyu Wang
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Williamson @ 2017-01-24 20:15 UTC (permalink / raw)
  To: zhi.a.wang, zhenyuw
  Cc: jani.nikula, jike.song, airlied, intel-gfx, linux-kernel,
	dri-devel, igvt-g-dev, daniel.vetter

According to kmem_cache_sanity_check(), spaces are not allowed in the
name of a cache and results in a kernel oops with CONFIG_DEBUG_VM.
Convert to underscores.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 drivers/gpu/drm/i915/gvt/execlist.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c
index f32bb6f..d03b229 100644
--- a/drivers/gpu/drm/i915/gvt/execlist.c
+++ b/drivers/gpu/drm/i915/gvt/execlist.c
@@ -826,7 +826,7 @@ int intel_vgpu_init_execlist(struct intel_vgpu *vgpu)
 		INIT_LIST_HEAD(&vgpu->workload_q_head[i]);
 	}
 
-	vgpu->workloads = kmem_cache_create("gvt-g vgpu workload",
+	vgpu->workloads = kmem_cache_create("gvt-g_vgpu_workload",
 			sizeof(struct intel_vgpu_workload), 0,
 			SLAB_HWCACHE_ALIGN,
 			NULL);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [igvt-g-dev] [PATCH] drm/i915/gvt: Fix kmem_cache_create() name
  2017-01-24 20:15 [PATCH] drm/i915/gvt: Fix kmem_cache_create() name Alex Williamson
@ 2017-01-25  2:25 ` Zhenyu Wang
  0 siblings, 0 replies; 2+ messages in thread
From: Zhenyu Wang @ 2017-01-25  2:25 UTC (permalink / raw)
  To: Alex Williamson
  Cc: zhi.a.wang, zhenyuw, airlied, intel-gfx, igvt-g-dev,
	linux-kernel, dri-devel, jani.nikula, daniel.vetter

[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]

On 2017.01.24 13:15:43 -0700, Alex Williamson wrote:
> According to kmem_cache_sanity_check(), spaces are not allowed in the
> name of a cache and results in a kernel oops with CONFIG_DEBUG_VM.
> Convert to underscores.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---

Will send to 4.10 fixes. Thanks!

>  drivers/gpu/drm/i915/gvt/execlist.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c
> index f32bb6f..d03b229 100644
> --- a/drivers/gpu/drm/i915/gvt/execlist.c
> +++ b/drivers/gpu/drm/i915/gvt/execlist.c
> @@ -826,7 +826,7 @@ int intel_vgpu_init_execlist(struct intel_vgpu *vgpu)
>  		INIT_LIST_HEAD(&vgpu->workload_q_head[i]);
>  	}
>  
> -	vgpu->workloads = kmem_cache_create("gvt-g vgpu workload",
> +	vgpu->workloads = kmem_cache_create("gvt-g_vgpu_workload",
>  			sizeof(struct intel_vgpu_workload), 0,
>  			SLAB_HWCACHE_ALIGN,
>  			NULL);
> 
> _______________________________________________
> igvt-g-dev mailing list
> igvt-g-dev@lists.01.org
> https://lists.01.org/mailman/listinfo/igvt-g-dev

-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-25  2:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 20:15 [PATCH] drm/i915/gvt: Fix kmem_cache_create() name Alex Williamson
2017-01-25  2:25 ` [igvt-g-dev] " Zhenyu Wang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).