* [PATCH] xen,input: try to read screen resolution for xen-kbdfront
@ 2017-01-24 12:09 Juergen Gross
2017-01-24 18:47 ` Dmitry Torokhov
2017-01-24 21:16 ` kbuild test robot
0 siblings, 2 replies; 4+ messages in thread
From: Juergen Gross @ 2017-01-24 12:09 UTC (permalink / raw)
To: linux-kernel, linux-input, xen-devel
Cc: dmitry.torokhov, Juergen Gross, stable
Instead of using the default resolution of 800*600 for the pointing
device of xen-kbdfront try to read the resolution of the (virtual)
framebuffer device. Use the default as fallback only.
Cc: stable@vger.kernel.org
Signed-off-by: Juergen Gross <jgross@suse.com>
---
drivers/input/misc/xen-kbdfront.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index 3900875..0032c81 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -16,6 +16,7 @@
#include <linux/kernel.h>
#include <linux/errno.h>
#include <linux/module.h>
+#include <linux/fb.h>
#include <linux/input.h>
#include <linux/slab.h>
@@ -108,10 +109,11 @@ static irqreturn_t input_handler(int rq, void *dev_id)
static int xenkbd_probe(struct xenbus_device *dev,
const struct xenbus_device_id *id)
{
- int ret, i;
+ int ret, i, width, height;
unsigned int abs;
struct xenkbd_info *info;
struct input_dev *kbd, *ptr;
+ struct fb_info *fb0;
info = kzalloc(sizeof(*info), GFP_KERNEL);
if (!info) {
@@ -173,9 +175,16 @@ static int xenkbd_probe(struct xenbus_device *dev,
ptr->id.product = 0xfffe;
if (abs) {
+ width = XENFB_WIDTH;
+ height = XENFB_HEIGHT;
+ fb0 = registered_fb[0];
+ if (fb0) {
+ width = fb0->var.xres_virtual;
+ height = fb0->var.yres_virtual;
+ }
__set_bit(EV_ABS, ptr->evbit);
- input_set_abs_params(ptr, ABS_X, 0, XENFB_WIDTH, 0, 0);
- input_set_abs_params(ptr, ABS_Y, 0, XENFB_HEIGHT, 0, 0);
+ input_set_abs_params(ptr, ABS_X, 0, width, 0, 0);
+ input_set_abs_params(ptr, ABS_Y, 0, height, 0, 0);
} else {
input_set_capability(ptr, EV_REL, REL_X);
input_set_capability(ptr, EV_REL, REL_Y);
--
2.10.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xen,input: try to read screen resolution for xen-kbdfront
2017-01-24 12:09 [PATCH] xen,input: try to read screen resolution for xen-kbdfront Juergen Gross
@ 2017-01-24 18:47 ` Dmitry Torokhov
2017-01-27 6:06 ` Juergen Gross
2017-01-24 21:16 ` kbuild test robot
1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2017-01-24 18:47 UTC (permalink / raw)
To: Juergen Gross; +Cc: linux-kernel, linux-input, xen-devel, stable
On Tue, Jan 24, 2017 at 01:09:55PM +0100, Juergen Gross wrote:
> Instead of using the default resolution of 800*600 for the pointing
> device of xen-kbdfront try to read the resolution of the (virtual)
> framebuffer device. Use the default as fallback only.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> drivers/input/misc/xen-kbdfront.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
> index 3900875..0032c81 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -16,6 +16,7 @@
> #include <linux/kernel.h>
> #include <linux/errno.h>
> #include <linux/module.h>
> +#include <linux/fb.h>
> #include <linux/input.h>
> #include <linux/slab.h>
>
> @@ -108,10 +109,11 @@ static irqreturn_t input_handler(int rq, void *dev_id)
> static int xenkbd_probe(struct xenbus_device *dev,
> const struct xenbus_device_id *id)
> {
> - int ret, i;
> + int ret, i, width, height;
> unsigned int abs;
> struct xenkbd_info *info;
> struct input_dev *kbd, *ptr;
> + struct fb_info *fb0;
>
> info = kzalloc(sizeof(*info), GFP_KERNEL);
> if (!info) {
> @@ -173,9 +175,16 @@ static int xenkbd_probe(struct xenbus_device *dev,
> ptr->id.product = 0xfffe;
>
> if (abs) {
> + width = XENFB_WIDTH;
> + height = XENFB_HEIGHT;
> + fb0 = registered_fb[0];
This will break if !CONFIG_FBi I think. While i see that xen.config has
it on I wonder if it is still possible to turn it off (either randconfig
or intentionally).
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen,input: try to read screen resolution for xen-kbdfront
2017-01-24 12:09 [PATCH] xen,input: try to read screen resolution for xen-kbdfront Juergen Gross
2017-01-24 18:47 ` Dmitry Torokhov
@ 2017-01-24 21:16 ` kbuild test robot
1 sibling, 0 replies; 4+ messages in thread
From: kbuild test robot @ 2017-01-24 21:16 UTC (permalink / raw)
To: Juergen Gross
Cc: kbuild-all, linux-kernel, linux-input, xen-devel,
dmitry.torokhov, Juergen Gross, stable
[-- Attachment #1: Type: text/plain, Size: 932 bytes --]
Hi Juergen,
[auto build test ERROR on xen-tip/linux-next]
[also build test ERROR on v4.10-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Juergen-Gross/xen-input-try-to-read-screen-resolution-for-xen-kbdfront/20170125-010022
base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next
config: x86_64-randconfig-h0-01250255 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/built-in.o: In function `xenkbd_probe':
>> xen-kbdfront.c:(.text+0x3dc506): undefined reference to `registered_fb'
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24684 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xen,input: try to read screen resolution for xen-kbdfront
2017-01-24 18:47 ` Dmitry Torokhov
@ 2017-01-27 6:06 ` Juergen Gross
0 siblings, 0 replies; 4+ messages in thread
From: Juergen Gross @ 2017-01-27 6:06 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-kernel, linux-input, xen-devel, stable
On 24/01/17 19:47, Dmitry Torokhov wrote:
> On Tue, Jan 24, 2017 at 01:09:55PM +0100, Juergen Gross wrote:
>> Instead of using the default resolution of 800*600 for the pointing
>> device of xen-kbdfront try to read the resolution of the (virtual)
>> framebuffer device. Use the default as fallback only.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> drivers/input/misc/xen-kbdfront.c | 15 ++++++++++++---
>> 1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
>> index 3900875..0032c81 100644
>> --- a/drivers/input/misc/xen-kbdfront.c
>> +++ b/drivers/input/misc/xen-kbdfront.c
>> @@ -16,6 +16,7 @@
>> #include <linux/kernel.h>
>> #include <linux/errno.h>
>> #include <linux/module.h>
>> +#include <linux/fb.h>
>> #include <linux/input.h>
>> #include <linux/slab.h>
>>
>> @@ -108,10 +109,11 @@ static irqreturn_t input_handler(int rq, void *dev_id)
>> static int xenkbd_probe(struct xenbus_device *dev,
>> const struct xenbus_device_id *id)
>> {
>> - int ret, i;
>> + int ret, i, width, height;
>> unsigned int abs;
>> struct xenkbd_info *info;
>> struct input_dev *kbd, *ptr;
>> + struct fb_info *fb0;
>>
>> info = kzalloc(sizeof(*info), GFP_KERNEL);
>> if (!info) {
>> @@ -173,9 +175,16 @@ static int xenkbd_probe(struct xenbus_device *dev,
>> ptr->id.product = 0xfffe;
>>
>> if (abs) {
>> + width = XENFB_WIDTH;
>> + height = XENFB_HEIGHT;
>> + fb0 = registered_fb[0];
>
> This will break if !CONFIG_FBi I think. While i see that xen.config has
> it on I wonder if it is still possible to turn it off (either randconfig
> or intentionally).
kbuild robot says it is. :-(
Sending V2.
Thanks,
Juergen
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-27 6:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 12:09 [PATCH] xen,input: try to read screen resolution for xen-kbdfront Juergen Gross
2017-01-24 18:47 ` Dmitry Torokhov
2017-01-27 6:06 ` Juergen Gross
2017-01-24 21:16 ` kbuild test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).