* [PATCH] livepatch: add missing printk newlines
@ 2017-01-24 20:32 Josh Poimboeuf
2017-01-25 8:06 ` Miroslav Benes
2017-01-25 22:43 ` Jessica Yu
0 siblings, 2 replies; 3+ messages in thread
From: Josh Poimboeuf @ 2017-01-24 20:32 UTC (permalink / raw)
To: live-patching; +Cc: linux-kernel
Add missing newlines to some pr_err() strings.
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
---
kernel/livepatch/core.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index af46438..05e4f91 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -233,7 +233,7 @@ static int klp_resolve_symbols(Elf_Shdr *relasec, struct module *pmod)
for (i = 0; i < relasec->sh_size / sizeof(Elf_Rela); i++) {
sym = pmod->core_kallsyms.symtab + ELF_R_SYM(relas[i].r_info);
if (sym->st_shndx != SHN_LIVEPATCH) {
- pr_err("symbol %s is not marked as a livepatch symbol",
+ pr_err("symbol %s is not marked as a livepatch symbol\n",
strtab + sym->st_name);
return -EINVAL;
}
@@ -243,7 +243,7 @@ static int klp_resolve_symbols(Elf_Shdr *relasec, struct module *pmod)
".klp.sym.%55[^.].%127[^,],%lu",
objname, symname, &sympos);
if (cnt != 3) {
- pr_err("symbol %s has an incorrectly formatted name",
+ pr_err("symbol %s has an incorrectly formatted name\n",
strtab + sym->st_name);
return -EINVAL;
}
@@ -288,7 +288,7 @@ static int klp_write_object_relocations(struct module *pmod,
*/
cnt = sscanf(secname, ".klp.rela.%55[^.]", sec_objname);
if (cnt != 1) {
- pr_err("section %s has an incorrectly formatted name",
+ pr_err("section %s has an incorrectly formatted name\n",
secname);
ret = -EINVAL;
break;
@@ -918,7 +918,7 @@ int klp_register_patch(struct klp_patch *patch)
return -EINVAL;
if (!is_livepatch_module(patch->mod)) {
- pr_err("module %s is not marked as a livepatch module",
+ pr_err("module %s is not marked as a livepatch module\n",
patch->mod->name);
return -EINVAL;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] livepatch: add missing printk newlines
2017-01-24 20:32 [PATCH] livepatch: add missing printk newlines Josh Poimboeuf
@ 2017-01-25 8:06 ` Miroslav Benes
2017-01-25 22:43 ` Jessica Yu
1 sibling, 0 replies; 3+ messages in thread
From: Miroslav Benes @ 2017-01-25 8:06 UTC (permalink / raw)
To: Josh Poimboeuf; +Cc: live-patching, linux-kernel
On Tue, 24 Jan 2017, Josh Poimboeuf wrote:
> Add missing newlines to some pr_err() strings.
>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Miroslav
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: livepatch: add missing printk newlines
2017-01-24 20:32 [PATCH] livepatch: add missing printk newlines Josh Poimboeuf
2017-01-25 8:06 ` Miroslav Benes
@ 2017-01-25 22:43 ` Jessica Yu
1 sibling, 0 replies; 3+ messages in thread
From: Jessica Yu @ 2017-01-25 22:43 UTC (permalink / raw)
To: Josh Poimboeuf; +Cc: live-patching, linux-kernel
+++ Josh Poimboeuf [24/01/17 14:32 -0600]:
>Add missing newlines to some pr_err() strings.
>
>Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Jessica Yu <jeyu@redhat.com>
Jessica
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-25 22:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-24 20:32 [PATCH] livepatch: add missing printk newlines Josh Poimboeuf
2017-01-25 8:06 ` Miroslav Benes
2017-01-25 22:43 ` Jessica Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).