From: Michal Hocko <mhocko@kernel.org>
To: ysxie@foxmail.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
n-horiguchi@ah.jp.nec.com, akpm@linux-foundation.org,
minchan@kernel.org, vbabka@suse.cz, guohanjun@huawei.com,
qiuxishi@huawei.com
Subject: Re: [PATCH v4 2/2] HWPOISON: soft offlining for non-lru movable page
Date: Thu, 26 Jan 2017 10:27:25 +0100 [thread overview]
Message-ID: <20170126092725.GD6590@dhcp22.suse.cz> (raw)
In-Reply-To: <1485356738-4831-3-git-send-email-ysxie@foxmail.com>
On Wed 25-01-17 23:05:38, ysxie@foxmail.com wrote:
> From: Yisheng Xie <xieyisheng1@huawei.com>
>
> This patch is to extends soft offlining framework to support
> non-lru page, which already support migration after
> commit bda807d44454 ("mm: migrate: support non-lru movable page
> migration")
>
> When memory corrected errors occur on a non-lru movable page,
> we can choose to stop using it by migrating data onto another
> page and disable the original (maybe half-broken) one.
>
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
> Suggested-by: Michal Hocko <mhocko@kernel.org>
> Suggested-by: Minchan Kim <minchan@kernel.org>
> Reviewed-by: Minchan Kim <minchan@kernel.org>
> Acked-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> CC: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/memory-failure.c | 26 ++++++++++++++++----------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index f283c7e..56e39f8 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1527,7 +1527,8 @@ static int get_any_page(struct page *page, unsigned long pfn, int flags)
> {
> int ret = __get_any_page(page, pfn, flags);
>
> - if (ret == 1 && !PageHuge(page) && !PageLRU(page)) {
> + if (ret == 1 && !PageHuge(page) &&
> + !PageLRU(page) && !__PageMovable(page)) {
> /*
> * Try to free it.
> */
Is this sufficient? Not that I am familiar with get_any_page() but
__get_any_page doesn't seem to be aware of movable pages and neither
shake_page is.
> @@ -1649,7 +1650,10 @@ static int __soft_offline_page(struct page *page, int flags)
> * Try to migrate to a new page instead. migrate.c
> * handles a large number of cases for us.
> */
> - ret = isolate_lru_page(page);
> + if (PageLRU(page))
> + ret = isolate_lru_page(page);
> + else if (!isolate_movable_page(page, ISOLATE_UNEVICTABLE))
> + ret = -EBUSY;
As pointed out in the previous response isolate_movable_page should
really have the same return value contract as [__]isolate_lru_page
> /*
> * Drop page reference which is came from get_any_page()
> * successful isolate_lru_page() already took another one.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-01-26 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 15:05 [PATCH v4 0/2] HWPOISON: soft offlining for non-lru movable page ysxie
2017-01-25 15:05 ` [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined ysxie
2017-01-26 9:18 ` Michal Hocko
2017-01-30 14:59 ` Yisheng Xie
2017-01-30 15:13 ` Michal Hocko
2017-01-25 15:05 ` [PATCH v4 2/2] HWPOISON: soft offlining for non-lru movable page ysxie
2017-01-26 9:27 ` Michal Hocko [this message]
2017-01-30 15:04 ` Yisheng Xie
2017-01-30 16:38 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126092725.GD6590@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qiuxishi@huawei.com \
--cc=vbabka@suse.cz \
--cc=ysxie@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).