From: Michal Hocko <mhocko@kernel.org>
To: Yisheng Xie <ysxie@foxmail.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
n-horiguchi@ah.jp.nec.com, minchan@kernel.org, vbabka@suse.cz,
guohanjun@huawei.com, qiuxishi@huawei.com
Subject: Re: [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined
Date: Mon, 30 Jan 2017 16:13:32 +0100 [thread overview]
Message-ID: <20170130151331.GA5311@dhcp22.suse.cz> (raw)
In-Reply-To: <588F54E8.5040303@foxmail.com>
On Mon 30-01-17 22:59:52, Yisheng Xie wrote:
> Hi， Michal，
> Sorry for late reply.
>
> On 01/26/2017 05:18 PM, Michal Hocko wrote:
> > On Wed 25-01-17 23:05:37, ysxie@foxmail.com wrote:
> >> From: Yisheng Xie <xieyisheng1@huawei.com>
> >>
> >> Define isolate_movable_page as a static inline function when
> >> CONFIG_MIGRATION is not enable. It should return false
> >> here which means failed to isolate movable pages.
> >>
> >> This patch do not have any functional change but prepare for
> >> later patch.
> > I think it would make more sense to make isolate_movable_page return int
> > and have the same semantic as __isolate_lru_page. This would be a better
> > preparatory patch for the later work.
> Yes, I think you are right, it is better to make isolate_movable_page return int
> just as what isolate_lru_page do, to make a better code style.
>
> It seems Andrew had already merged the fixed patch from Arnd Bergmann,
> Maybe I can rewrite it in a later patch if it is suitable :)
I guess Andrew can just drop the current series with the folow up fixes
and wait for your newer version.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2017-01-30 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 15:05 [PATCH v4 0/2] HWPOISON: soft offlining for non-lru movable page ysxie
2017-01-25 15:05 ` [PATCH v4 1/2] mm/migration: make isolate_movable_page always defined ysxie
2017-01-26 9:18 ` Michal Hocko
2017-01-30 14:59 ` Yisheng Xie
2017-01-30 15:13 ` Michal Hocko [this message]
2017-01-25 15:05 ` [PATCH v4 2/2] HWPOISON: soft offlining for non-lru movable page ysxie
2017-01-26 9:27 ` Michal Hocko
2017-01-30 15:04 ` Yisheng Xie
2017-01-30 16:38 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130151331.GA5311@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=qiuxishi@huawei.com \
--cc=vbabka@suse.cz \
--cc=ysxie@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).