From: Johannes Thumshirn <jthumshirn@suse.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@infradead.org>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: make nvmf_register_transport require a create_ctrl callback
Date: Fri, 27 Jan 2017 09:00:08 +0100 [thread overview]
Message-ID: <20170127080008.GA4501@linux-x5ow.site> (raw)
In-Reply-To: <2cc9ed5f-c9af-fd9d-2c90-04541ceebab6@grimberg.me>
On Thu, Jan 26, 2017 at 06:30:47PM +0200, Sagi Grimberg wrote:
>
> > static void __exit nvme_fc_exit_module(void)
> >diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> >index 557f29b..80f3695 100644
> >--- a/drivers/nvme/host/rdma.c
> >+++ b/drivers/nvme/host/rdma.c
> >@@ -2063,8 +2063,7 @@ static int __init nvme_rdma_init_module(void)
> > return ret;
> > }
> >
> >- nvmf_register_transport(&nvme_rdma_transport);
> >- return 0;
> >+ return = nvmf_register_transport(&nvme_rdma_transport);
Gah typo and I had only fc enabled in my .config.
Sorry.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-01-27 8:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 15:22 [PATCH] nvme: make nvmf_register_transport require a create_ctrl callback Johannes Thumshirn
2017-01-26 16:30 ` Sagi Grimberg
2017-01-27 8:00 ` Johannes Thumshirn [this message]
2017-01-26 17:45 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127080008.GA4501@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).