linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: Johannes Thumshirn <jthumshirn@suse.de>,
	Christoph Hellwig <hch@infradead.org>,
	Keith Busch <keith.busch@intel.com>
Cc: Jens Axboe <axboe@fb.com>,
	Linux NVMe Mailinglist <linux-nvme@lists.infradead.org>,
	Linux Kernel Mailinglist <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nvme: make nvmf_register_transport require a create_ctrl callback
Date: Thu, 26 Jan 2017 18:30:47 +0200	[thread overview]
Message-ID: <2cc9ed5f-c9af-fd9d-2c90-04541ceebab6@grimberg.me> (raw)
In-Reply-To: <20170126152228.15330-1-jthumshirn@suse.de>


>  static void __exit nvme_fc_exit_module(void)
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 557f29b..80f3695 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -2063,8 +2063,7 @@ static int __init nvme_rdma_init_module(void)
>  		return ret;
>  	}
>
> -	nvmf_register_transport(&nvme_rdma_transport);
> -	return 0;
> +	return = nvmf_register_transport(&nvme_rdma_transport);

??

  reply	other threads:[~2017-01-26 16:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26 15:22 [PATCH] nvme: make nvmf_register_transport require a create_ctrl callback Johannes Thumshirn
2017-01-26 16:30 ` Sagi Grimberg [this message]
2017-01-27  8:00   ` Johannes Thumshirn
2017-01-26 17:45 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cc9ed5f-c9af-fd9d-2c90-04541ceebab6@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=axboe@fb.com \
    --cc=hch@infradead.org \
    --cc=jthumshirn@suse.de \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).