linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Jean Delvare <jdelvare@suse.de>
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: piix4: Fix request_region size
Date: Sat, 28 Jan 2017 12:00:21 +0100	[thread overview]
Message-ID: <20170128110021.GA1604@katana> (raw)
In-Reply-To: <1485592582.4916.1.camel@suse.de>

[-- Attachment #1: Type: text/plain, Size: 284 bytes --]


> >  /* count for request_region */
> > -#define SMBIOSIZE	8
> > +#define SMBIOSIZE	9
> > 
> 
> Are you certain that all supported devices have this extra register?

Isn't it better to have a potentially unused register mapped than a
potentially used register unmapped?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2017-01-28 11:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-27 14:59 [PATCH] i2c: piix4: Fix request_region size Ricardo Ribalda Delgado
2017-01-28  8:36 ` Jean Delvare
2017-01-28 11:00   ` Wolfram Sang [this message]
2017-01-28 11:13     ` Jean Delvare
2017-01-30  1:11       ` Ricardo Ribalda Delgado
2017-01-31 13:42 ` Jean Delvare
2017-02-09 16:14 ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170128110021.GA1604@katana \
    --to=wsa@the-dreams.de \
    --cc=andy.shevchenko@gmail.com \
    --cc=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ricardo.ribalda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).