From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
linux-i2c@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i2c: piix4: Fix request_region size
Date: Mon, 30 Jan 2017 02:11:47 +0100 [thread overview]
Message-ID: <CAPybu_3prZYuGcHKx-ppm9_viKVm-VzgR6ou=O7vPiA0ocX16g@mail.gmail.com> (raw)
In-Reply-To: <20170128121346.1e530c1c@endymion>
Hi Jean and Wolfram
On Sat, Jan 28, 2017 at 12:13 PM, Jean Delvare <jdelvare@suse.de> wrote:
> Hi Wolfram,
>
> On Sat, 28 Jan 2017 12:00:21 +0100, Wolfram Sang wrote:
>>
>> > > /* count for request_region */
>> > > -#define SMBIOSIZE 8
>> > > +#define SMBIOSIZE 9
>> >
>> > Are you certain that all supported devices have this extra register?
>>
>> Isn't it better to have a potentially unused register mapped than a
>> potentially used register unmapped
We have been "lucky" that it is a ioport and not a mmap region,
otherwise we would have seen a nice oops :).
>
> My concern is that the region request could fail due to a conflict with
> another device, if the physical I/O region is only 8 and we try to
> request 9.
I do not think that this is the case, if you check the top of the file
you can see how there are many other definitions for registers. I
expect that SMBIOSIZE=8 is just the original author being
conservative.
Of course I cannot say that there is one platform where one extra
ioport can cause a conflict, but I believe that we must request all
the ports that we will use.
Regards!
>
> --
> Jean Delvare
> SUSE L3 Support
--
Ricardo Ribalda
next prev parent reply other threads:[~2017-01-30 1:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 14:59 [PATCH] i2c: piix4: Fix request_region size Ricardo Ribalda Delgado
2017-01-28 8:36 ` Jean Delvare
2017-01-28 11:00 ` Wolfram Sang
2017-01-28 11:13 ` Jean Delvare
2017-01-30 1:11 ` Ricardo Ribalda Delgado [this message]
2017-01-31 13:42 ` Jean Delvare
2017-02-09 16:14 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPybu_3prZYuGcHKx-ppm9_viKVm-VzgR6ou=O7vPiA0ocX16g@mail.gmail.com' \
--to=ricardo.ribalda@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).