[PATCH v2 0/2] mfd: lpc_ich: enable iTCO on Apollo Lake

[PATCH v2 0/2] mfd: lpc_ich: enable iTCO on Apollo Lake

[Andy Shevchenko]

Enable iTCo watchdog on Apollo Lake.

In v2:
- Fix authorship in patch 1
- rebase on top of ib-mfd-mtd-4.11

Andy Shevchenko (1):
  mfd: lpc_ich: Remove useless comments in core part

Tan Jui Nee (1):
  mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH

 drivers/mfd/lpc_ich.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

-- 
2.11.0

[PATCH v2 1/2] mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH

[Andy Shevchenko]

From: Tan Jui Nee <jui.nee.tan@intel.com>

Assign iTCO_version which effectively enables watchdog device on
Intel Apollo Lake PCH.

Signed-off-by: Tan Jui Nee <jui.nee.tan@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/lpc_ich.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index be42957a78e1..b2f234d5ee3b 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -567,6 +567,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
 	},
 	[LPC_APL] = {
 		.name = "Apollo Lake SoC",
+		.iTCO_version = 5,
 		.spi_type = INTEL_SPI_BXT,
 	},
 };
-- 
2.11.0

[PATCH v2 2/2] mfd: lpc_ich: Remove useless comments in core part

[Andy Shevchenko]

First of all, remove stalled references to datasheets. If someone knows
the document numbers, it would be added later.

Second, remove FSF snail address since it's subject to change. Actual
information can be found on FSF site on the internet.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/mfd/lpc_ich.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index b2f234d5ee3b..d98a5d974092 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -20,10 +20,6 @@
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  *  GNU General Public License for more details.
  *
- *  You should have received a copy of the GNU General Public License
- *  along with this program; see the file COPYING.  If not, write to
- *  the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
- *
  *  This driver supports the following I/O Controller hubs:
  *	(See the intel documentation on http://developer.intel.com.)
  *	document number 290655-003, 290677-014: 82801AA (ICH), 82801AB (ICHO)
@@ -45,18 +41,6 @@
  *	document number 322169-001, 322170-003: 5 Series, 3400 Series (PCH)
  *	document number 320066-003, 320257-008: EP80597 (IICH)
  *	document number 324645-001, 324646-001: Cougar Point (CPT)
- *	document number TBD : Patsburg (PBG)
- *	document number TBD : DH89xxCC
- *	document number TBD : Panther Point
- *	document number TBD : Lynx Point
- *	document number TBD : Lynx Point-LP
- *	document number TBD : Wellsburg
- *	document number TBD : Avoton SoC
- *	document number TBD : Coleto Creek
- *	document number TBD : Wildcat Point-LP
- *	document number TBD : 9 Series
- *	document number TBD : Lewisburg
- *	document number TBD : Apollo Lake SoC
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
-- 
2.11.0

Re: [PATCH v2 1/2] mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH

[Mika Westerberg]

On Sat, Jan 28, 2017 at 04:27:33PM +0200, Andy Shevchenko wrote:
> From: Tan Jui Nee <jui.nee.tan@intel.com>
> 
> Assign iTCO_version which effectively enables watchdog device on
> Intel Apollo Lake PCH.
> 
> Signed-off-by: Tan Jui Nee <jui.nee.tan@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH v2 2/2] mfd: lpc_ich: Remove useless comments in core part

[Mika Westerberg]

On Sat, Jan 28, 2017 at 04:27:34PM +0200, Andy Shevchenko wrote:
> First of all, remove stalled references to datasheets. If someone knows
> the document numbers, it would be added later.

Yeah, those are kind of useless without the document number.

> Second, remove FSF snail address since it's subject to change. Actual
> information can be found on FSF site on the internet.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH v2 1/2] mfd: lpc_ich: Enable watchdog on Intel Apollo Lake PCH

[Lee Jones]

On Sat, 28 Jan 2017, Andy Shevchenko wrote:

> From: Tan Jui Nee <jui.nee.tan@intel.com>
> 
> Assign iTCO_version which effectively enables watchdog device on
> Intel Apollo Lake PCH.
> 
> Signed-off-by: Tan Jui Nee <jui.nee.tan@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mfd/lpc_ich.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> index be42957a78e1..b2f234d5ee3b 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich.c
> @@ -567,6 +567,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
>  	},
>  	[LPC_APL] = {
>  		.name = "Apollo Lake SoC",
> +		.iTCO_version = 5,
>  		.spi_type = INTEL_SPI_BXT,
>  	},
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v2 2/2] mfd: lpc_ich: Remove useless comments in core part

[Lee Jones]

On Sat, 28 Jan 2017, Andy Shevchenko wrote:

> First of all, remove stalled references to datasheets. If someone knows
> the document numbers, it would be added later.
> 
> Second, remove FSF snail address since it's subject to change. Actual
> information can be found on FSF site on the internet.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mfd/lpc_ich.c | 16 ----------------
>  1 file changed, 16 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> index b2f234d5ee3b..d98a5d974092 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich.c
> @@ -20,10 +20,6 @@
>   *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>   *  GNU General Public License for more details.
>   *
> - *  You should have received a copy of the GNU General Public License
> - *  along with this program; see the file COPYING.  If not, write to
> - *  the Free Software Foundation, 675 Mass Ave, Cambridge, MA 02139, USA.
> - *
>   *  This driver supports the following I/O Controller hubs:
>   *	(See the intel documentation on http://developer.intel.com.)
>   *	document number 290655-003, 290677-014: 82801AA (ICH), 82801AB (ICHO)
> @@ -45,18 +41,6 @@
>   *	document number 322169-001, 322170-003: 5 Series, 3400 Series (PCH)
>   *	document number 320066-003, 320257-008: EP80597 (IICH)
>   *	document number 324645-001, 324646-001: Cougar Point (CPT)
> - *	document number TBD : Patsburg (PBG)
> - *	document number TBD : DH89xxCC
> - *	document number TBD : Panther Point
> - *	document number TBD : Lynx Point
> - *	document number TBD : Lynx Point-LP
> - *	document number TBD : Wellsburg
> - *	document number TBD : Avoton SoC
> - *	document number TBD : Coleto Creek
> - *	document number TBD : Wildcat Point-LP
> - *	document number TBD : 9 Series
> - *	document number TBD : Lewisburg
> - *	document number TBD : Apollo Lake SoC
>   */
>  
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog