From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: Vladimir Murzin <vladimir.murzin@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ARM: nommu: display vectors base
Date: Mon, 30 Jan 2017 14:03:26 +0000 [thread overview]
Message-ID: <20170130140326.GU27312@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170122032212.13456-1-afzal.mohd.ma@gmail.com>
On Sun, Jan 22, 2017 at 08:52:12AM +0530, afzal mohammed wrote:
> The exception base address is now dynamically estimated for no-MMU,
> display it. As it is the case, now limit VECTORS_BASE usage to MMU
> scenario.
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com>
As I wrote elsewhere...
> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
> index 0b5416fe7709..9ae474bf84fc 100644
> --- a/arch/arm/include/asm/memory.h
> +++ b/arch/arm/include/asm/memory.h
> @@ -83,6 +83,8 @@
> #define IOREMAP_MAX_ORDER 24
> #endif
>
> +#define VECTORS_BASE UL(0xffff0000)
> +
> #else /* CONFIG_MMU */
>
> /*
> @@ -111,8 +113,6 @@
>
> #endif /* !CONFIG_MMU */
>
> -#define VECTORS_BASE UL(0xffff0000)
I think adding a definition for VECTORS_BASE in asm/memory.h for nommu:
extern unsigned long vectors_base;
#define VECTORS_BASE vectors_base
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 823e119a5daa..9c68e3aba87c 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -522,7 +522,12 @@ void __init mem_init(void)
> " .data : 0x%p" " - 0x%p" " (%4td kB)\n"
> " .bss : 0x%p" " - 0x%p" " (%4td kB)\n",
>
> +#ifdef CONFIG_MMU
> MLK(VECTORS_BASE, VECTORS_BASE + PAGE_SIZE),
> +#else
> + MLK(vectors_base, vectors_base + PAGE_SIZE),
> +#endif
will mean that this conditional becomes unnecessary.
> diff --git a/arch/arm/mm/mm.h b/arch/arm/mm/mm.h
> index ce727d47275c..546f09437fca 100644
> --- a/arch/arm/mm/mm.h
> +++ b/arch/arm/mm/mm.h
> @@ -79,8 +79,9 @@ struct static_vm {
> extern struct list_head static_vmlist;
> extern struct static_vm *find_static_vm_vaddr(void *vaddr);
> extern __init void add_static_vm_early(struct static_vm *svm);
> -
> -#endif
> +#else /* CONFIG_MMU */
> +extern unsigned long vectors_base;
> +#endif /* CONFIG_MMU */
and you don't need this here either.
Thanks.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-01-30 14:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 3:16 [PATCH v2 0/4] ARM: v7-A !MMU support, prepare CONFIG_VECTORS_BASE removal afzal mohammed
2017-01-22 3:19 ` [PATCH v2 1/4] ARM: mmu: decouple VECTORS_BASE from Kconfig afzal mohammed
2017-01-22 3:20 ` [PATCH v2 2/4] ARM: nommu: dynamic exception base address setting afzal mohammed
2017-01-22 3:22 ` [PATCH v2 3/4] ARM: nommu: display vectors base afzal mohammed
2017-01-30 14:03 ` Russell King - ARM Linux [this message]
2017-01-30 21:39 ` Afzal Mohammed
2017-01-22 3:22 ` [PATCH v2 4/4] ARM: nommu: remove Hivecs configuration is asm afzal mohammed
2017-01-25 11:24 ` [PATCH v2 0/4] ARM: v7-A !MMU support, prepare CONFIG_VECTORS_BASE removal Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130140326.GU27312@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=afzal.mohd.ma@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).