From: Afzal Mohammed <afzal.mohd.ma@gmail.com>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Vladimir Murzin <vladimir.murzin@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ARM: nommu: display vectors base
Date: Tue, 31 Jan 2017 03:09:15 +0530 [thread overview]
Message-ID: <20170130213915.GA2976@afzalpc> (raw)
In-Reply-To: <20170130140326.GU27312@n2100.armlinux.org.uk>
Hi,
On Mon, Jan 30, 2017 at 02:03:26PM +0000, Russell King - ARM Linux wrote:
> On Sun, Jan 22, 2017 at 08:52:12AM +0530, afzal mohammed wrote:
> > The exception base address is now dynamically estimated for no-MMU,
> > display it. As it is the case, now limit VECTORS_BASE usage to MMU
> > scenario.
> > +#define VECTORS_BASE UL(0xffff0000)
> > +
> > #else /* CONFIG_MMU */
> >
> > /*
> > @@ -111,8 +113,6 @@
> >
> > #endif /* !CONFIG_MMU */
> >
> > -#define VECTORS_BASE UL(0xffff0000)
>
> I think adding a definition for VECTORS_BASE in asm/memory.h for nommu:
>
> extern unsigned long vectors_base;
> #define VECTORS_BASE vectors_base
Above was required to be enclosed by below,
#ifndef __ASSEMBLY__
#endif
Putting it inside the existing #ifndef __ASSEMBLY__ (which encloses
other externs) in asm/memory.h would put it alongside not so related
definitions as compared to the existing location.
And the existing #ifndef __ASSEMBLY__ in asm/memory.h is a bit down
that makes the above stand separately,
> > +#ifdef CONFIG_MMU
> > MLK(VECTORS_BASE, VECTORS_BASE + PAGE_SIZE),
> > +#else
> > + MLK(vectors_base, vectors_base + PAGE_SIZE),
> > +#endif
>
> will mean that this conditional becomes unnecessary.
> > -#endif
> > +#else /* CONFIG_MMU */
> > +extern unsigned long vectors_base;
> > +#endif /* CONFIG_MMU */
>
> and you don't need this here either.
but the above improvements make the patch simpler.
Regards
afzal
next prev parent reply other threads:[~2017-01-30 21:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 3:16 [PATCH v2 0/4] ARM: v7-A !MMU support, prepare CONFIG_VECTORS_BASE removal afzal mohammed
2017-01-22 3:19 ` [PATCH v2 1/4] ARM: mmu: decouple VECTORS_BASE from Kconfig afzal mohammed
2017-01-22 3:20 ` [PATCH v2 2/4] ARM: nommu: dynamic exception base address setting afzal mohammed
2017-01-22 3:22 ` [PATCH v2 3/4] ARM: nommu: display vectors base afzal mohammed
2017-01-30 14:03 ` Russell King - ARM Linux
2017-01-30 21:39 ` Afzal Mohammed [this message]
2017-01-22 3:22 ` [PATCH v2 4/4] ARM: nommu: remove Hivecs configuration is asm afzal mohammed
2017-01-25 11:24 ` [PATCH v2 0/4] ARM: v7-A !MMU support, prepare CONFIG_VECTORS_BASE removal Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170130213915.GA2976@afzalpc \
--to=afzal.mohd.ma@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).