* [PATCH] Input: refuse to register absolute devices without absinfo
@ 2017-01-31 23:15 Dmitry Torokhov
2017-02-01 8:35 ` Benjamin Tissoires
2017-02-01 11:07 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2017-01-31 23:15 UTC (permalink / raw)
To: linux-input; +Cc: Benjamin Tissoires, Jiri Kosina, linux-kernel
If device is supposed to send absolute events (i.e. EV_ABS bit is set in
dev->evbit) but dev->absinfo is not allocated, then the driver has done
something wrong, and we should not register such device. Otherwise we'll
crash later, when driver tries to send absolute event.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/input.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index f0d2d45a68e3..4617f2db9e36 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -2095,6 +2095,12 @@ int input_register_device(struct input_dev *dev)
const char *path;
int error;
+ if (test_bit(EV_ABS, dev->evbit) && !dev->absinfo) {
+ dev_err(&dev->dev,
+ "Absolute device without dev->absinfo, refusing to register\n");
+ return -EINVAL;
+ }
+
if (dev->devres_managed) {
devres = devres_alloc(devm_input_device_unregister,
sizeof(struct input_devres), GFP_KERNEL);
--
2.11.0.483.g087da7b7c-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: refuse to register absolute devices without absinfo
2017-01-31 23:15 [PATCH] Input: refuse to register absolute devices without absinfo Dmitry Torokhov
@ 2017-02-01 8:35 ` Benjamin Tissoires
2017-02-01 11:07 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2017-02-01 8:35 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Jiri Kosina, linux-kernel
On Jan 31 2017 or thereabouts, Dmitry Torokhov wrote:
> If device is supposed to send absolute events (i.e. EV_ABS bit is set in
> dev->evbit) but dev->absinfo is not allocated, then the driver has done
> something wrong, and we should not register such device. Otherwise we'll
> crash later, when driver tries to send absolute event.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
Looks good to me:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/input/input.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index f0d2d45a68e3..4617f2db9e36 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -2095,6 +2095,12 @@ int input_register_device(struct input_dev *dev)
> const char *path;
> int error;
>
> + if (test_bit(EV_ABS, dev->evbit) && !dev->absinfo) {
> + dev_err(&dev->dev,
> + "Absolute device without dev->absinfo, refusing to register\n");
> + return -EINVAL;
> + }
> +
> if (dev->devres_managed) {
> devres = devres_alloc(devm_input_device_unregister,
> sizeof(struct input_devres), GFP_KERNEL);
> --
> 2.11.0.483.g087da7b7c-goog
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: refuse to register absolute devices without absinfo
2017-01-31 23:15 [PATCH] Input: refuse to register absolute devices without absinfo Dmitry Torokhov
2017-02-01 8:35 ` Benjamin Tissoires
@ 2017-02-01 11:07 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2017-02-01 11:07 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input, Benjamin Tissoires, linux-kernel
On Tue, 31 Jan 2017, Dmitry Torokhov wrote:
> If device is supposed to send absolute events (i.e. EV_ABS bit is set in
> dev->evbit) but dev->absinfo is not allocated, then the driver has done
> something wrong, and we should not register such device. Otherwise we'll
> crash later, when driver tries to send absolute event.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-01 11:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-31 23:15 [PATCH] Input: refuse to register absolute devices without absinfo Dmitry Torokhov
2017-02-01 8:35 ` Benjamin Tissoires
2017-02-01 11:07 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).