From: David Carrillo-Cisneros <davidcc@google.com>
To: linux-kernel@vger.kernel.org
Cc: "Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Jiri Olsa" <jolsa@kernel.org>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Wang Nan" <wangnan0@huawei.com>, "He Kuang" <hekuang@huawei.com>,
"Michal Marek" <mmarek@suse.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Stephane Eranian" <eranian@google.com>,
"Paul Turner" <pjt@google.com>,
"David Carrillo-Cisneros" <davidcc@google.com>
Subject: [PATCH 3/4] tools lib feature: Do not redefine compiler configuration
Date: Wed, 1 Feb 2017 22:38:03 -0800 [thread overview]
Message-ID: <20170202063804.94027-4-davidcc@google.com> (raw)
In-Reply-To: <20170202063804.94027-1-davidcc@google.com>
Feature detection redefines CC, CCX and PKG_CONFIG, making the
output of feature detection inconsistent with the actual features
available during compilation when the above variables are used.
Fix it by using conditional assignment.
Signed-off-by: David Carrillo-Cisneros <davidcc@google.com>
---
tools/build/feature/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile
index 3dd2c600d250..d39e76f3a063 100644
--- a/tools/build/feature/Makefile
+++ b/tools/build/feature/Makefile
@@ -52,9 +52,9 @@ FILES= \
FILES := $(addprefix $(OUTPUT),$(FILES))
-CC := $(CROSS_COMPILE)gcc -MD
-CXX := $(CROSS_COMPILE)g++ -MD
-PKG_CONFIG := $(CROSS_COMPILE)pkg-config
+CC ?= $(CROSS_COMPILE)gcc -MD
+CXX ?= $(CROSS_COMPILE)g++ -MD
+PKG_CONFIG ?= $(CROSS_COMPILE)pkg-config
LLVM_CONFIG ?= llvm-config
all: $(FILES)
--
2.11.0.483.g087da7b7c-goog
next prev parent reply other threads:[~2017-02-02 6:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 6:38 [PATCH 0/4] Fixes for perf build and feature detection David Carrillo-Cisneros
2017-02-02 6:38 ` [PATCH 1/4] perf tools: pass PYTHON config to " David Carrillo-Cisneros
2017-02-06 13:19 ` Arnaldo Carvalho de Melo
2017-02-06 15:19 ` Namhyung Kim
2017-02-07 19:47 ` Arnaldo Carvalho de Melo
2017-02-08 3:15 ` David Carrillo-Cisneros
2017-02-08 5:28 ` [PATCH v2] tools lib traceevent: Robustify do_generate_dynamic_list_file David Carrillo-Cisneros
2017-02-08 12:44 ` Arnaldo Carvalho de Melo
2017-02-08 13:24 ` Arnaldo Carvalho de Melo
2017-02-09 5:03 ` David Carrillo-Cisneros
2017-02-10 7:47 ` [tip:perf/core] " tip-bot for David Carrillo-Cisneros
2017-02-02 6:38 ` [PATCH 2/4] " David Carrillo-Cisneros
2017-02-06 17:45 ` Arnaldo Carvalho de Melo
2017-02-02 6:38 ` David Carrillo-Cisneros [this message]
2017-02-06 13:38 ` [PATCH 3/4] tools lib feature: Do not redefine compiler configuration Arnaldo Carvalho de Melo
2017-02-06 15:42 ` Jiri Olsa
2017-02-02 6:38 ` [PATCH 4/4] tools include: Fix include path for uapi/asm-generic/mman.h David Carrillo-Cisneros
2017-02-02 12:56 ` Jiri Olsa
2017-02-06 18:25 ` Arnaldo Carvalho de Melo
2017-02-06 20:09 ` David Carrillo-Cisneros
2017-02-02 12:56 ` [PATCH 0/4] Fixes for perf build and feature detection Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170202063804.94027-4-davidcc@google.com \
--to=davidcc@google.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).