* [PATCH] phy: nsp-usb3: select PHYLIB
@ 2017-02-02 14:32 Arnd Bergmann
0 siblings, 0 replies; only message in thread
From: Arnd Bergmann @ 2017-02-02 14:32 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: Yendapally Reddy Dhananjaya Reddy, Arnd Bergmann, Anup Patel,
Rafał Miłecki, linux-kernel
Building this driver without PHYLIB fails:
ERROR: "mdio_driver_unregister" [drivers/phy/phy-bcm-nsp-usb3.ko] undefined!
ERROR: "mdio_driver_register" [drivers/phy/phy-bcm-nsp-usb3.ko] undefined!
ERROR: "mdiobus_write" [drivers/phy/phy-bcm-nsp-usb3.ko] undefined!
Unfortunately selecting PHYLIB without NETDEVICES produces a warning:
warning: (NET_DSA && NETLOGIC_XLR_NET && PHY_NSP_USB3) selects PHYLIB which has unmet direct dependencies (NETDEVICES)
so I'm adding a dependency on netdevices here.
Fixes: d7bc1a7d41bf ("phy: Add USB3 PHY support for Broadcom NSP SoC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index 853168bb3ba3..87c581f11297 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -509,7 +509,9 @@ config PHY_MESON8B_USB2
config PHY_NSP_USB3
tristate "Broadcom NorthStar plus USB3 PHY driver"
depends on OF && (ARCH_BCM_NSP || COMPILE_TEST)
+ depends on NETDEVICES # for PHYLIB
select GENERIC_PHY
+ select PHYLIB
default ARCH_BCM_NSP
help
Enable this to support the Broadcom Northstar plus USB3 PHY.
--
2.9.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-02 14:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-02 14:32 [PATCH] phy: nsp-usb3: select PHYLIB Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).