* [PATCH] staging: bcm2835-audio: fix spacing of macro
@ 2017-02-03 16:17 Hendrik v. Raven
2017-02-03 17:27 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Hendrik v. Raven @ 2017-02-03 16:17 UTC (permalink / raw)
To: Greg Kroah-Hartman, Stephen Warren, Lee Jones, Eric Anholt,
Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michael Zoran, Hendrik v. Raven, devel,
linux-rpi-kernel, linux-arm-kernel, linux-kernel
removes the unwanted spaces inside of sizeof( ), removing a complaint of
checkpatch.pl. Also removes the second space behind the macro name.
Signed-off-by: Hendrik v. Raven <hendrik@consetetur.de>
---
drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h b/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h
index 09f07fd891bb..dd2f162b1ccb 100644
--- a/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h
+++ b/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h
@@ -22,7 +22,7 @@
#define VC_AUDIO_SERVER_NAME MAKE_FOURCC("AUDS")
/* Maximum message length */
-#define VC_AUDIO_MAX_MSG_LEN (sizeof( VC_AUDIO_MSG_T ))
+#define VC_AUDIO_MAX_MSG_LEN (sizeof(VC_AUDIO_MSG_T))
/*
* List of screens that are currently supported
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: bcm2835-audio: fix spacing of macro
2017-02-03 16:17 [PATCH] staging: bcm2835-audio: fix spacing of macro Hendrik v. Raven
@ 2017-02-03 17:27 ` Joe Perches
2017-02-03 18:50 ` [PATCH] staging: bcm2835-audio: remove unused macro Hendrik v. Raven
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2017-02-03 17:27 UTC (permalink / raw)
To: Hendrik v. Raven, Greg Kroah-Hartman, Stephen Warren, Lee Jones,
Eric Anholt, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michael Zoran, devel, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
On Fri, 2017-02-03 at 17:17 +0100, Hendrik v. Raven wrote:
> VC_AUDIO_MAX_MSG_LEN
This macro seems unused and might as well be removed.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] staging: bcm2835-audio: remove unused macro
2017-02-03 17:27 ` Joe Perches
@ 2017-02-03 18:50 ` Hendrik v. Raven
2017-02-05 10:41 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Hendrik v. Raven @ 2017-02-03 18:50 UTC (permalink / raw)
To: Joe Perches, Greg Kroah-Hartman, Stephen Warren, Lee Jones,
Eric Anholt, Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michael Zoran, devel, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
Cc: Hendrik v. Raven
The VC_AUDIO_MAX_MSG_LEN macro is not used anywhere and has coding style
violations.
Signed-off-by: Hendrik v. Raven <hendrik@consetetur.de>
---
drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h b/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h
index 09f07fd891bb..da96f1bc2516 100644
--- a/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h
+++ b/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h
@@ -21,9 +21,6 @@
/* FourCC code used for VCHI connection */
#define VC_AUDIO_SERVER_NAME MAKE_FOURCC("AUDS")
-/* Maximum message length */
-#define VC_AUDIO_MAX_MSG_LEN (sizeof( VC_AUDIO_MSG_T ))
-
/*
* List of screens that are currently supported
* All message types supported for HOST->VC direction
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: bcm2835-audio: remove unused macro
2017-02-03 18:50 ` [PATCH] staging: bcm2835-audio: remove unused macro Hendrik v. Raven
@ 2017-02-05 10:41 ` Greg Kroah-Hartman
2017-02-14 9:35 ` [PATCH v2] " Hendrik v. Raven
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-02-05 10:41 UTC (permalink / raw)
To: Hendrik v. Raven
Cc: Joe Perches, Stephen Warren, Lee Jones, Eric Anholt,
Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michael Zoran, devel, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
On Fri, Feb 03, 2017 at 07:50:09PM +0100, Hendrik v. Raven wrote:
> The VC_AUDIO_MAX_MSG_LEN macro is not used anywhere and has coding style
> violations.
>
> Signed-off-by: Hendrik v. Raven <hendrik@consetetur.de>
Does not apply to my tree :(
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] staging: bcm2835-audio: remove unused macro
2017-02-05 10:41 ` Greg Kroah-Hartman
@ 2017-02-14 9:35 ` Hendrik v. Raven
0 siblings, 0 replies; 5+ messages in thread
From: Hendrik v. Raven @ 2017-02-14 9:35 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Joe Perches, Stephen Warren, Lee Jones, Eric Anholt,
Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Michael Zoran, devel, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
The VC_AUDIO_MAX_MSG_LEN macro is not used by anything in the
bcm2835-audio driver.
Signed-off-by: Hendrik v. Raven <hendrik@consetetur.de>
---
v2:
- rebased against next-20170214
---
drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h b/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h
index 928dd6009510..da96f1bc2516 100644
--- a/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h
+++ b/drivers/staging/bcm2835-audio/vc_vchi_audioserv_defs.h
@@ -21,9 +21,6 @@
/* FourCC code used for VCHI connection */
#define VC_AUDIO_SERVER_NAME MAKE_FOURCC("AUDS")
-/* Maximum message length */
-#define VC_AUDIO_MAX_MSG_LEN (sizeof(VC_AUDIO_MSG_T))
-
/*
* List of screens that are currently supported
* All message types supported for HOST->VC direction
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-14 9:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-03 16:17 [PATCH] staging: bcm2835-audio: fix spacing of macro Hendrik v. Raven
2017-02-03 17:27 ` Joe Perches
2017-02-03 18:50 ` [PATCH] staging: bcm2835-audio: remove unused macro Hendrik v. Raven
2017-02-05 10:41 ` Greg Kroah-Hartman
2017-02-14 9:35 ` [PATCH v2] " Hendrik v. Raven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).