* [PATCH v5 net-next] net: mvneta: implement .set_wol and .get_wol
@ 2017-02-06 6:58 Jisheng Zhang
2017-02-06 13:05 ` Andrew Lunn
2017-02-06 15:54 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jisheng Zhang @ 2017-02-06 6:58 UTC (permalink / raw)
To: thomas.petazzoni, davem
Cc: andrew, netdev, linux-kernel, Jingju Hou, Jisheng Zhang
From: Jingju Hou <houjingj@marvell.com>
The mvneta itself does not support WOL, but the PHY might.
So pass the calls to the PHY
Signed-off-by: Jingju Hou <houjingj@marvell.com>
Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
---
since v4:
- address Andrew Lunn's comment
since v3:
- really fix the build error
since v2,v1:
- using phy_dev member in struct net_device
- add commit msg
drivers/net/ethernet/marvell/mvneta.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index de6c47744b8e..0f4d1697be46 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -3927,6 +3927,25 @@ static int mvneta_ethtool_get_rxfh(struct net_device *dev, u32 *indir, u8 *key,
return 0;
}
+static void mvneta_ethtool_get_wol(struct net_device *dev,
+ struct ethtool_wolinfo *wol)
+{
+ wol->supported = 0;
+ wol->wolopts = 0;
+
+ if (dev->phydev)
+ phy_ethtool_get_wol(dev->phydev, wol);
+}
+
+static int mvneta_ethtool_set_wol(struct net_device *dev,
+ struct ethtool_wolinfo *wol)
+{
+ if (!dev->phydev)
+ return -EOPNOTSUPP;
+
+ return phy_ethtool_set_wol(dev->phydev, wol);
+}
+
static const struct net_device_ops mvneta_netdev_ops = {
.ndo_open = mvneta_open,
.ndo_stop = mvneta_stop,
@@ -3956,6 +3975,8 @@ const struct ethtool_ops mvneta_eth_tool_ops = {
.set_rxfh = mvneta_ethtool_set_rxfh,
.get_link_ksettings = phy_ethtool_get_link_ksettings,
.set_link_ksettings = mvneta_ethtool_set_link_ksettings,
+ .get_wol = mvneta_ethtool_get_wol,
+ .set_wol = mvneta_ethtool_set_wol,
};
/* Initialize hw */
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v5 net-next] net: mvneta: implement .set_wol and .get_wol
2017-02-06 6:58 [PATCH v5 net-next] net: mvneta: implement .set_wol and .get_wol Jisheng Zhang
@ 2017-02-06 13:05 ` Andrew Lunn
2017-02-06 15:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2017-02-06 13:05 UTC (permalink / raw)
To: Jisheng Zhang; +Cc: thomas.petazzoni, davem, netdev, linux-kernel, Jingju Hou
On Mon, Feb 06, 2017 at 02:58:13PM +0800, Jisheng Zhang wrote:
> From: Jingju Hou <houjingj@marvell.com>
>
> The mvneta itself does not support WOL, but the PHY might.
> So pass the calls to the PHY
>
> Signed-off-by: Jingju Hou <houjingj@marvell.com>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v5 net-next] net: mvneta: implement .set_wol and .get_wol
2017-02-06 6:58 [PATCH v5 net-next] net: mvneta: implement .set_wol and .get_wol Jisheng Zhang
2017-02-06 13:05 ` Andrew Lunn
@ 2017-02-06 15:54 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-02-06 15:54 UTC (permalink / raw)
To: jszhang; +Cc: thomas.petazzoni, andrew, netdev, linux-kernel, houjingj
From: Jisheng Zhang <jszhang@marvell.com>
Date: Mon, 6 Feb 2017 14:58:13 +0800
> From: Jingju Hou <houjingj@marvell.com>
>
> The mvneta itself does not support WOL, but the PHY might.
> So pass the calls to the PHY
>
> Signed-off-by: Jingju Hou <houjingj@marvell.com>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-06 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-06 6:58 [PATCH v5 net-next] net: mvneta: implement .set_wol and .get_wol Jisheng Zhang
2017-02-06 13:05 ` Andrew Lunn
2017-02-06 15:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).