From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Mylène Josserand" <mylene.josserand@free-electrons.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, wens@csie.org, perex@perex.cz,
tiwai@suse.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@free-electrons.com,
alexandre.belloni@free-electrons.com
Subject: Re: [PATCH v4 0/8] Add sun8i A33 audio driver
Date: Mon, 6 Feb 2017 08:49:13 +0100 [thread overview]
Message-ID: <20170206074913.7ih2m3hndxqcrehd@lukather> (raw)
In-Reply-To: <20170202092422.5588-1-mylene.josserand@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 4037 bytes --]
On Thu, Feb 02, 2017 at 10:24:14AM +0100, Mylène Josserand wrote:
> Hello everyone,
>
> This a V4 of my Allwinner A33 (sun8i) audio codec driver.
>
> Tested on "for-next" branch of ASoC repository with some patches
> to apply before this series:
> https://patchwork.kernel.org/patch/9447631/
> https://patchwork.kernel.org/patch/9423999/
> and one of my previous patch (from V2):
> https://patchwork.kernel.org/patch/9521121/
>
> Changes since V3:
> - Rebased my patches under Mark Brown's repo on "for-next" branch.
> - Removed the .owner from sun8i-codec driver, reported by KBuild robot
> - Updated patch 05/08 according to Rob Herring's review.
>
> Changes since V2:
> - Removed patches from v2 already merged:
> commit ebad64d193779 ("ASoC: sun4i-i2s: Increase DMA max burst to 8")
> commit 603a0c8af9cb2 ("clk: sunxi-ng: a33: Add CLK_SET_RATE_PARENT to ac-dig")
> - Removed "reset-names" from sun4i-i2s driver
> - Fixed the build warning from sun8i-codec
> - Fixed some various topics such as subject line
> for dt bindings patch, renamed the simple-card
> and disabled the simple-card.
>
> Changes since V1:
> - Remove the analog codec driver as a better version has been
> committed by Chen-Yu Tsai and is already merged.
> - Remove the audio-card as simple-card can be used
> - The DMA maxburst is set to 8 in the sun4i-i2s instead of
> adding the maxburst of 4 in Sun6i dma engine.
> - Create a new compatible for sun4i-i2s to handle the reset
> line.
> - Fix various problems in sun8i-codec driver according to V1's
> reviews
> - Add the pm_runtime hooks in sun8i-codec driver to prepare/
> unprepare clocks.
> - Update the DTS according to Chen-Yu's analog codec driver.
> - Rename sun8i-codec's clocks to "bus" and "mod"
> - The first "delay" issue from V1 is fixed by using a delay
> when enabling the headphone amplifier to let the amplifier
> being up.
>
> Patches 1 and 2 add a new compatible "allwinner,sun6i-a31-i2s"
> to handle the reset line for sun4i-i2s driver. It uses a quirk to
> use a version with or without reset lines.
>
> Patch 3 adds the sun8i codec driver which represents the digital part
> of the A33 codec. It supports only playback features.
>
> Path 4 fixes the previous issue of a "first time delay" in V1 (see cover
> letter). Do not hesitate if you have comments on this patch.
>
> Patches 5 adds the dt-bindings documentation for new audio driver
> added in this serie (sun8i-codec).
>
> Patch 6 adds the cpu DAI, codec and audio nodes to sun8i-a33 device tree.
>
> Patches 7 and 8 enable the audio on Parrot and Sinlinx's boards.
>
> The DAI for this A33 codec is the same than for A20: "sun4i-i2s".
> Currently, the sun8i-a33 codec driver handles only the playback feature.
> The other ones (such as capture) and all other interfaces except
> headphone are not supported. I will send a patch to handle the
> capture with microphones in next few weeks.
>
> Examples of amixer commands:
> amixer set 'Headphone' 75%
> amixer set 'Headphone' on
> amixer set 'DAC' on
> amixer set 'Right DAC Mixer RSlot 0' on
> amixer set 'Left DAC Mixer LSlot 0' on
>
> It was tested on Parrot and Sinlinx boards.
>
> Let me know if you have any comments on this serie.
>
> Thank you in advance,
> Best regards,
>
> Mylène Josserand (8):
> ASoC: sun4i-i2s: Update binding documentation to include A31
> ASoC: sun4i-i2s: Add quirks to handle a31 compatible
> ASoC: Add sun8i digital audio codec
> ASoC: sun8i-codec-analog: Add amplifier event to fix first delay
> ASoC: codecs: Add sun8i-a33 binding documentation
> ARM: dts: sun8i: Add audio codec, dai and card for A33
> ARM: dts: sun8i: parrot: Enable audio nodes
> ARM: dts: sun8i: sinlinx: Enable audio nodes
Applied the last three. There was a conflict in the last one that I
fixed.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2017-02-06 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 9:24 [PATCH v4 0/8] Add sun8i A33 audio driver Mylène Josserand
2017-02-02 9:24 ` [PATCH v4 1/8] ASoC: sun4i-i2s: Update binding documentation to include A31 Mylène Josserand
2017-02-08 10:10 ` Mylene Josserand
2017-02-08 10:33 ` Mark Brown
2017-02-02 9:24 ` [PATCH v4 2/8] ASoC: sun4i-i2s: Add quirks to handle a31 compatible Mylène Josserand
2017-02-02 9:24 ` [PATCH v4 3/8] ASoC: Add sun8i digital audio codec Mylène Josserand
2017-02-07 8:39 ` Chen-Yu Tsai
2017-02-08 9:39 ` Mylene Josserand
2017-02-02 9:24 ` [PATCH v4 4/8] ASoC: sun8i-codec-analog: Add amplifier event to fix first delay Mylène Josserand
2017-02-10 6:08 ` Chen-Yu Tsai
2017-02-10 12:01 ` Mark Brown
2017-02-02 9:24 ` [PATCH v4 5/8] ASoC: codecs: Add sun8i-a33 binding documentation Mylène Josserand
2017-02-02 9:24 ` [PATCH v4 6/8] ARM: dts: sun8i: Add audio codec, dai and card for A33 Mylène Josserand
2017-02-05 1:41 ` kbuild test robot
2017-02-02 9:24 ` [PATCH v4 7/8] ARM: dts: sun8i: parrot: Enable audio nodes Mylène Josserand
2017-02-02 9:24 ` [PATCH v4 8/8] ARM: dts: sun8i: sinlinx: " Mylène Josserand
2017-02-06 7:49 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206074913.7ih2m3hndxqcrehd@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mylene.josserand@free-electrons.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).