From: Chen-Yu Tsai <wens@csie.org>
To: "Mylène Josserand" <mylene.josserand@free-electrons.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: Re: [PATCH v4 4/8] ASoC: sun8i-codec-analog: Add amplifier event to fix first delay
Date: Fri, 10 Feb 2017 14:08:54 +0800 [thread overview]
Message-ID: <CAGb2v66NXJ5RG8VUbvtZcqXzzOvhRc8A_M1R=2rRpfnHNbZDpw@mail.gmail.com> (raw)
In-Reply-To: <20170202092422.5588-5-mylene.josserand@free-electrons.com>
On Thu, Feb 2, 2017 at 5:24 PM, Mylène Josserand
<mylene.josserand@free-electrons.com> wrote:
> When playing a sound for the first time, a short delay, where the audio
> file is not played, can be noticed.
> On a second play (right after), the sound is played correctly.
> If we wait a short time (~5 sec which corresponds to the aplay
> timeout), the delay is back.
>
> This patch fixes it by using an event on headphone amplifier.
> It allows to keep the amplifier enable while playing a sound.
> A delay of 700ms allows to wait that the amplifier is powered-up
> before playing the sound.
>
> Signed-off-by: Mylène Josserand <mylene.josserand@free-electrons.com>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
I get some static in my headphones in the time between when the
amplifier is enabled and when sound starts playing. Wonder if
this can be fixed in any way?
One solution that might work is to mute the headphone output
while the amp is being charged, by setting SUN8I_ADDA_HP_VOLC_HP_VOL
to 0, and then restoring the value once it is charged. In other
words, overriding the value for the duration of sun8i_headphone_amp_event.
Regards
ChenYu
next prev parent reply other threads:[~2017-02-10 6:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-02 9:24 [PATCH v4 0/8] Add sun8i A33 audio driver Mylène Josserand
2017-02-02 9:24 ` [PATCH v4 1/8] ASoC: sun4i-i2s: Update binding documentation to include A31 Mylène Josserand
2017-02-08 10:10 ` Mylene Josserand
2017-02-08 10:33 ` Mark Brown
2017-02-02 9:24 ` [PATCH v4 2/8] ASoC: sun4i-i2s: Add quirks to handle a31 compatible Mylène Josserand
2017-02-02 9:24 ` [PATCH v4 3/8] ASoC: Add sun8i digital audio codec Mylène Josserand
2017-02-07 8:39 ` Chen-Yu Tsai
2017-02-08 9:39 ` Mylene Josserand
2017-02-02 9:24 ` [PATCH v4 4/8] ASoC: sun8i-codec-analog: Add amplifier event to fix first delay Mylène Josserand
2017-02-10 6:08 ` Chen-Yu Tsai [this message]
2017-02-10 12:01 ` Mark Brown
2017-02-02 9:24 ` [PATCH v4 5/8] ASoC: codecs: Add sun8i-a33 binding documentation Mylène Josserand
2017-02-02 9:24 ` [PATCH v4 6/8] ARM: dts: sun8i: Add audio codec, dai and card for A33 Mylène Josserand
2017-02-05 1:41 ` kbuild test robot
2017-02-02 9:24 ` [PATCH v4 7/8] ARM: dts: sun8i: parrot: Enable audio nodes Mylène Josserand
2017-02-02 9:24 ` [PATCH v4 8/8] ARM: dts: sun8i: sinlinx: " Mylène Josserand
2017-02-06 7:49 ` [PATCH v4 0/8] Add sun8i A33 audio driver Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGb2v66NXJ5RG8VUbvtZcqXzzOvhRc8A_M1R=2rRpfnHNbZDpw@mail.gmail.com' \
--to=wens@csie.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mylene.josserand@free-electrons.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).