* [PATCH -next] drm: mxsfb: Make local symbol mxsfb_funcs static
@ 2017-02-05 16:05 Wei Yongjun
2017-02-06 10:02 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2017-02-05 16:05 UTC (permalink / raw)
To: Marek Vasut, David Airlie; +Cc: Wei Yongjun, dri-devel, linux-kernel
From: Wei Yongjun <weiyongjun1@huawei.com>
Fixes the following sparse warning:
drivers/gpu/drm/mxsfb/mxsfb_drv.c:129:38: warning:
symbol 'mxsfb_funcs' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index cdfbe02..ff0495d 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -126,7 +126,7 @@ static int mxsfb_pipe_prepare_fb(struct drm_simple_display_pipe *pipe,
return drm_fb_cma_prepare_fb(&pipe->plane, plane_state);
}
-struct drm_simple_display_pipe_funcs mxsfb_funcs = {
+static struct drm_simple_display_pipe_funcs mxsfb_funcs = {
.enable = mxsfb_pipe_enable,
.disable = mxsfb_pipe_disable,
.update = mxsfb_pipe_update,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm: mxsfb: Make local symbol mxsfb_funcs static
2017-02-05 16:05 [PATCH -next] drm: mxsfb: Make local symbol mxsfb_funcs static Wei Yongjun
@ 2017-02-06 10:02 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2017-02-06 10:02 UTC (permalink / raw)
To: Wei Yongjun
Cc: Marek Vasut, David Airlie, Wei Yongjun, linux-kernel, dri-devel
On Sun, Feb 05, 2017 at 04:05:38PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/gpu/drm/mxsfb/mxsfb_drv.c:129:38: warning:
> symbol 'mxsfb_funcs' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Both of your patches applied to drm-misc-next for 4.12.
Thanks, Daniel
> ---
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> index cdfbe02..ff0495d 100644
> --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
> @@ -126,7 +126,7 @@ static int mxsfb_pipe_prepare_fb(struct drm_simple_display_pipe *pipe,
> return drm_fb_cma_prepare_fb(&pipe->plane, plane_state);
> }
>
> -struct drm_simple_display_pipe_funcs mxsfb_funcs = {
> +static struct drm_simple_display_pipe_funcs mxsfb_funcs = {
> .enable = mxsfb_pipe_enable,
> .disable = mxsfb_pipe_disable,
> .update = mxsfb_pipe_update,
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-06 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-05 16:05 [PATCH -next] drm: mxsfb: Make local symbol mxsfb_funcs static Wei Yongjun
2017-02-06 10:02 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).