* Re: [PATCH] drivers: usb: musb: add code comment for clarification
[not found] <20170210035654.GA11033@embeddedgus>
@ 2017-02-10 13:22 ` Bin Liu
2017-02-11 0:57 ` [PATCH] " Gustavo A. R. Silva
0 siblings, 1 reply; 7+ messages in thread
From: Bin Liu @ 2017-02-10 13:22 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: gregkh, linux-usb, linux-kernel
On Thu, Feb 09, 2017 at 09:56:54PM -0600, Gustavo A. R. Silva wrote:
> Add code comment to make it clear that the fall-through is intentional.
> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
>
Don't need 'drivers:' in the subject.
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/usb/musb/musb_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 892088f..1aec986 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb *musb)
>
> return;
> }
> + /* FALLTHROUGH */
/* fall through */
as in CodingStyle.
> case MUSB_QUIRK_A_DISCONNECT_19:
> if (musb->quirk_retries--) {
> musb_dbg(musb,
> --
Regards,
-Bin.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] usb: musb: add code comment for clarification
2017-02-10 13:22 ` [PATCH] drivers: usb: musb: add code comment for clarification Bin Liu
@ 2017-02-11 0:57 ` Gustavo A. R. Silva
2017-02-14 17:31 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo A. R. Silva @ 2017-02-11 0:57 UTC (permalink / raw)
To: Bin Liu; +Cc: gregkh, linux-usb, linux-kernel
Add code comment to make it clear that the fall-through is intentional.
Read the link for more details: https://lkml.org/lkml/2017/2/9/292
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/usb/musb/musb_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 892088f..1aec986 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct
musb *musb)
return;
}
+ /* fall through */
case MUSB_QUIRK_A_DISCONNECT_19:
if (musb->quirk_retries--) {
musb_dbg(musb,
--
2.5.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] usb: musb: add code comment for clarification
2017-02-11 0:57 ` [PATCH] " Gustavo A. R. Silva
@ 2017-02-14 17:31 ` Greg KH
2017-02-14 18:12 ` Gustavo A. R. Silva
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2017-02-14 17:31 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Bin Liu, linux-usb, linux-kernel
On Fri, Feb 10, 2017 at 06:57:41PM -0600, Gustavo A. R. Silva wrote:
> Add code comment to make it clear that the fall-through is intentional.
> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/usb/musb/musb_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 892088f..1aec986 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb
> *musb)
>
> return;
> }
> + /* fall through */
> case MUSB_QUIRK_A_DISCONNECT_19:
> if (musb->quirk_retries--) {
> musb_dbg(musb,
The tabs are all gone from this patch, and it's line-wrapped, making it
impossible to be applied :(
Can you please fix this and resend?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] usb: musb: add code comment for clarification
2017-02-14 17:31 ` Greg KH
@ 2017-02-14 18:12 ` Gustavo A. R. Silva
2017-02-14 18:20 ` [PATCH v2] " Gustavo A. R. Silva
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo A. R. Silva @ 2017-02-14 18:12 UTC (permalink / raw)
To: Greg KH; +Cc: Bin Liu, linux-usb, linux-kernel
Quoting Greg KH <gregkh@linuxfoundation.org>:
> On Fri, Feb 10, 2017 at 06:57:41PM -0600, Gustavo A. R. Silva wrote:
>> Add code comment to make it clear that the fall-through is intentional.
>> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>> drivers/usb/musb/musb_core.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
>> index 892088f..1aec986 100644
>> --- a/drivers/usb/musb/musb_core.c
>> +++ b/drivers/usb/musb/musb_core.c
>> @@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb
>> *musb)
>>
>> return;
>> }
>> + /* fall through */
>> case MUSB_QUIRK_A_DISCONNECT_19:
>> if (musb->quirk_retries--) {
>> musb_dbg(musb,
>
> The tabs are all gone from this patch, and it's line-wrapped, making it
> impossible to be applied :(
>
> Can you please fix this and resend?
>
OK. I'll send it shortly.
Thanks
--
Gustavo A. R. Silva
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] usb: musb: add code comment for clarification
2017-02-14 18:12 ` Gustavo A. R. Silva
@ 2017-02-14 18:20 ` Gustavo A. R. Silva
2017-02-14 18:25 ` Greg KH
0 siblings, 1 reply; 7+ messages in thread
From: Gustavo A. R. Silva @ 2017-02-14 18:20 UTC (permalink / raw)
To: Greg KH; +Cc: Bin Liu, linux-usb, linux-kernel, Gustavo A. R. Silva
Add code comment to make it clear that the fall-through is intentional.
Read the link for more details: https://lkml.org/lkml/2017/2/9/292
Addresses-Coverity-ID: 1397608
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
Changes in v2:
Fix tabs and line-wrapping in previous patch.
drivers/usb/musb/musb_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 892088f..d8bae6c 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -1869,6 +1869,7 @@ static void musb_pm_runtime_check_session(struct musb *musb)
return;
}
+ /* fall through */
case MUSB_QUIRK_A_DISCONNECT_19:
if (musb->quirk_retries--) {
musb_dbg(musb,
--
2.5.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v2] usb: musb: add code comment for clarification
2017-02-14 18:20 ` [PATCH v2] " Gustavo A. R. Silva
@ 2017-02-14 18:25 ` Greg KH
2017-02-14 18:54 ` Bin Liu
0 siblings, 1 reply; 7+ messages in thread
From: Greg KH @ 2017-02-14 18:25 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: Bin Liu, linux-usb, linux-kernel
On Tue, Feb 14, 2017 at 12:20:39PM -0600, Gustavo A. R. Silva wrote:
> Add code comment to make it clear that the fall-through is intentional.
> Read the link for more details: https://lkml.org/lkml/2017/2/9/292
>
> Addresses-Coverity-ID: 1397608
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> Changes in v2:
> Fix tabs and line-wrapping in previous patch.
Thanks for this. Bin, I've applied this to my tree so it makes it into
4.11-rc1.
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] usb: musb: add code comment for clarification
2017-02-14 18:25 ` Greg KH
@ 2017-02-14 18:54 ` Bin Liu
0 siblings, 0 replies; 7+ messages in thread
From: Bin Liu @ 2017-02-14 18:54 UTC (permalink / raw)
To: Greg KH; +Cc: Gustavo A. R. Silva, linux-usb, linux-kernel
On Tue, Feb 14, 2017 at 10:25:11AM -0800, Greg KH wrote:
> On Tue, Feb 14, 2017 at 12:20:39PM -0600, Gustavo A. R. Silva wrote:
> > Add code comment to make it clear that the fall-through is intentional.
> > Read the link for more details: https://lkml.org/lkml/2017/2/9/292
> >
> > Addresses-Coverity-ID: 1397608
> > Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> > ---
> > Changes in v2:
> > Fix tabs and line-wrapping in previous patch.
>
> Thanks for this. Bin, I've applied this to my tree so it makes it into
> 4.11-rc1.
Thanks Greg for take it to v4.11.
Regards,
-Bin.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-02-14 18:55 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170210035654.GA11033@embeddedgus>
2017-02-10 13:22 ` [PATCH] drivers: usb: musb: add code comment for clarification Bin Liu
2017-02-11 0:57 ` [PATCH] " Gustavo A. R. Silva
2017-02-14 17:31 ` Greg KH
2017-02-14 18:12 ` Gustavo A. R. Silva
2017-02-14 18:20 ` [PATCH v2] " Gustavo A. R. Silva
2017-02-14 18:25 ` Greg KH
2017-02-14 18:54 ` Bin Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).