* [PATCH v2] net: ethernet: ti: cpsw: fix cpsw assignment in resume
@ 2017-02-14 12:42 Ivan Khoronzhuk
2017-02-14 19:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ivan Khoronzhuk @ 2017-02-14 12:42 UTC (permalink / raw)
To: mugunthanvnm
Cc: grygorii.strashko, netdev, linux-omap, linux-kernel, Ivan Khoronzhuk
There is a copy-paste error, which hides breaking of resume
for CPSW driver: there was replaced netdev_priv() to ndev_to_cpsw(ndev)
in suspend, but left it unchanged in resume.
Fixes: 606f39939595a4d4540406bfc11f265b2036af6d
(ti: cpsw: move platform data and slaves info to cpsw_common)
Reported-by: Alexey Starikovskiy <AStarikovskiy@topcon.com>
Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
Based on net/master
v1:
https://patchwork.ozlabs.org/patch/725876/
Since v1:
- rebased on net/master
drivers/net/ethernet/ti/cpsw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
index b203143..6508822 100644
--- a/drivers/net/ethernet/ti/cpsw.c
+++ b/drivers/net/ethernet/ti/cpsw.c
@@ -3160,7 +3160,7 @@ static int cpsw_resume(struct device *dev)
{
struct platform_device *pdev = to_platform_device(dev);
struct net_device *ndev = platform_get_drvdata(pdev);
- struct cpsw_common *cpsw = netdev_priv(ndev);
+ struct cpsw_common *cpsw = ndev_to_cpsw(ndev);
/* Select default pin state */
pinctrl_pm_select_default_state(dev);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] net: ethernet: ti: cpsw: fix cpsw assignment in resume
2017-02-14 12:42 [PATCH v2] net: ethernet: ti: cpsw: fix cpsw assignment in resume Ivan Khoronzhuk
@ 2017-02-14 19:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2017-02-14 19:54 UTC (permalink / raw)
To: ivan.khoronzhuk
Cc: mugunthanvnm, grygorii.strashko, netdev, linux-omap, linux-kernel
From: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Date: Tue, 14 Feb 2017 14:42:15 +0200
> There is a copy-paste error, which hides breaking of resume
> for CPSW driver: there was replaced netdev_priv() to ndev_to_cpsw(ndev)
> in suspend, but left it unchanged in resume.
>
> Fixes: 606f39939595a4d4540406bfc11f265b2036af6d
> (ti: cpsw: move platform data and slaves info to cpsw_common)
>
> Reported-by: Alexey Starikovskiy <AStarikovskiy@topcon.com>
> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-14 19:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-14 12:42 [PATCH v2] net: ethernet: ti: cpsw: fix cpsw assignment in resume Ivan Khoronzhuk
2017-02-14 19:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).