linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().
@ 2016-06-02  9:21 Purna Chandra Mandal
  2017-02-14  9:08 ` James Hogan
  0 siblings, 1 reply; 2+ messages in thread
From: Purna Chandra Mandal @ 2016-06-02  9:21 UTC (permalink / raw)
  To: linux-kernel
  Cc: linux-mips, Ralf Baechle, Purna Chandra Mandal, Harvey Hunt,
	Joshua Henderson

Early clock API pic32_get_pbclk() is defined in early_clk.c and
used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
set, early_clk.c isn't compiled and time.c fails to link.

Fix it by compiling early_clk.c always. Also sort files in
alphabetical order.

Cc: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Cc: Joshua Henderson <digitalpeer@digitalpeer.com>

Reported-by: Harvey Hunt <harvey.hunt@imgtec.com>
Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
Reviewed-by: Harvey Hunt <harvey.hunt@imgtec.com>

---

Changes in v2:
- update commit message

 arch/mips/pic32/pic32mzda/Makefile | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile
index 4a4c272..c286496 100644
--- a/arch/mips/pic32/pic32mzda/Makefile
+++ b/arch/mips/pic32/pic32mzda/Makefile
@@ -2,8 +2,7 @@
 # Joshua Henderson, <joshua.henderson@microchip.com>
 # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
 #
-obj-y			:= init.o time.o config.o
+obj-y			:= config.o early_clk.o init.o time.o
 
 obj-$(CONFIG_EARLY_PRINTK)	+= early_console.o      \
-				   early_pin.o		\
-				   early_clk.o
+				   early_pin.o
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] MIPS: pic32mzda: fix linker error for pic32_get_pbclk().
  2016-06-02  9:21 [PATCH v2] MIPS: pic32mzda: fix linker error for pic32_get_pbclk() Purna Chandra Mandal
@ 2017-02-14  9:08 ` James Hogan
  0 siblings, 0 replies; 2+ messages in thread
From: James Hogan @ 2017-02-14  9:08 UTC (permalink / raw)
  To: Purna Chandra Mandal
  Cc: linux-kernel, linux-mips, Ralf Baechle, Harvey Hunt, Joshua Henderson

[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]

On Thu, Jun 02, 2016 at 02:51:42PM +0530, Purna Chandra Mandal wrote:
> Early clock API pic32_get_pbclk() is defined in early_clk.c and
> used by time.c and early_console.c. When CONFIG_EARLY_PRINTK isn't
> set, early_clk.c isn't compiled and time.c fails to link.
> 
> Fix it by compiling early_clk.c always. Also sort files in
> alphabetical order.
> 
> Cc: Harvey Hunt <harvey.hunt@imgtec.com>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Cc: Joshua Henderson <digitalpeer@digitalpeer.com>
> 
> Reported-by: Harvey Hunt <harvey.hunt@imgtec.com>
> Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>
> Reviewed-by: Harvey Hunt <harvey.hunt@imgtec.com>

Applied

Thanks
James

> 
> ---
> 
> Changes in v2:
> - update commit message
> 
>  arch/mips/pic32/pic32mzda/Makefile | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/pic32/pic32mzda/Makefile b/arch/mips/pic32/pic32mzda/Makefile
> index 4a4c272..c286496 100644
> --- a/arch/mips/pic32/pic32mzda/Makefile
> +++ b/arch/mips/pic32/pic32mzda/Makefile
> @@ -2,8 +2,7 @@
>  # Joshua Henderson, <joshua.henderson@microchip.com>
>  # Copyright (C) 2015 Microchip Technology, Inc.  All rights reserved.
>  #
> -obj-y			:= init.o time.o config.o
> +obj-y			:= config.o early_clk.o init.o time.o
>  
>  obj-$(CONFIG_EARLY_PRINTK)	+= early_console.o      \
> -				   early_pin.o		\
> -				   early_clk.o
> +				   early_pin.o
> -- 
> 1.8.3.1
> 
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-14  9:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02  9:21 [PATCH v2] MIPS: pic32mzda: fix linker error for pic32_get_pbclk() Purna Chandra Mandal
2017-02-14  9:08 ` James Hogan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).