linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/9] staging: rtl8192u: fixing white space issue
@ 2017-02-14 20:07 simran singhal
  2017-02-16 18:34 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: simran singhal @ 2017-02-14 20:07 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel

Fix the following checkpatch.pl error and warnings:
WARNING: please, no space before tabs

Signed-off-by: simran singhal <singhalsimran0@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
index 873969c..a54dfad 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
@@ -30,7 +30,7 @@ typedef struct _TX_TS_RECORD{
 	u16				TxCurSeq;
 	BA_RECORD			TxPendingBARecord;	/*  For BA Originator */
 	BA_RECORD			TxAdmittedBARecord;	/*  For BA Originator */
-/* 	QOS_DL_RECORD		DLRecord; */
+/*	QOS_DL_RECORD	DLRecord; */
 	u8				bAddBaReqInProgress;
 	u8				bAddBaReqDelayed;
 	u8				bUsingBa;
@@ -48,7 +48,7 @@ typedef struct _RX_TS_RECORD {
 	u16				RxLastSeqNum;
 	u8				RxLastFragNum;
 	u8				num;
-/* 	QOS_DL_RECORD		DLRecord; */
+/*	QOS_DL_RECOR	DLRecord; */
 } RX_TS_RECORD, *PRX_TS_RECORD;
 
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 1/9] staging: rtl8192u: fixing white space issue
  2017-02-14 20:07 [PATCH v2 1/9] staging: rtl8192u: fixing white space issue simran singhal
@ 2017-02-16 18:34 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-02-16 18:34 UTC (permalink / raw)
  To: simran singhal; +Cc: devel, linux-kernel

On Wed, Feb 15, 2017 at 01:37:13AM +0530, simran singhal wrote:
> Fix the following checkpatch.pl error and warnings:
> WARNING: please, no space before tabs
> 
> Signed-off-by: simran singhal <singhalsimran0@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> index 873969c..a54dfad 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> @@ -30,7 +30,7 @@ typedef struct _TX_TS_RECORD{
>  	u16				TxCurSeq;
>  	BA_RECORD			TxPendingBARecord;	/*  For BA Originator */
>  	BA_RECORD			TxAdmittedBARecord;	/*  For BA Originator */
> -/* 	QOS_DL_RECORD		DLRecord; */
> +/*	QOS_DL_RECORD	DLRecord; */

Why did you change the number of tabs here?

Also, just delete unused fields, why keep them around?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-16 18:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-14 20:07 [PATCH v2 1/9] staging: rtl8192u: fixing white space issue simran singhal
2017-02-16 18:34 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).