* [PATCH] staging: xgifb: function definition argument should also have an identifier name
@ 2017-02-15 8:31 Arushi Singhal
2017-02-16 18:30 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Arushi Singhal @ 2017-02-15 8:31 UTC (permalink / raw)
To: arnaud.patard; +Cc: Greg Kroah-Hartman, devel, linux-kernel
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
index 500cabe41a3c..e4929314d33e 100644
--- a/drivers/staging/xgifb/vb_init.h
+++ b/drivers/staging/xgifb/vb_init.h
@@ -1,6 +1,6 @@
#ifndef _VBINIT_
#define _VBINIT_
unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long BaseAddr);
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name
2017-02-15 8:31 [PATCH] staging: xgifb: function definition argument should also have an identifier name Arushi Singhal
@ 2017-02-16 18:30 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2017-02-16 18:30 UTC (permalink / raw)
To: Arushi Singhal; +Cc: arnaud.patard, devel, linux-kernel
On Wed, Feb 15, 2017 at 02:01:47PM +0530, Arushi Singhal wrote:
> function definition argument 'struct vb_device_info *' and 'unsigned
> long' should also have an identifier name.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/xgifb/vb_init.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You sent two patches, both different, for the same file with the same
subject line, so I don't know what to do, so I will just delete both
from my inbox.
Please fix up, and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] staging: xgifb: function definition argument should also have an identifier name
@ 2017-02-16 19:17 Arushi Singhal
0 siblings, 0 replies; 6+ messages in thread
From: Arushi Singhal @ 2017-02-16 19:17 UTC (permalink / raw)
To: arnaud.patard; +Cc: Greg Kroah-Hartman, devel, linux-kernel
function definition argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
index 500cabe41a3c..e4929314d33e 100644
--- a/drivers/staging/xgifb/vb_init.h
+++ b/drivers/staging/xgifb/vb_init.h
@@ -1,6 +1,6 @@
#ifndef _VBINIT_
#define _VBINIT_
unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long BaseAddr);
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: xgifb: function definition argument should also have an identifier name
@ 2017-02-14 20:33 Arushi Singhal
2017-02-14 20:43 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Arushi Singhal @ 2017-02-14 20:33 UTC (permalink / raw)
To: arnaud.patard; +Cc: Greg Kroah-Hartman, devel, linux-kernel
function definition argument 'struct vb_device_info *' should also have
an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/xgifb/vb_init.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
index 500cabe41a3c..022486a516d6 100644
--- a/drivers/staging/xgifb/vb_init.h
+++ b/drivers/staging/xgifb/vb_init.h
@@ -1,6 +1,6 @@
#ifndef _VBINIT_
#define _VBINIT_
unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long);
#endif
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: xgifb: function definition argument should also have an identifier name
2017-02-14 20:33 Arushi Singhal
@ 2017-02-14 20:43 ` Joe Perches
[not found] ` <CA+XqjF-btw9=_jWVtdHDq9NSh5SizaZthuM4jsfWkXnRHfn9DQ@mail.gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Joe Perches @ 2017-02-14 20:43 UTC (permalink / raw)
To: Arushi Singhal, arnaud.patard; +Cc: Greg Kroah-Hartman, devel, linux-kernel
On Wed, 2017-02-15 at 02:03 +0530, Arushi Singhal wrote:
> function definition argument 'struct vb_device_info *' should also have
> an identifier name.
[]
> diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
[]
> @@ -1,6 +1,6 @@
> #ifndef _VBINIT_
> #define _VBINIT_
> unsigned char XGIInitNew(struct pci_dev *pdev);
> -void XGIRegInit(struct vb_device_info *, unsigned long);
> +void XGIRegInit(struct vb_device_info *pVBInfo, unsigned long);
Why do one argument but not the other?
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-02-16 19:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-15 8:31 [PATCH] staging: xgifb: function definition argument should also have an identifier name Arushi Singhal
2017-02-16 18:30 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2017-02-16 19:17 Arushi Singhal
2017-02-14 20:33 Arushi Singhal
2017-02-14 20:43 ` Joe Perches
[not found] ` <CA+XqjF-btw9=_jWVtdHDq9NSh5SizaZthuM4jsfWkXnRHfn9DQ@mail.gmail.com>
2017-02-15 3:38 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).