linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] MIPS: ip27: disable qlge driver in defconfig
@ 2017-02-03 16:43 Arnd Bergmann
  2017-02-15 10:38 ` James Hogan
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2017-02-03 16:43 UTC (permalink / raw)
  To: Ralf Baechle; +Cc: Arnd Bergmann, linux-mips, linux-kernel

One of the last remaining failures in kernelci.org is for a gcc bug:

drivers/net/ethernet/qlogic/qlge/qlge_main.c:4819:1: error: insn does not satisfy its constraints:
drivers/net/ethernet/qlogic/qlge/qlge_main.c:4819:1: internal compiler error: in extract_constrain_insn, at recog.c:2190

This is apparently broken in gcc-6 but fixed in gcc-7, and I cannot reproduce the
problem here. However, it is clear that ip27_defconfig does not actually need
this driver as the platform has only PCI-X but not PCIe, and the qlge adapter
in turn is PCIe-only.

The driver was originally enabled in 2010 along with lots of other drivers.

Fixes: 59d302b342e5 ("MIPS: IP27: Make defconfig useful again.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/mips/configs/ip27_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig
index 18f024967dcd..e582069b44fd 100644
--- a/arch/mips/configs/ip27_defconfig
+++ b/arch/mips/configs/ip27_defconfig
@@ -205,7 +205,6 @@ CONFIG_MLX4_EN=m
 # CONFIG_MLX4_DEBUG is not set
 CONFIG_TEHUTI=m
 CONFIG_BNX2X=m
-CONFIG_QLGE=m
 CONFIG_SFC=m
 CONFIG_BE2NET=m
 CONFIG_LIBERTAS_THINFIRM=m
-- 
2.9.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] MIPS: ip27: disable qlge driver in defconfig
  2017-02-03 16:43 [PATCH] MIPS: ip27: disable qlge driver in defconfig Arnd Bergmann
@ 2017-02-15 10:38 ` James Hogan
  0 siblings, 0 replies; 2+ messages in thread
From: James Hogan @ 2017-02-15 10:38 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: Ralf Baechle, linux-mips, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

On Fri, Feb 03, 2017 at 05:43:50PM +0100, Arnd Bergmann wrote:
> One of the last remaining failures in kernelci.org is for a gcc bug:
> 
> drivers/net/ethernet/qlogic/qlge/qlge_main.c:4819:1: error: insn does not satisfy its constraints:
> drivers/net/ethernet/qlogic/qlge/qlge_main.c:4819:1: internal compiler error: in extract_constrain_insn, at recog.c:2190
> 
> This is apparently broken in gcc-6 but fixed in gcc-7, and I cannot reproduce the
> problem here. However, it is clear that ip27_defconfig does not actually need
> this driver as the platform has only PCI-X but not PCIe, and the qlge adapter
> in turn is PCIe-only.
> 
> The driver was originally enabled in 2010 along with lots of other drivers.
> 
> Fixes: 59d302b342e5 ("MIPS: IP27: Make defconfig useful again.")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied

Thanks
James

> ---
>  arch/mips/configs/ip27_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/mips/configs/ip27_defconfig b/arch/mips/configs/ip27_defconfig
> index 18f024967dcd..e582069b44fd 100644
> --- a/arch/mips/configs/ip27_defconfig
> +++ b/arch/mips/configs/ip27_defconfig
> @@ -205,7 +205,6 @@ CONFIG_MLX4_EN=m
>  # CONFIG_MLX4_DEBUG is not set
>  CONFIG_TEHUTI=m
>  CONFIG_BNX2X=m
> -CONFIG_QLGE=m
>  CONFIG_SFC=m
>  CONFIG_BE2NET=m
>  CONFIG_LIBERTAS_THINFIRM=m
> -- 
> 2.9.0
> 
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-02-15 10:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-03 16:43 [PATCH] MIPS: ip27: disable qlge driver in defconfig Arnd Bergmann
2017-02-15 10:38 ` James Hogan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).