* [PATCH 2/2] uapi: fix linux/rds.h userspace compilation error
@ 2017-02-15 20:09 Dmitry V. Levin
2017-02-16 15:05 ` [PATCH v2 " Dmitry V. Levin
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry V. Levin @ 2017-02-15 20:09 UTC (permalink / raw)
To: David S. Miller; +Cc: linux-kernel
On the kernel side, sockaddr_storage is #define'd to
__kernel_sockaddr_storage. Replacing struct sockaddr_storage with
struct __kernel_sockaddr_storage defined by <linux/socket.h> fixes
the following linux/rds.h userspace compilation error:
/usr/include/linux/rds.h:226:26: error: field 'dest_addr' has incomplete type
struct sockaddr_storage dest_addr;
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
include/uapi/linux/rds.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
index 3ff5cc2..804c9b2 100644
--- a/include/uapi/linux/rds.h
+++ b/include/uapi/linux/rds.h
@@ -35,6 +35,7 @@
#define _LINUX_RDS_H
#include <linux/types.h>
+#include <linux/socket.h> /* For __kernel_sockaddr_storage. */
#define RDS_IB_ABI_VERSION 0x301
@@ -223,7 +224,7 @@ struct rds_get_mr_args {
};
struct rds_get_mr_for_dest_args {
- struct sockaddr_storage dest_addr;
+ struct __kernel_sockaddr_storage dest_addr;
struct rds_iovec vec;
__u64 cookie_addr;
__u64 flags;
--
ldv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] uapi: fix linux/rds.h userspace compilation error
2017-02-15 20:09 [PATCH 2/2] uapi: fix linux/rds.h userspace compilation error Dmitry V. Levin
@ 2017-02-16 15:05 ` Dmitry V. Levin
2017-02-19 23:16 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry V. Levin @ 2017-02-16 15:05 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux-kernel
On the kernel side, sockaddr_storage is #define'd to
__kernel_sockaddr_storage. Replacing struct sockaddr_storage with
struct __kernel_sockaddr_storage defined by <linux/socket.h> fixes
the following linux/rds.h userspace compilation error:
/usr/include/linux/rds.h:226:26: error: field 'dest_addr' has incomplete type
struct sockaddr_storage dest_addr;
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
v2: Cc'ed netdev
include/uapi/linux/rds.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
index 3ff5cc2..804c9b2 100644
--- a/include/uapi/linux/rds.h
+++ b/include/uapi/linux/rds.h
@@ -35,6 +35,7 @@
#define _LINUX_RDS_H
#include <linux/types.h>
+#include <linux/socket.h> /* For __kernel_sockaddr_storage. */
#define RDS_IB_ABI_VERSION 0x301
@@ -223,7 +224,7 @@ struct rds_get_mr_args {
};
struct rds_get_mr_for_dest_args {
- struct sockaddr_storage dest_addr;
+ struct __kernel_sockaddr_storage dest_addr;
struct rds_iovec vec;
__u64 cookie_addr;
__u64 flags;
--
ldv
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/2] uapi: fix linux/rds.h userspace compilation error
2017-02-16 15:05 ` [PATCH v2 " Dmitry V. Levin
@ 2017-02-19 23:16 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2017-02-19 23:16 UTC (permalink / raw)
To: ldv; +Cc: netdev, linux-kernel
From: "Dmitry V. Levin" <ldv@altlinux.org>
Date: Thu, 16 Feb 2017 18:05:45 +0300
> On the kernel side, sockaddr_storage is #define'd to
> __kernel_sockaddr_storage. Replacing struct sockaddr_storage with
> struct __kernel_sockaddr_storage defined by <linux/socket.h> fixes
> the following linux/rds.h userspace compilation error:
>
> /usr/include/linux/rds.h:226:26: error: field 'dest_addr' has incomplete type
> struct sockaddr_storage dest_addr;
>
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-19 23:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-15 20:09 [PATCH 2/2] uapi: fix linux/rds.h userspace compilation error Dmitry V. Levin
2017-02-16 15:05 ` [PATCH v2 " Dmitry V. Levin
2017-02-19 23:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).