linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] rtc: cpcap: new rtc driver
Date: Mon, 20 Feb 2017 08:31:56 -0800	[thread overview]
Message-ID: <20170220163155.GH21809@atomide.com> (raw)
In-Reply-To: <20170220073535.27393-2-sre@kernel.org>

* Sebastian Reichel <sre@kernel.org> [170219 23:37]:
> This driver supports the Motorola CPCAP PMIC found on
> some of Motorola's mobile phones, such as the Droid 4.

Hey that's cool, works for me for reading and setting date :)
Just noticed one thing, see below.

> +Requires node properties:
> +- compatible: should contain "motorola,cpcap-rtc"
> +- interrupts: An interrupt specifier for alarm and 1 Hz irq
> +
> +Example:
> +
> +cpcap_rtc: rtc {
> +	compatible = "motorola,cpcap-rtc";
> +	interrupts = <39 IRQ_TYPE_NONE>, <26 IRQ_TYPE_NONE>;
> +};

I tried rtcwake -s 3, but got the following:

rtcwake: cannot open /sys/class/rtc/rtc0/device/power/wakeup:
No such file or directory
rtcwake: /dev/rtc0 not enabled for wakeup events

Then tried adding "wakeup-source" to above but I think the driver
needs something, maybe probably just PM ops?

Regards,

Tony

  reply	other threads:[~2017-02-20 16:32 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-20  7:35 [PATCH 0/1] Motorola CPCAP PMIC RTC Sebastian Reichel
2017-02-20  7:35 ` [PATCH 1/1] rtc: cpcap: new rtc driver Sebastian Reichel
2017-02-20 16:31   ` Tony Lindgren [this message]
2017-02-20 16:38     ` Alexandre Belloni
2017-02-20 17:21       ` Tony Lindgren
2017-02-20 17:27         ` Tony Lindgren
2017-02-20 19:35           ` Sebastian Reichel
2017-02-21  6:16 ` [PATCHv2] " Sebastian Reichel
2017-02-21 23:52   ` Alexandre Belloni
2017-02-22  1:56     ` Sebastian Reichel
2017-02-22  8:18       ` Alexandre Belloni
2017-02-23  1:03 ` [PATCHv3 1/2] dt-bindings: Add vendor prefix for Motorola Sebastian Reichel
2017-02-23  1:03   ` [PATCHv3 2/2] rtc: cpcap: new rtc driver Sebastian Reichel
2017-02-27 23:49     ` Rob Herring
2017-02-27 23:48   ` [PATCHv3 1/2] dt-bindings: Add vendor prefix for Motorola Rob Herring
2017-03-02  0:27 ` [PATCHv4 " Sebastian Reichel
2017-03-02  0:27   ` [PATCHv4 2/2] rtc: cpcap: new rtc driver Sebastian Reichel
2017-03-02 14:11     ` Rob Herring
2017-03-09  0:34     ` Alexandre Belloni
2017-03-09  0:33   ` [PATCHv4 1/2] dt-bindings: Add vendor prefix for Motorola Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170220163155.GH21809@atomide.com \
    --to=tony@atomide.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).