Re: [PATCH 1/1] rtc: cpcap: new rtc driver

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1924 bytes --]

Hi,

On Mon, Feb 20, 2017 at 09:27:37AM -0800, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [170220 09:21]:
> > * Alexandre Belloni <alexandre.belloni@free-electrons.com> [170220 08:40]:
> > > On 20/02/2017 at 08:31:56 -0800, Tony Lindgren wrote:
> > > > * Sebastian Reichel <sre@kernel.org> [170219 23:37]:
> > > > > This driver supports the Motorola CPCAP PMIC found on
> > > > > some of Motorola's mobile phones, such as the Droid 4.
> > > > 
> > > > Hey that's cool, works for me for reading and setting date :)
> > > > Just noticed one thing, see below.
> > > > 
> > > > > +Requires node properties:
> > > > > +- compatible: should contain "motorola,cpcap-rtc"
> > > > > +- interrupts: An interrupt specifier for alarm and 1 Hz irq
> > > > > +
> > > > > +Example:
> > > > > +
> > > > > +cpcap_rtc: rtc {
> > > > > +	compatible = "motorola,cpcap-rtc";
> > > > > +	interrupts = <39 IRQ_TYPE_NONE>, <26 IRQ_TYPE_NONE>;
> > > > > +};
> > > > 
> > > > I tried rtcwake -s 3, but got the following:
> > > > 
> > > > rtcwake: cannot open /sys/class/rtc/rtc0/device/power/wakeup:
> > > > No such file or directory
> > > > rtcwake: /dev/rtc0 not enabled for wakeup events
> > > > 
> > > > Then tried adding "wakeup-source" to above but I think the driver
> > > > needs something, maybe probably just PM ops?
> > > > 
> > > 
> > > Probably device_init_wakeup(dev, 1) ?
> > 
> > That gets us a bit closer but now produces:
> > 
> > rtcwake: write error
> 
> Oh user error.. It needs to be done with:
> 
> # rtcwake -s 3 -m mem
> 
> And with the addition of device_init_wakeup(dev, 1) to the probe
> it works for me. So Sebastian, with that change, please feel free
> to add:
> 
> Tested-by: Tony Lindgren <tony@atomide.com>

Nice. I actually forgot to mention, that its missing wakeup support
for now and now its already done :) I will resend later.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]