* [PATCH] Fix lock up when switching off discrete graphics card in Dell XPS 9560 https://bugzilla.kernel.org/show_bug.cgi?id=156341 @ 2017-02-21 0:36 Tobias Schumacher 2017-02-21 9:41 ` Ladislav Michl 0 siblings, 1 reply; 5+ messages in thread From: Tobias Schumacher @ 2017-02-21 0:36 UTC (permalink / raw) To: rjw, lenb; +Cc: linux-acpi, linux-kernel, Tobias Schumacher Signed-off-by: Tobias Schumacher <tobe.schumacher@gmail.com> --- drivers/acpi/blacklist.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index 4421f7c..7945f2f 100644 --- a/drivers/acpi/blacklist.c +++ b/drivers/acpi/blacklist.c @@ -188,6 +188,20 @@ static struct dmi_system_id acpi_rev_dmi_table[] __initdata = { DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"), }, }, + /* + * Resolves issues that cause the system to lock up + * under certain conditions when the discrete graphics + * card is turned off + */ + { + .callback = dmi_enable_rev_override, + .ident = "DELL XPS 15 (2017)", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"), + }, + }, + #endif {} }; -- 2.9.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix lock up when switching off discrete graphics card in Dell XPS 9560 https://bugzilla.kernel.org/show_bug.cgi?id=156341 2017-02-21 0:36 [PATCH] Fix lock up when switching off discrete graphics card in Dell XPS 9560 https://bugzilla.kernel.org/show_bug.cgi?id=156341 Tobias Schumacher @ 2017-02-21 9:41 ` Ladislav Michl 2017-02-21 19:33 ` Tobias Schumacher 0 siblings, 1 reply; 5+ messages in thread From: Ladislav Michl @ 2017-02-21 9:41 UTC (permalink / raw) To: Tobias Schumacher; +Cc: rjw, lenb, linux-acpi, linux-kernel Hi Tobias, On Tue, Feb 21, 2017 at 01:36:25AM +0100, Tobias Schumacher wrote: > Signed-off-by: Tobias Schumacher <tobe.schumacher@gmail.com> > --- > drivers/acpi/blacklist.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > index 4421f7c..7945f2f 100644 > --- a/drivers/acpi/blacklist.c > +++ b/drivers/acpi/blacklist.c > @@ -188,6 +188,20 @@ static struct dmi_system_id acpi_rev_dmi_table[] __initdata = { > DMI_MATCH(DMI_PRODUCT_NAME, "Latitude 3350"), > }, > }, > + /* > + * Resolves issues that cause the system to lock up > + * under certain conditions when the discrete graphics > + * card is turned off > + */ > + { > + .callback = dmi_enable_rev_override, > + .ident = "DELL XPS 15 (2017)", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 9560"), > + }, > + }, > + > #endif > {} > }; I thought conclusion was _not_ adding any new devices into this evergrowing list. Or am I mistaken? As otherwise I'll sent similar patch for my laptop ;-) ladis ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix lock up when switching off discrete graphics card in Dell XPS 9560 https://bugzilla.kernel.org/show_bug.cgi?id=156341 2017-02-21 9:41 ` Ladislav Michl @ 2017-02-21 19:33 ` Tobias Schumacher 2017-02-27 22:19 ` Rafael J. Wysocki 0 siblings, 1 reply; 5+ messages in thread From: Tobias Schumacher @ 2017-02-21 19:33 UTC (permalink / raw) To: Ladislav Michl; +Cc: rjw, lenb, linux-acpi, linux-kernel Hi Ladislav, Am Dienstag, den 21.02.2017, 10:41 +0100 schrieb Ladislav Michl: > Hi Tobias, > > On Tue, Feb 21, 2017 at 01:36:25AM +0100, Tobias Schumacher wrote: > > Signed-off-by: Tobias Schumacher <tobe.schumacher@gmail.com> > > --- > > drivers/acpi/blacklist.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > > index 4421f7c..7945f2f 100644 > > --- a/drivers/acpi/blacklist.c > > +++ b/drivers/acpi/blacklist.c > > @@ -188,6 +188,20 @@ static struct dmi_system_id > > acpi_rev_dmi_table[] __initdata = { > > DMI_MATCH(DMI_PRODUCT_NAME, "Latitude > > 3350"), > > }, > > }, > > + /* > > + * Resolves issues that cause the system to lock up > > + * under certain conditions when the discrete graphics > > + * card is turned off > > + */ > > + { > > + .callback = dmi_enable_rev_override, > > + .ident = "DELL XPS 15 (2017)", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > > + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 > > 9560"), > > + }, > > + }, > > + > > #endif > > {} > > }; > > I thought conclusion was _not_ adding any new devices into this > evergrowing > list. Or am I mistaken? As otherwise I'll sent similar patch for my > laptop ;-) I don't know to be honest - I recently switched back from Mac to Linux and searched for a way to get things working properly. Without any kernel parameters and patches switching off the discrete graphics will lead to lockups when executing for example lspci. Booting with 'acpi_osi=! acpi_osi="Windows 2009"' fixes this, but unfortunately the touchpad will stop working properly. With this patch both things work. If the conclusion is not adding new devices here, is there also a prefered way of fixing this? I guess getting Dell to fix this would be the ideal solution, but what can we do in the meantime? Would adding a kernel parameter like acpi_rev that overrides the reported ACPI revision be acceptable? The only other solution I could thing of would be patching the ACPI tables. Tobias ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix lock up when switching off discrete graphics card in Dell XPS 9560 https://bugzilla.kernel.org/show_bug.cgi?id=156341 2017-02-21 19:33 ` Tobias Schumacher @ 2017-02-27 22:19 ` Rafael J. Wysocki 2017-02-27 22:30 ` Tobias Schumacher 0 siblings, 1 reply; 5+ messages in thread From: Rafael J. Wysocki @ 2017-02-27 22:19 UTC (permalink / raw) To: Tobias Schumacher Cc: Ladislav Michl, Rafael J. Wysocki, Len Brown, ACPI Devel Maling List, Linux Kernel Mailing List On Tue, Feb 21, 2017 at 8:33 PM, Tobias Schumacher <tobe.schumacher@gmail.com> wrote: > Hi Ladislav, > > Am Dienstag, den 21.02.2017, 10:41 +0100 schrieb Ladislav Michl: >> Hi Tobias, >> >> On Tue, Feb 21, 2017 at 01:36:25AM +0100, Tobias Schumacher wrote: >> > Signed-off-by: Tobias Schumacher <tobe.schumacher@gmail.com> >> > --- >> > drivers/acpi/blacklist.c | 14 ++++++++++++++ >> > 1 file changed, 14 insertions(+) >> > >> > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c >> > index 4421f7c..7945f2f 100644 >> > --- a/drivers/acpi/blacklist.c >> > +++ b/drivers/acpi/blacklist.c >> > @@ -188,6 +188,20 @@ static struct dmi_system_id >> > acpi_rev_dmi_table[] __initdata = { >> > DMI_MATCH(DMI_PRODUCT_NAME, "Latitude >> > 3350"), >> > }, >> > }, >> > + /* >> > + * Resolves issues that cause the system to lock up >> > + * under certain conditions when the discrete graphics >> > + * card is turned off >> > + */ >> > + { >> > + .callback = dmi_enable_rev_override, >> > + .ident = "DELL XPS 15 (2017)", >> > + .matches = { >> > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), >> > + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 >> > 9560"), >> > + }, >> > + }, >> > + >> > #endif >> > {} >> > }; >> >> I thought conclusion was _not_ adding any new devices into this >> evergrowing >> list. Or am I mistaken? As otherwise I'll sent similar patch for my >> laptop ;-) > > I don't know to be honest - I recently switched back from Mac to Linux > and searched for a way to get things working properly. Without any > kernel parameters and patches switching off the discrete graphics will > lead to lockups when executing for example lspci. Booting with > 'acpi_osi=! acpi_osi="Windows 2009"' fixes this, but unfortunately the > touchpad will stop working properly. With this patch both things work. > > If the conclusion is not adding new devices here, is there also a > prefered way of fixing this? I guess getting Dell to fix this would be > the ideal solution, but what can we do in the meantime? Would adding a > kernel parameter like acpi_rev that overrides the reported ACPI > revision be acceptable? The only other solution I could thing of would > be patching the ACPI tables. Did you try to boot with acpi_rev_override in the kernel command line? Thanks, Rafael ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Fix lock up when switching off discrete graphics card in Dell XPS 9560 https://bugzilla.kernel.org/show_bug.cgi?id=156341 2017-02-27 22:19 ` Rafael J. Wysocki @ 2017-02-27 22:30 ` Tobias Schumacher 0 siblings, 0 replies; 5+ messages in thread From: Tobias Schumacher @ 2017-02-27 22:30 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Ladislav Michl, Rafael J. Wysocki, Len Brown, ACPI Devel Maling List, Linux Kernel Mailing List Hi Rafael, Am Montag, den 27.02.2017, 23:19 +0100 schrieb Rafael J. Wysocki: > On Tue, Feb 21, 2017 at 8:33 PM, Tobias Schumacher > <tobe.schumacher@gmail.com> wrote: > > Hi Ladislav, > > > > Am Dienstag, den 21.02.2017, 10:41 +0100 schrieb Ladislav Michl: > > > Hi Tobias, > > > > > > On Tue, Feb 21, 2017 at 01:36:25AM +0100, Tobias Schumacher > > > wrote: > > > > Signed-off-by: Tobias Schumacher <tobe.schumacher@gmail.com> > > > > --- > > > > drivers/acpi/blacklist.c | 14 ++++++++++++++ > > > > 1 file changed, 14 insertions(+) > > > > > > > > diff --git a/drivers/acpi/blacklist.c > > > > b/drivers/acpi/blacklist.c > > > > index 4421f7c..7945f2f 100644 > > > > --- a/drivers/acpi/blacklist.c > > > > +++ b/drivers/acpi/blacklist.c > > > > @@ -188,6 +188,20 @@ static struct dmi_system_id > > > > acpi_rev_dmi_table[] __initdata = { > > > > DMI_MATCH(DMI_PRODUCT_NAME, "Latitude > > > > 3350"), > > > > }, > > > > }, > > > > + /* > > > > + * Resolves issues that cause the system to lock up > > > > + * under certain conditions when the discrete graphics > > > > + * card is turned off > > > > + */ > > > > + { > > > > + .callback = dmi_enable_rev_override, > > > > + .ident = "DELL XPS 15 (2017)", > > > > + .matches = { > > > > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > > > > + DMI_MATCH(DMI_PRODUCT_NAME, "XPS 15 > > > > 9560"), > > > > + }, > > > > + }, > > > > + > > > > #endif > > > > {} > > > > }; > > > > > > I thought conclusion was _not_ adding any new devices into this > > > evergrowing > > > list. Or am I mistaken? As otherwise I'll sent similar patch for > > > my > > > laptop ;-) > > > > I don't know to be honest - I recently switched back from Mac to > > Linux > > and searched for a way to get things working properly. Without any > > kernel parameters and patches switching off the discrete graphics > > will > > lead to lockups when executing for example lspci. Booting with > > 'acpi_osi=! acpi_osi="Windows 2009"' fixes this, but unfortunately > > the > > touchpad will stop working properly. With this patch both things > > work. > > > > If the conclusion is not adding new devices here, is there also a > > prefered way of fixing this? I guess getting Dell to fix this would > > be > > the ideal solution, but what can we do in the meantime? Would > > adding a > > kernel parameter like acpi_rev that overrides the reported ACPI > > revision be acceptable? The only other solution I could thing of > > would > > be patching the ACPI tables. > > Did you try to boot with acpi_rev_override in the kernel command > line? I actually searched for an option like that but didn't find it, that's why I came up with the patch. Now I tried, looks like it works great! Thanks a lot! Tobias ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-27 22:39 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-02-21 0:36 [PATCH] Fix lock up when switching off discrete graphics card in Dell XPS 9560 https://bugzilla.kernel.org/show_bug.cgi?id=156341 Tobias Schumacher 2017-02-21 9:41 ` Ladislav Michl 2017-02-21 19:33 ` Tobias Schumacher 2017-02-27 22:19 ` Rafael J. Wysocki 2017-02-27 22:30 ` Tobias Schumacher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).