From: Greg KH <greg@kroah.com>
To: Joakim Tjernlund <joakim.tjernlund@infinera.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] Correct function definition for C++
Date: Wed, 22 Feb 2017 08:10:22 +0100 [thread overview]
Message-ID: <20170222071022.GA9186@kroah.com> (raw)
In-Reply-To: <20170221152405.7552-1-joakim.tjernlund@infinera.com>
On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote:
> C++ does does not like the extra extern before asmlinkage, remove it.
>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> ---
> include/linux/printk.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/printk.h b/include/linux/printk.h
> index 3472cc6..be823f5 100644
> --- a/include/linux/printk.h
> +++ b/include/linux/printk.h
Why are you building this file with a C++ compiler?
Also, this is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
thanks,
greg k-h
next prev parent reply other threads:[~2017-02-22 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 15:24 [PATCH 1/2] Correct function definition for C++ Joakim Tjernlund
2017-02-21 15:24 ` [PATCH 2/2] compiler.h: fix C++ uninitialized const issue Joakim Tjernlund
2017-02-22 7:10 ` Greg KH [this message]
2017-02-22 7:50 ` [PATCH 1/2] Correct function definition for C++ Joakim Tjernlund
2017-02-22 13:03 ` greg
2017-02-22 14:00 ` Joakim Tjernlund
2017-02-22 14:22 ` greg
2017-02-22 16:25 ` Joakim Tjernlund
2017-02-28 23:15 ` Thomas Backlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222071022.GA9186@kroah.com \
--to=greg@kroah.com \
--cc=joakim.tjernlund@infinera.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).